mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-05-13 15:33:51 +02:00
5de2f97a05dbwrapper: use `SpanReader` for iterator keys (Lőrinc)f0e498af5ctest: cover failed `CDBIterator::GetKey()` deserialization (Lőrinc) Pull request description: ### Problem `CDBIterator::GetKey()` only deserializes the current LevelDB key once and `GetKeyImpl()` already exposes that key as a contiguous borrowed byte span, and `GetKey()` creates a fresh local reader and only performs immediate forward reads before returning. The copied `DataStream` currently insulates the iterator entry from a failed decode, so switching to a borrowed reader is only safe if a deserialization failure still returns false and leaves the same key/value readable afterward. > [!NOTE] > The same simplification does not apply to `GetValue()`, because that path deobfuscates the value bytes in place first and still needs an owning mutable buffer. ### Fix Add a preparatory test with an invalid reads and checks that the failed decode [does not consume](eb85cacd29/src/leveldb/include/leveldb/iterator.h (L60-L62)) the current iterator entry. Then switch `GetKey()` to `SpanReader` so the key bytes are read in place instead of being copied into a temporary `DataStream`. This keeps the same exception swallowing and `bool` return semantics while avoiding the extra allocation and copy. ### Context Related to https://github.com/bitcoin/bitcoin/pull/34483 and https://github.com/bitcoin/bitcoin/pull/35025 ### Reproducer `gettxoutsetinfo` is ~10-12% faster for up-to-date blocks (run on SSD), see: <details><summary>2026-04-20 | gettxoutsetinfo | rpi5-8 | aarch64 | Cortex-A76 | 4 cores | 7.7Gi RAM | ext4 | SSD</summary> ``` COMMITS="64a88c8c1edc7ee5cef623d9aa8179a239e27ce9 57dc0202ddb7b4cbdd521fb237a25fc4d7f28ddf"; \ BASE_DIR="/mnt/my_storage"; DATA_DIR="$BASE_DIR/BitcoinData"; LOG_DIR="$BASE_DIR/logs"; \ mkdir -p "$LOG_DIR" && \ (echo ""; for c in $COMMITS; do git cat-file -e "$c^{commit}" 2>/dev/null || git fetch -q origin "$c" || exit 1; git log -1 --pretty='%h %s' "$c" || exit 1; done) && \ (echo "" && echo "$(date -I) | gettxoutsetinfo | $(hostname) | $(uname -m) | $(lscpu | grep 'Model name' | head -1 | cut -d: -f2 | xargs) | $(nproc) cores | $(free -h | awk '/^Mem:/{print $2}') RAM | $(df -T $BASE_DIR | awk 'NR==2{print $2}') | $(lsblk -no ROTA $(df --output=source $BASE_DIR | tail -1) | grep -q 1 && echo HDD || echo SSD)"; echo "") && \ hyperfine \ --sort command \ --runs 10 \ --export-json "$BASE_DIR/gettxoutsetinfo-$(sed -E 's/([a-f0-9]{8})[a-f0-9]* ?/\1-/g;s/-$//'<<<"$COMMITS")-$(date +%s).json" \ --parameter-list COMMIT ${COMMITS// /,} \ --prepare "killall -9 bitcoind 2>/dev/null || true; rm -f $DATA_DIR/debug.log; git clean -fxd && git reset --hard {COMMIT} && \ cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release && ninja -C build bitcoind bitcoin-cli -j$(nproc) && \ ./build/bin/bitcoind -datadir=$DATA_DIR -connect=0 -listen=0 -dnsseed=0 -coinstatsindex=0 -txindex=0 -blockfilterindex=0 -daemon -printtoconsole=0; \ ./build/bin/bitcoin-cli -datadir=$DATA_DIR -rpcwait getblockcount >/dev/null" \ --conclude "./build/bin/bitcoin-cli -datadir=$DATA_DIR stop 2>/dev/null || true; killall bitcoind 2>/dev/null || true; sleep 10; \ grep -q 'Done loading' $DATA_DIR/debug.log && grep 'Bitcoin Core version' $DATA_DIR/debug.log | grep -q \"\$(git rev-parse --short=12 {COMMIT})\"; \ cp $DATA_DIR/debug.log $LOG_DIR/gettxoutsetinfo-{COMMIT}-$(date +%s).log" \ "./build/bin/bitcoin-cli -datadir=$DATA_DIR -rpcclienttimeout=0 -named gettxoutsetinfo hash_type='none' use_index='false' >/dev/null"64a88c8c1eMerge bitcoin/bitcoin#35096: kernel: align height parameters to int32_t in btck API 57dc0202dd dbwrapper: use SpanReader for iterator keys Benchmark 1: ./build/bin/bitcoin-cli -datadir=/mnt/my_storage/BitcoinData -rpcclienttimeout=0 -named gettxoutsetinfo hash_type='none' use_index='false' >/dev/null (COMMIT =64a88c8c1e) Time (mean ± σ): 109.002 s ± 3.091 s [User: 0.003 s, System: 0.004 s] Range (min … max): 106.191 s … 113.608 s 10 runs Benchmark 2: ./build/bin/bitcoin-cli -datadir=/mnt/my_storage/BitcoinData -rpcclienttimeout=0 -named gettxoutsetinfo hash_type='none' use_index='false' >/dev/null (COMMIT = 57dc0202ddb7b4cbdd521fb237a25fc4d7f28ddf) Time (mean ± σ): 97.711 s ± 1.172 s [User: 0.003 s, System: 0.004 s] Range (min … max): 96.651 s … 100.104 s 10 runs Relative speed comparison 1.12 ± 0.03 ./build/bin/bitcoin-cli -datadir=/mnt/my_storage/BitcoinData -rpcclienttimeout=0 -named gettxoutsetinfo hash_type='none' use_index='false' >/dev/null (COMMIT =64a88c8c1e) 1.00 ./build/bin/bitcoin-cli -datadir=/mnt/my_storage/BitcoinData -rpcclienttimeout=0 -named gettxoutsetinfo hash_type='none' use_index='false' >/dev/null (COMMIT = 57dc0202ddb7b4cbdd521fb237a25fc4d7f28ddf) ``` </details> ACKs for top commit: achow101: ACK5de2f97a05sedited: ACK5de2f97a05andrewtoth: ACK5de2f97a05optout21: ACK5de2f97a05theStack: ACK5de2f97a05Tree-SHA512: 33b62149625b3ce2a378be9b4dffa361f11e324a2768e460c549b9b704efa78bf96ef5e24487d0cec82c18dafff6ba4571c06ad545684cf8738f38b9d21e9b0c
433 lines
15 KiB
C++
433 lines
15 KiB
C++
// Copyright (c) 2012-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <dbwrapper.h>
|
|
#include <test/util/common.h>
|
|
#include <test/util/random.h>
|
|
#include <test/util/setup_common.h>
|
|
#include <uint256.h>
|
|
#include <util/byte_units.h>
|
|
#include <util/string.h>
|
|
|
|
#include <memory>
|
|
#include <ranges>
|
|
|
|
#include <boost/test/unit_test.hpp>
|
|
|
|
using util::ToString;
|
|
|
|
BOOST_FIXTURE_TEST_SUITE(dbwrapper_tests, BasicTestingSetup)
|
|
|
|
BOOST_AUTO_TEST_CASE(dbwrapper)
|
|
{
|
|
// Perform tests both obfuscated and non-obfuscated.
|
|
for (const bool obfuscate : {false, true}) {
|
|
constexpr size_t CACHE_SIZE{1_MiB};
|
|
const fs::path path{m_args.GetDataDirBase() / "dbwrapper"};
|
|
|
|
Obfuscation obfuscation;
|
|
std::vector<std::pair<uint8_t, uint256>> key_values{};
|
|
|
|
// Write values
|
|
{
|
|
CDBWrapper dbw{{.path = path, .cache_bytes = CACHE_SIZE, .wipe_data = true, .obfuscate = obfuscate}};
|
|
BOOST_CHECK_EQUAL(obfuscate, !dbw.IsEmpty());
|
|
|
|
// Ensure that we're doing real obfuscation when obfuscate=true
|
|
obfuscation = dbwrapper_private::GetObfuscation(dbw);
|
|
BOOST_CHECK_EQUAL(obfuscate, dbwrapper_private::GetObfuscation(dbw));
|
|
|
|
for (uint8_t k{0}; k < 10; ++k) {
|
|
uint8_t key{k};
|
|
uint256 value{m_rng.rand256()};
|
|
dbw.Write(key, value);
|
|
key_values.emplace_back(key, value);
|
|
}
|
|
}
|
|
|
|
// Verify that the obfuscation key is never obfuscated
|
|
{
|
|
CDBWrapper dbw{{.path = path, .cache_bytes = CACHE_SIZE, .obfuscate = false}};
|
|
BOOST_CHECK_EQUAL(obfuscation, dbwrapper_private::GetObfuscation(dbw));
|
|
}
|
|
|
|
// Read back the values
|
|
{
|
|
CDBWrapper dbw{{.path = path, .cache_bytes = CACHE_SIZE, .obfuscate = obfuscate}};
|
|
|
|
// Ensure obfuscation is read back correctly
|
|
BOOST_CHECK_EQUAL(obfuscation, dbwrapper_private::GetObfuscation(dbw));
|
|
BOOST_CHECK_EQUAL(obfuscate, dbwrapper_private::GetObfuscation(dbw));
|
|
|
|
// Verify all written values
|
|
for (const auto& [key, expected_value] : key_values) {
|
|
uint256 read_value{};
|
|
BOOST_CHECK(dbw.Read(key, read_value));
|
|
BOOST_CHECK_EQUAL(read_value, expected_value);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(dbwrapper_basic_data)
|
|
{
|
|
// Perform tests both obfuscated and non-obfuscated.
|
|
for (bool obfuscate : {false, true}) {
|
|
fs::path ph = m_args.GetDataDirBase() / (obfuscate ? "dbwrapper_1_obfuscate_true" : "dbwrapper_1_obfuscate_false");
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB, .memory_only = false, .wipe_data = true, .obfuscate = obfuscate});
|
|
|
|
uint256 res;
|
|
uint32_t res_uint_32;
|
|
bool res_bool;
|
|
|
|
// Ensure that we're doing real obfuscation when obfuscate=true
|
|
BOOST_CHECK_EQUAL(obfuscate, dbwrapper_private::GetObfuscation(dbw));
|
|
|
|
//Simulate block raw data - "b + block hash"
|
|
std::string key_block = "b" + m_rng.rand256().ToString();
|
|
|
|
uint256 in_block = m_rng.rand256();
|
|
dbw.Write(key_block, in_block);
|
|
BOOST_CHECK(dbw.Read(key_block, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in_block.ToString());
|
|
|
|
//Simulate file raw data - "f + file_number"
|
|
std::string key_file = strprintf("f%04x", m_rng.rand32());
|
|
|
|
uint256 in_file_info = m_rng.rand256();
|
|
dbw.Write(key_file, in_file_info);
|
|
BOOST_CHECK(dbw.Read(key_file, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in_file_info.ToString());
|
|
|
|
//Simulate transaction raw data - "t + transaction hash"
|
|
std::string key_transaction = "t" + m_rng.rand256().ToString();
|
|
|
|
uint256 in_transaction = m_rng.rand256();
|
|
dbw.Write(key_transaction, in_transaction);
|
|
BOOST_CHECK(dbw.Read(key_transaction, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in_transaction.ToString());
|
|
|
|
//Simulate UTXO raw data - "c + transaction hash"
|
|
std::string key_utxo = "c" + m_rng.rand256().ToString();
|
|
|
|
uint256 in_utxo = m_rng.rand256();
|
|
dbw.Write(key_utxo, in_utxo);
|
|
BOOST_CHECK(dbw.Read(key_utxo, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in_utxo.ToString());
|
|
|
|
//Simulate last block file number - "l"
|
|
uint8_t key_last_blockfile_number{'l'};
|
|
uint32_t lastblockfilenumber = m_rng.rand32();
|
|
dbw.Write(key_last_blockfile_number, lastblockfilenumber);
|
|
BOOST_CHECK(dbw.Read(key_last_blockfile_number, res_uint_32));
|
|
BOOST_CHECK_EQUAL(lastblockfilenumber, res_uint_32);
|
|
|
|
//Simulate Is Reindexing - "R"
|
|
uint8_t key_IsReindexing{'R'};
|
|
bool isInReindexing = m_rng.randbool();
|
|
dbw.Write(key_IsReindexing, isInReindexing);
|
|
BOOST_CHECK(dbw.Read(key_IsReindexing, res_bool));
|
|
BOOST_CHECK_EQUAL(isInReindexing, res_bool);
|
|
|
|
//Simulate last block hash up to which UXTO covers - 'B'
|
|
uint8_t key_lastblockhash_uxto{'B'};
|
|
uint256 lastblock_hash = m_rng.rand256();
|
|
dbw.Write(key_lastblockhash_uxto, lastblock_hash);
|
|
BOOST_CHECK(dbw.Read(key_lastblockhash_uxto, res));
|
|
BOOST_CHECK_EQUAL(lastblock_hash, res);
|
|
|
|
//Simulate file raw data - "F + filename_number + filename"
|
|
std::string file_option_tag = "F";
|
|
uint8_t filename_length = m_rng.randbits(8);
|
|
std::string filename = "randomfilename";
|
|
std::string key_file_option = strprintf("%s%01x%s", file_option_tag, filename_length, filename);
|
|
|
|
bool in_file_bool = m_rng.randbool();
|
|
dbw.Write(key_file_option, in_file_bool);
|
|
BOOST_CHECK(dbw.Read(key_file_option, res_bool));
|
|
BOOST_CHECK_EQUAL(res_bool, in_file_bool);
|
|
}
|
|
}
|
|
|
|
// Test batch operations
|
|
BOOST_AUTO_TEST_CASE(dbwrapper_batch)
|
|
{
|
|
// Perform tests both obfuscated and non-obfuscated.
|
|
for (const bool obfuscate : {false, true}) {
|
|
fs::path ph = m_args.GetDataDirBase() / (obfuscate ? "dbwrapper_batch_obfuscate_true" : "dbwrapper_batch_obfuscate_false");
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB, .memory_only = true, .wipe_data = false, .obfuscate = obfuscate});
|
|
|
|
uint8_t key{'i'};
|
|
uint256 in = m_rng.rand256();
|
|
uint8_t key2{'j'};
|
|
uint256 in2 = m_rng.rand256();
|
|
uint8_t key3{'k'};
|
|
uint256 in3 = m_rng.rand256();
|
|
|
|
uint256 res;
|
|
CDBBatch batch(dbw);
|
|
|
|
batch.Write(key, in);
|
|
batch.Write(key2, in2);
|
|
batch.Write(key3, in3);
|
|
|
|
// Remove key3 before it's even been written
|
|
batch.Erase(key3);
|
|
|
|
dbw.WriteBatch(batch);
|
|
|
|
BOOST_CHECK(dbw.Read(key, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in.ToString());
|
|
BOOST_CHECK(dbw.Read(key2, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in2.ToString());
|
|
|
|
// key3 should've never been written
|
|
BOOST_CHECK(dbw.Read(key3, res) == false);
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(dbwrapper_iterator)
|
|
{
|
|
// Perform tests both obfuscated and non-obfuscated.
|
|
for (const bool obfuscate : {false, true}) {
|
|
fs::path ph = m_args.GetDataDirBase() / (obfuscate ? "dbwrapper_iterator_obfuscate_true" : "dbwrapper_iterator_obfuscate_false");
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB, .memory_only = true, .wipe_data = false, .obfuscate = obfuscate});
|
|
|
|
// The two keys are intentionally chosen for ordering
|
|
uint8_t key{'j'};
|
|
uint256 in = m_rng.rand256();
|
|
dbw.Write(key, in);
|
|
uint8_t key2{'k'};
|
|
uint256 in2 = m_rng.rand256();
|
|
dbw.Write(key2, in2);
|
|
|
|
std::unique_ptr<CDBIterator> it(dbw.NewIterator());
|
|
|
|
// Be sure to seek past the obfuscation key (if it exists)
|
|
it->Seek(key);
|
|
|
|
// A failed key decode must not consume the current iterator entry.
|
|
uint16_t key_too_large{0};
|
|
BOOST_CHECK(!it->GetKey(key_too_large));
|
|
|
|
uint8_t key_res;
|
|
uint256 val_res;
|
|
|
|
BOOST_REQUIRE(it->GetKey(key_res));
|
|
BOOST_REQUIRE(it->GetValue(val_res));
|
|
BOOST_CHECK_EQUAL(key_res, key);
|
|
BOOST_CHECK_EQUAL(val_res.ToString(), in.ToString());
|
|
|
|
it->Next();
|
|
|
|
BOOST_REQUIRE(it->GetKey(key_res));
|
|
BOOST_REQUIRE(it->GetValue(val_res));
|
|
BOOST_CHECK_EQUAL(key_res, key2);
|
|
BOOST_CHECK_EQUAL(val_res.ToString(), in2.ToString());
|
|
|
|
it->Next();
|
|
BOOST_CHECK_EQUAL(it->Valid(), false);
|
|
}
|
|
}
|
|
|
|
// Test that we do not obfuscation if there is existing data.
|
|
BOOST_AUTO_TEST_CASE(existing_data_no_obfuscate)
|
|
{
|
|
// We're going to share this fs::path between two wrappers
|
|
fs::path ph = m_args.GetDataDirBase() / "existing_data_no_obfuscate";
|
|
fs::create_directories(ph);
|
|
|
|
// Set up a non-obfuscated wrapper to write some initial data.
|
|
std::unique_ptr<CDBWrapper> dbw = std::make_unique<CDBWrapper>(DBParams{.path = ph, .cache_bytes = 1 << 10, .memory_only = false, .wipe_data = false, .obfuscate = false});
|
|
uint8_t key{'k'};
|
|
uint256 in = m_rng.rand256();
|
|
uint256 res;
|
|
|
|
dbw->Write(key, in);
|
|
BOOST_CHECK(dbw->Read(key, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in.ToString());
|
|
|
|
// Call the destructor to free leveldb LOCK
|
|
dbw.reset();
|
|
|
|
// Now, set up another wrapper that wants to obfuscate the same directory
|
|
CDBWrapper odbw({.path = ph, .cache_bytes = 1 << 10, .memory_only = false, .wipe_data = false, .obfuscate = true});
|
|
|
|
// Check that the key/val we wrote with unobfuscated wrapper exists and
|
|
// is readable.
|
|
uint256 res2;
|
|
BOOST_CHECK(odbw.Read(key, res2));
|
|
BOOST_CHECK_EQUAL(res2.ToString(), in.ToString());
|
|
|
|
BOOST_CHECK(!odbw.IsEmpty());
|
|
BOOST_CHECK(!dbwrapper_private::GetObfuscation(odbw)); // The key should be an empty string
|
|
|
|
uint256 in2 = m_rng.rand256();
|
|
uint256 res3;
|
|
|
|
// Check that we can write successfully
|
|
odbw.Write(key, in2);
|
|
BOOST_CHECK(odbw.Read(key, res3));
|
|
BOOST_CHECK_EQUAL(res3.ToString(), in2.ToString());
|
|
}
|
|
|
|
// Ensure that we start obfuscating during a reindex.
|
|
BOOST_AUTO_TEST_CASE(existing_data_reindex)
|
|
{
|
|
// We're going to share this fs::path between two wrappers
|
|
fs::path ph = m_args.GetDataDirBase() / "existing_data_reindex";
|
|
fs::create_directories(ph);
|
|
|
|
// Set up a non-obfuscated wrapper to write some initial data.
|
|
std::unique_ptr<CDBWrapper> dbw = std::make_unique<CDBWrapper>(DBParams{.path = ph, .cache_bytes = 1 << 10, .memory_only = false, .wipe_data = false, .obfuscate = false});
|
|
uint8_t key{'k'};
|
|
uint256 in = m_rng.rand256();
|
|
uint256 res;
|
|
|
|
dbw->Write(key, in);
|
|
BOOST_CHECK(dbw->Read(key, res));
|
|
BOOST_CHECK_EQUAL(res.ToString(), in.ToString());
|
|
|
|
// Call the destructor to free leveldb LOCK
|
|
dbw.reset();
|
|
|
|
// Simulate a -reindex by wiping the existing data store
|
|
CDBWrapper odbw({.path = ph, .cache_bytes = 1 << 10, .memory_only = false, .wipe_data = true, .obfuscate = true});
|
|
|
|
// Check that the key/val we wrote with unobfuscated wrapper doesn't exist
|
|
uint256 res2;
|
|
BOOST_CHECK(!odbw.Read(key, res2));
|
|
BOOST_CHECK(dbwrapper_private::GetObfuscation(odbw));
|
|
|
|
uint256 in2 = m_rng.rand256();
|
|
uint256 res3;
|
|
|
|
// Check that we can write successfully
|
|
odbw.Write(key, in2);
|
|
BOOST_CHECK(odbw.Read(key, res3));
|
|
BOOST_CHECK_EQUAL(res3.ToString(), in2.ToString());
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(iterator_ordering)
|
|
{
|
|
fs::path ph = m_args.GetDataDirBase() / "iterator_ordering";
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB, .memory_only = true, .wipe_data = false, .obfuscate = false});
|
|
for (int x=0x00; x<256; ++x) {
|
|
uint8_t key = x;
|
|
uint32_t value = x*x;
|
|
if (!(x & 1)) dbw.Write(key, value);
|
|
}
|
|
|
|
// Check that creating an iterator creates a snapshot
|
|
std::unique_ptr<CDBIterator> it(const_cast<CDBWrapper&>(dbw).NewIterator());
|
|
|
|
for (unsigned int x=0x00; x<256; ++x) {
|
|
uint8_t key = x;
|
|
uint32_t value = x*x;
|
|
if (x & 1) dbw.Write(key, value);
|
|
}
|
|
|
|
for (const int seek_start : {0x00, 0x80}) {
|
|
it->Seek((uint8_t)seek_start);
|
|
for (unsigned int x=seek_start; x<255; ++x) {
|
|
uint8_t key;
|
|
uint32_t value;
|
|
BOOST_CHECK(it->Valid());
|
|
if (!it->Valid()) // Avoid spurious errors about invalid iterator's key and value in case of failure
|
|
break;
|
|
BOOST_CHECK(it->GetKey(key));
|
|
if (x & 1) {
|
|
BOOST_CHECK_EQUAL(key, x + 1);
|
|
continue;
|
|
}
|
|
BOOST_CHECK(it->GetValue(value));
|
|
BOOST_CHECK_EQUAL(key, x);
|
|
BOOST_CHECK_EQUAL(value, x*x);
|
|
it->Next();
|
|
}
|
|
BOOST_CHECK(!it->Valid());
|
|
}
|
|
}
|
|
|
|
struct StringContentsSerializer {
|
|
// Used to make two serialized objects the same while letting them have different lengths
|
|
// This is a terrible idea
|
|
std::string str;
|
|
StringContentsSerializer() = default;
|
|
explicit StringContentsSerializer(const std::string& inp) : str(inp) {}
|
|
|
|
template<typename Stream>
|
|
void Serialize(Stream& s) const
|
|
{
|
|
for (size_t i = 0; i < str.size(); i++) {
|
|
s << uint8_t(str[i]);
|
|
}
|
|
}
|
|
|
|
template<typename Stream>
|
|
void Unserialize(Stream& s)
|
|
{
|
|
str.clear();
|
|
uint8_t c{0};
|
|
while (!s.empty()) {
|
|
s >> c;
|
|
str.push_back(c);
|
|
}
|
|
}
|
|
};
|
|
|
|
BOOST_AUTO_TEST_CASE(iterator_string_ordering)
|
|
{
|
|
fs::path ph = m_args.GetDataDirBase() / "iterator_string_ordering";
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB, .memory_only = true, .wipe_data = false, .obfuscate = false});
|
|
for (int x = 0; x < 10; ++x) {
|
|
for (int y = 0; y < 10; ++y) {
|
|
std::string key{ToString(x)};
|
|
for (int z = 0; z < y; ++z)
|
|
key += key;
|
|
uint32_t value = x*x;
|
|
dbw.Write(StringContentsSerializer{key}, value);
|
|
}
|
|
}
|
|
|
|
std::unique_ptr<CDBIterator> it(const_cast<CDBWrapper&>(dbw).NewIterator());
|
|
for (const int seek_start : {0, 5}) {
|
|
it->Seek(StringContentsSerializer{ToString(seek_start)});
|
|
for (unsigned int x = seek_start; x < 10; ++x) {
|
|
for (int y = 0; y < 10; ++y) {
|
|
std::string exp_key{ToString(x)};
|
|
for (int z = 0; z < y; ++z)
|
|
exp_key += exp_key;
|
|
StringContentsSerializer key;
|
|
uint32_t value;
|
|
BOOST_CHECK(it->Valid());
|
|
if (!it->Valid()) // Avoid spurious errors about invalid iterator's key and value in case of failure
|
|
break;
|
|
BOOST_CHECK(it->GetKey(key));
|
|
BOOST_CHECK(it->GetValue(value));
|
|
BOOST_CHECK_EQUAL(key.str, exp_key);
|
|
BOOST_CHECK_EQUAL(value, x*x);
|
|
it->Next();
|
|
}
|
|
}
|
|
BOOST_CHECK(!it->Valid());
|
|
}
|
|
}
|
|
|
|
BOOST_AUTO_TEST_CASE(unicodepath)
|
|
{
|
|
// Attempt to create a database with a UTF8 character in the path.
|
|
// On Windows this test will fail if the directory is created using
|
|
// the ANSI CreateDirectoryA call and the code page isn't UTF8.
|
|
// It will succeed if created with CreateDirectoryW.
|
|
fs::path ph = m_args.GetDataDirBase() / "test_runner_₿_🏃_20191128_104644";
|
|
CDBWrapper dbw({.path = ph, .cache_bytes = 1_MiB});
|
|
|
|
fs::path lockPath = ph / "LOCK";
|
|
BOOST_CHECK(fs::exists(lockPath));
|
|
}
|
|
|
|
|
|
BOOST_AUTO_TEST_SUITE_END()
|