fanquake 54646167db Merge #18388: Make VerifyWitnessProgram use a Span stack ...

2b0fcff7f2 Make VerifyWitnessProgram use a Span stack (Pieter Wuille)

Pull request description:

  Here is a follow-up to #18002, again with the goal of simplifying (potential) BIP341 code.

  Instead of passing a begin and end iterator of the initial stack to `ExecuteWitnessScript`, they are turned into a `Span<const valtype>`, representing a span of `valtype`s in memory. This allows `VerifyWitnessProgram` to operate on that span directly, instead of juggling iterators around (which would be exacerbated by #17977 if trying to avoid copying the stack).

ACKs for top commit:
  ajtowns:
    ACK 2b0fcff7f2
  elichai:
    ReACK on the diff 2b0fcff7f2
  instagibbs:
    re-ACK 2b0fcff7f2
  theStack:
    re-ACK 2b0fcff7f2
  Empact:
    ACK 2b0fcff7f2
  jnewbery:
    utACK 2b0fcff7f2

Tree-SHA512: 38eb4ce17f1947674c1c274caa40feb6ea8266bd96134d9cf1bc41e6fbf1114d4dde6c7a9e26e1ca8f3d0155429ef0911cc8ec0c1037d8fe7d6ec7f9e7184e93

2020-03-27 14:49:50 +08:00

..

bitcoinconsensus.cpp

Drop unused GetType() from CSizeComputer

2018-09-11 00:58:05 -04:00

bitcoinconsensus.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

descriptor.cpp

Cache parent xpub inside of BIP32PubkeyProvider

2020-03-07 10:13:47 -05:00

descriptor.h

Add DescriptorCache* read_cache and DescriptorCache* write_cache to Expand and GetPubKey

2020-03-07 10:13:47 -05:00

interpreter.cpp

Make VerifyWitnessProgram use a Span stack

2020-03-23 14:44:58 -07:00

interpreter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

keyorigin.h

Remove unused includes

2019-10-15 22:56:43 +00:00

script_error.cpp

script: fix SCRIPT_ERR_SIG_PUSHONLY error string

2020-03-23 17:33:48 +01:00

script_error.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

script.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

script.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

sigcache.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

sigcache.h

Update copyright headers to 2018

2018-07-27 07:15:02 -04:00

sign.cpp

Clear any input_errors for an input after it is signed

2020-03-09 11:16:20 -04:00

sign.h

Refactor rawtransaction's SignTransaction into generic SignTransaction function

2020-03-08 12:26:27 -04:00

signingprovider.cpp

Move WatchOnly stuff from SigningProvider to CWallet

2019-07-09 16:20:18 -04:00

signingprovider.h

wallet: Improve LegacyScriptPubKeyMan::CanProvide script recognition

2020-02-12 11:48:30 -05:00

standard.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

standard.h

Merge #17924: Bug: IsUsedDestination shouldn't use key id as script id for ScriptHash

2020-01-16 19:23:33 +01:00