highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-25 08:01:02 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 54e31742d2
Merge bitcoin/bitcoin#22455: addrman: detect on-disk corrupted nNew and nTried during unserialization 
816f29eab296ebec2da8f8606ad618609e3ba228 addrman: detect on-disk corrupted nNew and nTried during unserialization (Vasil Dimov)

Pull request description:

  Negative `nNew` or `nTried` are not possible during normal operation.
  So, if we read such values during unserialize, report addrman
  corruption.

  Fixes https://github.com/bitcoin/bitcoin/issues/22450

ACKs for top commit:
  MarcoFalke:
    cr ACK 816f29eab296ebec2da8f8606ad618609e3ba228
  jonatack:
    ACK 816f29eab296ebec2da8f8606ad618609e3ba228
  lsilva01:
    Code Review ACK 816f29eab2.  This change provides a more accurate description of the error.

Tree-SHA512: 01bdd72d2d86a0ef770a319fee995fd1e147b24a8db84ddb8cd121688e7f94fed73fddc0084758e7183c4f8d08e971f0b1b224f5adb10928a5aa4dbbc8709d74
2021-07-19 14:25:53 +02:00
..
bench
bench: fix 32-bit narrowing warning in bench/peer_eviction.cpp
2021-07-15 23:05:10 +02:00
compat
Remove support for double serialization
2021-05-24 16:15:05 -07:00
config
…
consensus
doc: Move buried deployment doc to the enum that enumerates them
2021-07-01 20:04:07 +02:00
crc32c
…
crypto
…
index
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
init
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
interfaces
refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage
2021-06-16 10:48:58 +02:00
ipc
…
leveldb
…
logging
…
node
[refactor] Add versionbits deployments to deploymentstatus.h
2021-06-30 08:18:58 +10:00
policy
MOVEONLY: context-free package policies
2021-06-02 17:26:44 +01:00
primitives
…
qt
Merge bitcoin/bitcoin#21430: build: Add -Werror=implicit-fallthrough compile flag
2021-07-18 11:06:10 +08:00
rpc
Merge bitcoin/bitcoin#22387: Rate limit the processing of rumoured addresses
2021-07-19 12:42:07 +02:00
script
Make IsSegWitOutput return true for taproot outputs
2021-07-15 17:08:52 -07:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#22445: fuzz: Move implementations of non-template fuzz helpers from util.h to util.cpp
2021-07-18 09:46:06 +02:00
univalue
…
util
build: Fix Boost Process compatibility with mingw-w64 compiler
2021-07-01 12:16:47 +03:00
wallet
Change ScriptPubKeyMan::Upgrade to default to return true
2021-07-15 12:33:16 -04:00
zmq
zmq: use msg: prefix over errno= in zmqError
2021-06-09 19:25:13 +08:00
.clang-format
…
addrdb.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrdb.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrman.cpp
addrman: reset I2P ports to 0 when loading from disk
2021-07-09 11:19:38 +02:00
addrman.h
addrman: detect on-disk corrupted nNew and nTried during unserialization
2021-07-15 13:40:29 +02:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
banman.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli: Avoid truncating -rpcwaittimeout
2021-06-23 14:40:55 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: Pass grind args vector as const reference
2021-06-18 20:10:07 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Remove unused OptionsCategory arg from AddCommand
2021-06-18 20:09:23 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
doc: Various validation doc fixups
2021-06-03 13:53:31 +02:00
chainparams.cpp
[move-only] Rename versionbitsinfo to deploymentinfo
2021-06-30 08:19:12 +10:00
chainparams.h
net: distinguish default port per network
2021-07-09 11:19:36 +02:00
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
net: change I2P seeds' ports to 0
2021-07-09 11:19:35 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentinfo.h
deploymentinfo: Add DeploymentName()
2021-06-30 08:19:12 +10:00
deploymentstatus.cpp
scripted-diff: rename versionbitscache
2021-06-30 08:19:12 +10:00
deploymentstatus.h
Use DeploymentEnabled to hide VB deployments
2021-07-01 20:20:52 +02:00
dummywallet.cpp
…
external_signer.cpp
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
refactor: Make httpserver work queue a unique_ptr
2021-06-28 11:47:05 +02:00
httpserver.h
…
i2p.cpp
net: do not connect to I2P hosts on port!=0
2021-07-09 11:19:37 +02:00
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#22415: Make m_mempool optional in CChainState
2021-07-15 13:40:03 +02:00
init.h
init: remove straggling boost thread_group code
2021-07-12 21:46:59 +08:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
…
key.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
key.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
logging.cpp
…
logging.h
…
Makefile.am
Merge bitcoin/bitcoin#22234: build: Mark print-% target as phony.
2021-07-18 13:41:24 +08:00
Makefile.bench.include
bench: add peer eviction protection benchmarks
2021-07-08 12:28:23 +02:00
Makefile.crc32c.include
…
Makefile.leveldb.include
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
Makefile.qt_locale.include
…
Makefile.qt.include
Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always deterministic
2021-06-03 21:25:30 +08:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
fuzz: fix fuzz binary linking order
2021-06-16 10:41:24 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
p2p: pass strings to NetPermissions::TryParse functions by const ref
2021-05-19 19:41:05 +02:00
net_permissions.h
Rate limit the processing of incoming addr messages
2021-07-15 12:52:38 -07:00
net_processing.cpp
Add logging and addr rate limiting statistics
2021-07-15 13:03:20 -07:00
net_processing.h
Add logging and addr rate limiting statistics
2021-07-15 13:03:20 -07:00
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#22284: p2p, refactor: performance improvements to ProtectEvictionCandidatesByRatio()
2021-07-15 14:49:45 +02:00
net.h
Merge bitcoin/bitcoin#20234: net: don't bind on 0.0.0.0 if binds are restricted to Tor
2021-07-12 10:08:22 +02:00
netaddress.cpp
Merge bitcoin/bitcoin#22179: Torv2 removal followups
2021-07-08 17:20:35 +02:00
netaddress.h
Merge bitcoin/bitcoin#22211: net: relay I2P addresses even if not reachable (by us)
2021-07-15 16:53:34 +02:00
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
Disallow bech32m addresses for legacy wallet things
2021-06-22 21:57:04 -04:00
outputtype.h
Disallow bech32m addresses for legacy wallet things
2021-06-22 21:57:04 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Replace memset calls with array initialization
2021-05-13 12:42:21 +01:00
protocol.h
Add roundtrip fuzz tests for CAddress serialization
2021-05-24 18:06:35 -07:00
psbt.cpp
Make GetInputUTXO safer: verify non-witness UTXO match
2021-06-12 12:25:28 -07:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
pubkey.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
reverse_iterator.h
…
scheduler.cpp
test: Fix off-by-one in mockscheduler test RPC
2021-05-14 12:49:16 +02:00
scheduler.h
…
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
…
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.h
…
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
Use C++17 [[fallthrough]] attribute, and drop -Wno-implicit-fallthrough
2021-07-05 08:59:38 +03:00
torcontrol.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
torcontrol.h
…
txdb.cpp
doc: add comment about CCoinsViewDBCursor constructor
2021-06-18 14:15:39 -04:00
txdb.h
move-only(ish): don't expose CCoinsViewDBCursor
2021-06-18 14:14:15 -04:00
txmempool.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
txmempool.h
[refactor] comment/naming improvements
2021-06-02 09:40:40 +01:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#22415: Make m_mempool optional in CChainState
2021-07-15 13:40:03 +02:00
validation.h
refactor: move UpdateTip into CChainState
2021-07-13 11:16:37 -04:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
versionbits.h
[refactor] Move ComputeBlockVersion into VersionBitsCache
2021-06-30 08:19:12 +10:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…