MarcoFalke a924f61cae Merge #19325: wallet: Refactor BerkeleyDatabase to introduce DatabaseBatch abstract class ...

b82f0ca4d5 walletdb: Add MakeBatch function to BerkeleyDatabase and use it (Andrew Chow)
eac9200814 walletdb: Refactor DatabaseBatch abstract class from BerkeleyBatch (Andrew Chow)

Pull request description:

  In order to support alternative database systems, we need to have a generic `Batch` class. This PR adds a `DatabaseBatch` abstract class which is implemented by `BerkeleyBatch`. `DatabaseBatch` is now the class that is used by `WalletBatch` to interact with the database. To be able to get the correct type of `DatabaseBatch`, `BerkeleyDatabase` now has a `MakeBatch` function which returns a newly constructed `std::unique_ptr<DatabaseBatch>`. For `BerkeleyDatabase`, that will be `std::unique_ptr<BerkeleyBatch>`.

  The `Read`, `Write`, `Erase`, and `Exists` template functions are moved from `BerkeleyBatch`.

  Part of #18971

  Requires #19308 and #19324

ACKs for top commit:
  Sjors:
    re-utACK b82f0ca4d5
  MarcoFalke:
    ACK b82f0ca4d5 🌘
  meshcollider:
    LGTM, utACK b82f0ca4d5

Tree-SHA512: 6d2d41631c0983391dbecd702e881c6775b155c90b275df97f7157e42608ed251744f9d7ce5173d02a6c5cc38d90b611880fac7fa635d3d8c4d590681f56ac6a

2020-07-14 16:21:01 +02:00

..

test

wallet: Fix clang build in Mac

2020-07-11 19:33:57 +03:00

bdb.cpp

Merge #19325: wallet: Refactor BerkeleyDatabase to introduce DatabaseBatch abstract class

2020-07-14 16:21:01 +02:00

bdb.h

Merge #19325: wallet: Refactor BerkeleyDatabase to introduce DatabaseBatch abstract class

2020-07-14 16:21:01 +02:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

walletdb: Move BDB specific things into bdb.{cpp/h}

2020-06-15 20:41:05 -04:00

db.h

walletdb: Refactor DatabaseBatch abstract class from BerkeleyBatch

2020-07-09 11:43:52 -04:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

ismine.h

…

load.cpp

wallet: Never schedule MaybeCompactWalletDB when -flushwallet is off

2020-07-09 13:07:41 +02:00

load.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

rpcdump.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

rpcwallet.cpp

Merge #18202: refactor: consolidate sendmany and sendtoaddress code

2020-07-12 14:42:35 +12:00

rpcwallet.h

refactor: Combine GetWalletForJSONRPCRequest and EnsureWalletIsAvailable functions

2020-06-05 08:29:18 -04:00

salvage.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

salvage.h

Move RecoverKeysOnlyFilter into RecoverDataBaseFile

2020-05-25 12:59:29 -04:00

scriptpubkeyman.cpp

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

scriptpubkeyman.h

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

wallet.cpp

wallet: Fix typo in comments; Simplify assert

2020-07-11 14:24:36 +02:00

wallet.h

Merge #19046: Replace CWallet::Set* functions that use memonly with Add/Load variants

2020-07-11 23:08:54 +12:00

walletdb.cpp

Merge #19325: wallet: Refactor BerkeleyDatabase to introduce DatabaseBatch abstract class

2020-07-14 16:21:01 +02:00

walletdb.h

walletdb: Add MakeBatch function to BerkeleyDatabase and use it

2020-07-09 11:43:54 -04:00

wallettool.cpp

walletdb: Combine VerifyDatabaseFile and VerifyEnvironment

2020-07-01 12:32:03 -04:00

wallettool.h

…

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00