highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-26 17:19:29 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
557d3f1cc065702ebbf929d39ac7c5561111ce4c
bitcoin/src
History
MarcoFalke d52bfc4916 Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal overlay is shown 
d0cc1f6df7 qt: Disable toolbar when overlay is shown (Hennadii Stepanov)
e74cd2083d qt, refactor: Cleanup ModalOverlay slots (Hennadii Stepanov)

Pull request description:

  Keeping the main window toolbar activated while the modal overlay is shown could create the appearance of the non-responsive GUI.

  Fixes #22.

  ---

  On master (ca055885c6):

  ![Screenshot from 2020-07-11 13-07-00](https://user-images.githubusercontent.com/32963518/87221791-7504e100-c377-11ea-9689-ddd4b21b98f9.png)

  With this PR:

  ![Screenshot from 2020-07-11 13-07-39](https://user-images.githubusercontent.com/32963518/87221803-8817b100-c377-11ea-92c8-3602dc4d2451.png)

ACKs for top commit:
  harding:
    Tested ACK d0cc1f6df7.  Tested on Linux/X11 as much as I could given it's a pretty small change; seems like a nice improvement.  I'm not experienced in Qt, but I don't see anything obviously problematic about the code.
  jonatack:
    ACK d0cc1f6 tested on Debian 5.7.6-1 (2020-06-24) x86_64 GNU/Linux
  LarryRuane:
    ACK d0cc1f6df7 tested on Ubuntu 18.04.4 LTS

Tree-SHA512: e371b34231c01e77118deb100e0f280ba1cdef54e317f7f7d6ac322598bda811bd1bfe3035e90d87f8267f4f5d2095d34a8136911159db63694fd1b1b11335a1
2020-07-13 10:34:27 +02:00
..
bench
…
compat
…
config
…
consensus
…
crc32c
…
crypto
…
index
…
interfaces
…
leveldb
…
logging
…
node
…
policy
…
primitives
…
qt
Merge bitcoin-core/gui#30: Disable the main window toolbar when the modal overlay is shown
2020-07-13 10:34:27 +02:00
rpc
…
script
…
secp256k1
…
support
…
test
…
univalue
…
util
…
wallet
…
zmq
…
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
…
addrman.h
…
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
indirectmap.h
…
init.cpp
…
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
limitedmap.h
…
logging.cpp
…
logging.h
…
Makefile.am
…
Makefile.bench.include
…
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
…
miner.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
…
net_processing.h
…
net_types.h
…
net.cpp
…
net.h
…
netaddress.cpp
…
netaddress.h
…
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
optional.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
…
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
…
txmempool.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
…
validation.h
…
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…