Andrew Chow 498994b6f5 Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2) ...

5b3ea5fa2e refactor: Move `{MAX,DEFAULT}_SCRIPTCHECK_THREADS` constants (Hennadii Stepanov)
6e17b31680 refactor: Make `CCheckQueue` non-copyable and non-movable explicitly (Hennadii Stepanov)
8111e74653 refactor: Drop unneeded declaration (Hennadii Stepanov)
9cf89f7a5b refactor: Make `CCheckQueue` constructor start worker threads (Hennadii Stepanov)
d03eaacbcf Make `CCheckQueue` destructor stop worker threads (Hennadii Stepanov)
be4ff3060b Move global `scriptcheckqueue` into `ChainstateManager` class (Hennadii Stepanov)

Pull request description:

  This PR:
  - makes `CCheckQueue` RAII-styled
  - gets rid of the global `scriptcheckqueue`
  - fixes https://github.com/bitcoin/bitcoin/issues/25448

  The previous attempt was in https://github.com/bitcoin/bitcoin/pull/18731.

ACKs for top commit:
  martinus:
    ACK 5b3ea5fa2e
  achow101:
    ACK 5b3ea5fa2e
  TheCharlatan:
    ACK 5b3ea5fa2e

Tree-SHA512: 45cca846e7ed107e3930149f0b616ddbaf2648d6cde381f815331b861b5d67ab39e154883ae174b8abb1dae485bc904318c50c51e5d6b46923d89de51c5eadb0

2023-11-30 14:28:46 -05:00

..

data

Add deserialize + CheckBlock benchmarks, and a full block hex

2016-11-09 11:27:59 -08:00

.gitignore

Ignore bench_bitcoin binary.

2015-10-06 17:46:12 +02:00

addrman.cpp

p2p, refactor: return std::optional<CNetAddr> in LookupHost

2023-05-26 13:41:07 -03:00

base58.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bech32.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

bench_bitcoin.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

bench.cpp

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

bench.h

Extract util::Xor, Add key_offset option, Add bench

2023-07-12 09:59:55 +02:00

bip324_ecdh.cpp

Bench test for EllSwift ECDH

2023-06-23 14:24:32 -04:00

block_assemble.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

ccoins_caching.cpp

Merge bitcoin/bitcoin#26691: Update secp256k1 subtree to libsecp256k1 version 0.2.0

2023-01-13 09:40:57 +00:00

chacha20.cpp

crypto: refactor ChaCha20 classes to use Span<std::byte> interface

2023-08-17 15:26:34 -04:00

checkblock.cpp

Convert some CDataStream to DataStream

2023-11-16 11:14:13 +10:00

checkqueue.cpp

refactor: Make CCheckQueue constructor start worker threads

2023-10-03 10:52:15 +01:00

coin_selection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

crypto_hash.cpp

bench: Add SHA256 implementation specific benchmarks

2023-09-20 21:12:00 +01:00

data.cpp

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

data.h

bench: Move generated data to a dedicated translation unit

2019-07-02 18:11:15 +01:00

descriptors.cpp

Move CTxDestination to its own file

2023-08-14 17:38:27 -04:00

disconnected_transactions.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

duplicate_inputs.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

ellswift.cpp

refactor: Drop unsafe AsBytePtr function

2023-06-28 15:14:45 -04:00

examples.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

gcs_filter.cpp

Fix clang-tidy readability-const-return-type violations

2023-02-01 11:33:35 +01:00

hashpadding.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

load_external.cpp

refactor: switch from CAutoFile to AutoFile

2023-11-18 03:01:41 +10:00

lockedpool.cpp

clang-tidy: Add performance-inefficient-vector-operation check

2023-03-26 20:17:55 +01:00

logging.cpp

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

mempool_eviction.cpp

mempool_entry: add mempool entry sequence number

2023-08-03 13:42:45 +10:00

mempool_stress.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

merkle_root.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

nanobench.cpp

Replace current benchmarking framework with nanobench

2020-06-13 12:24:18 +02:00

nanobench.h

bench: Update nanobench to 4.3.11

2023-11-14 20:22:12 +01:00

peer_eviction.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

poly1305.cpp

Switch all callers from poly1305_auth to Poly1305 class

2023-07-12 22:43:55 -04:00

pool.cpp

pool: make sure PoolAllocator uses the correct alignment

2023-11-19 18:43:29 +01:00

prevector.cpp

bench: Add benchmark for prevector usage in std::vector

2023-03-26 15:49:41 +02:00

rollingbloom.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

rpc_blockchain.cpp

Remove unused CDataStream

2023-11-30 11:27:54 +01:00

rpc_mempool.cpp

mempool_entry: add mempool entry sequence number

2023-08-03 13:42:45 +10:00

streams_findbyte.cpp

refactor: switch from CAutoFile to AutoFile

2023-11-18 03:01:41 +10:00

strencodings.cpp

bench: explicitly make all current benchmarks "high" priority

2022-10-20 10:21:04 -03:00

util_time.cpp

refactor: Remove unused GetTimeMillis

2023-05-08 12:40:48 +02:00

verify_script.cpp

Convert some CDataStream to DataStream

2023-11-16 11:14:13 +10:00

wallet_balance.cpp

Merge bitcoin/bitcoin#27666: wallet, bench: Move commonly used functions to their own file and fix a bug

2023-05-30 16:20:47 +01:00

wallet_create_tx.cpp

bugfix: Mark CNoDestination and PubKeyDestination constructor explicit

2023-10-25 22:46:55 +02:00

wallet_loading.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

xor.cpp

Extract util::Xor, Add key_offset option, Add bench

2023-07-12 09:59:55 +02:00