highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-23 22:19:39 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
5a5ab1d5446693ee2655860c2f2920bcc3389c83
bitcoin/src
History
Ryan Ofsky 5a5ab1d544 Merge bitcoin/bitcoin#29776: ThreadSanitizer: Fix #29767 
bbe82c116e Fix #29767, set m_synced = true after Commit() (nanlour)

Pull request description:

  I think this problem https://github.com/bitcoin/bitcoin/issues/29767#issue-2216373048 is because of
  in BaseIndex::Sync
  61de64df67/src/index/base.cpp (L163-L168)
  Setup m_synced = true; before Commit();
  So this may cause a race condition window to BaseIndex::BlockConnected
  61de64df67/src/index/base.cpp (L271-L274)
  So i try to fix it with move m_synced = true after Commit().
  Also see comment of Sync():
  61de64df67/src/index/base.h (L151-L156)
  I am a newcomer interested in Bitcoin, trying to become a member of the Bitcoin Core development team. Please give me some feedback if you could, as I may be doing something wrong. Thank you!

ACKs for top commit:
  fjahr:
    Code review ACK bbe82c116e
  ryanofsky:
    Code review ACK bbe82c116e

Tree-SHA512: 89a09498a232c87ef1e083d4cc4ed9bb15f045ad0624d5d150a87187b2b8a48a41137974dbc7ea5c37f73da90742c43259f5aa7f84b4179eb8d62033e44fa479
2024-04-04 09:25:16 -04:00
..
bench
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
common
Merge bitcoin/bitcoin#29007: test: create deterministic addrman in the functional tests
2024-03-11 10:29:31 -04:00
compat
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
config
…
consensus
…
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
Merge bitcoin/bitcoin#29263: serialization: c++20 endian/byteswap/clz modernization
2024-03-01 11:19:58 -05:00
index
Fix #29767, set m_synced = true after Commit()
2024-04-01 14:13:06 +11:00
init
…
interfaces
…
ipc
…
kernel
Merge bitcoin/bitcoin#29402: mempool: Log added for dumping mempool transactions to disk
2024-03-28 11:43:10 +00:00
leveldb
…
logging
…
minisketch
…
node
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
policy
ImprovesFeerateDiagram: Spelling fix and removal of unused diagram vectors
2024-03-26 08:05:22 -04:00
primitives
[validation] Cache merkle root and witness commitment checks
2024-02-27 14:19:15 +00:00
qt
Merge bitcoin/bitcoin#27375: net: support unix domain sockets for -proxy and -onion
2024-03-13 06:53:07 -04:00
rpc
Merge bitcoin/bitcoin#29130: wallet: Add createwalletdescriptor and gethdkeys RPCs for adding new automatically generated descriptors
2024-03-29 06:39:57 -04:00
script
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
univalue
…
util
CompareFeerateDiagram: short-circuit comparison when detected as incomparable
2024-03-26 08:41:06 -04:00
wallet
Merge bitcoin/bitcoin#29130: wallet: Add createwalletdescriptor and gethdkeys RPCs for adding new automatically generated descriptors
2024-03-29 06:39:57 -04:00
zmq
zmq: read raw block with ReadRawBlockFromDisk
2024-03-12 12:46:46 -04:00
.bear-tidy-config
…
.clang-format
…
.clang-tidy
ci: Bump TIDY_LLVM_V
2024-03-15 13:34:05 +00:00
addrdb.cpp
addrman: drop /*deterministic=*/ comment
2024-03-23 15:33:47 +01:00
addrdb.h
…
addresstype.cpp
…
addresstype.h
…
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
node: Make translations of fatal errors consistent
2024-03-21 16:40:22 +01:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli: improve bitcoin-cli error when not connected
2024-03-21 10:29:43 +00:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
assumeutxo: Remove BLOCK_ASSUMED_VALID flag
2024-03-18 11:28:40 -05:00
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
seeds: Update testnet seeds
2024-03-04 19:53:30 -05:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
doc: fix some typos
2024-03-26 16:51:46 +00:00
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
scripted-diff: Replace error() with LogError()
2024-03-11 13:49:37 +01:00
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
i2p.cpp
Merge bitcoin/bitcoin#27375: net: support unix domain sockets for -proxy and -onion
2024-03-13 06:53:07 -04:00
i2p.h
i2p: construct Session with Proxy instead of CService
2024-03-01 14:47:29 -05:00
indirectmap.h
…
init.cpp
init: clarify -test error
2024-03-23 15:33:50 +01:00
init.h
…
key_io.cpp
…
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
…
logging.h
Merge bitcoin/bitcoin#29419: log: deduplicate category names and improve logging.cpp
2024-04-02 10:47:05 -04:00
Makefile.am
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
Makefile.bench.include
bench: basic block filter index initial sync
2024-03-12 09:30:42 -03:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: 27.0 translations update
2024-03-04 10:02:26 +00:00
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
Makefile.univalue.include
…
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections
2024-02-28 10:05:56 -03:00
net_permissions.h
Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections
2024-02-28 10:05:56 -03:00
net_processing.cpp
Merge bitcoin/bitcoin#29619: refactor: consolidate MempoolAcceptResult processing
2024-03-13 07:26:34 -04:00
net_processing.h
…
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#27375: net: support unix domain sockets for -proxy and -onion
2024-03-13 06:53:07 -04:00
net.h
Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections
2024-02-28 10:05:56 -03:00
netaddress.cpp
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
netaddress.h
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
netbase.cpp
netbase: remove unnecessary log message
2024-03-13 14:09:50 -04:00
netbase.h
net: split ConnectToSocket() from ConnectDirectly() for unix sockets
2024-03-01 14:47:28 -05:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
node: Use log levels in noui_ThreadSafeMessageBox
2024-03-21 16:41:16 +01:00
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
crypto: replace CountBits with std::bit_width
2024-02-26 16:13:12 +00:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
rest: read raw block in rest_block and deserialize for json
2024-03-12 12:48:04 -04:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
Merge bitcoin/bitcoin#29263: serialization: c++20 endian/byteswap/clz modernization
2024-03-01 11:19:58 -05:00
signet.cpp
…
signet.h
…
span.h
…
streams.cpp
…
streams.h
…
sync.cpp
…
sync.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
CalculateFeerateDiagramsForRBF: update misleading description of old diagram contents
2024-03-26 11:42:42 -04:00
txmempool.h
Implement ImprovesFeerateDiagram
2024-03-18 10:32:00 -04:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
doc: Fix typos
2024-03-26 16:51:37 +00:00
validation.h
Merge bitcoin/bitcoin#29648: Remove libbitcoinconsensus
2024-04-01 17:53:31 +02:00
validationinterface.cpp
…
validationinterface.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…