mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 21:52:53 +02:00
74245c20e0
The block policy estimator's FeeReason enum mixed two unrelated concerns: the threshold that produced an estimateSmartFee result (NONE, HALF_ESTIMATE, ...) and the reason the wallet selected a fee rate (FALLBACK, MEMPOOL_MIN, REQUIRED). Split them so each layer owns the reasons it reports: - Add a wallet-facing FeeReason enum with the reasons the wallet can select a fee rate: FEE_RATE_ESTIMATOR, MEMPOOL_MIN, USER_SPECIFIED, FALLBACK, and REQUIRED. - Rename the estimator enum to BlockPolicyEstimateReason and narrow it to estimator reasons: NONE, HALF_ESTIMATE, FULL_ESTIMATE, DOUBLE_ESTIMATE, and CONSERVATIVE. - Return wallet fee selection metadata through MinimumFeeRateResult instead of exposing FeeCalculation to wallet callers. The returned target is now optional and is only set for fee rate estimator results. Flatten GetMinimumFeeRate() with early returns while preserving the fee selection order: user feerate still only applies the required-fee check, while smart-fee results keep fallback, mempool-min, and required fallbacks. The returned target is cleared for fallback, mempool-min, and required results. Replace the CreateTransactionInternal log with a simpler message that does not depend on estimateSmartFee internals. Detailed estimator logging will be added in a follow-up commit.