fanquake 46494b08e2 Merge #16798: Refactor rawtransaction_util's SignTransaction to separate prevtx parsing ...

39034f1ee6 Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow)

Pull request description:

  Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information.

  This allows for `SignTransaction` to just take any `SigningProvider`.

  Split from #16341

ACKs for top commit:
  MarcoFalke:
    ACK 39034f1ee6
  instagibbs:
    utACK 39034f1ee6
  ryanofsky:
    utACK 39034f1ee6. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, https://github.com/bitcoin/bitcoin/pull/16341#pullrequestreview-278610269 other than rebase with no conflicts.

Tree-SHA512: 09f7733e90691766bfb5cf0f20e913dbf270bd3b51abdcad966b24d110e562ed85fd3d0d1d7bbea61f903340060052ec73c4817b09aee0dc1f3916d781a9e40c

2019-09-07 08:39:56 +08:00

..

test

Encapsulate tx status in a Confirmation struct

2019-08-23 14:53:20 -04:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

…

coinselection.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

ismine.cpp

…

ismine.h

…

load.cpp

…

load.h

…

psbtwallet.cpp

…

psbtwallet.h

…

rpcdump.cpp

…

rpcwallet.cpp

Merge #16798: Refactor rawtransaction_util's SignTransaction to separate prevtx parsing

2019-09-07 08:39:56 +08:00

rpcwallet.h

…

wallet.cpp

Merge #16624: wallet: encapsulate transactions state

2019-09-06 01:28:54 +12:00

wallet.h

…

walletdb.cpp

…

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…