bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-13 06:04:42 +02:00

Files

merge-script e36f5d5d0b Merge bitcoin/bitcoin#35456 : test: Perform full reset of CoinsResult in order to avoid passing 21M BTC

d0b76c7f3e rpc+bitcoin-tx: Specify correct type for ParseFixedPoint() (Hodlinator)
43ca54ca00 refactor(test): Make CAmount arg explicit for BuildCreditingTransaction() (Hodlinator)
b5e91e946c wallet: Remove CoinsResult::Clear() (Hodlinator)

Pull request description:

  The *knapsack_solver_test* in *coinselector_tests.cpp* was accumulating satoshi amounts beyond 21M BTC. This was uncovered while experimenting with adding checks to `CAmount`. Fix that by fully resetting the `CoinsResult` object accumulating those amounts, inspired by https://github.com/bitcoin/bitcoin/issues/35449#issuecomment-4613968627.

  Also, while we're at it, add 2 commits which correct some `int64_t`/`CAmount` confusion.

  Fixes https://github.com/bitcoin/bitcoin/issues/35449

ACKs for top commit:
  sedited:
    ACK d0b76c7f3e
  furszy:
    utACK d0b76c7f3e
  brunoerg:
    code review ACK d0b76c7f3e

Tree-SHA512: 6d989ded6f6327dc657f437dc256d4adf42a34a1252621421ee38d7851c6cdc97a462f033a4728e3aa7d5514deee4db6e83646105633f9cf7ed6e7e90406b67d

2026-06-08 21:59:58 +02:00

fuzz

Merge bitcoin/bitcoin#28333 : wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively

2026-05-28 21:49:59 +02:00

CMakeLists.txt

…

coinselection_tests.cpp

Merge bitcoin/bitcoin#32150 : coinselection: Optimize BnB exploration

2026-06-03 14:06:42 -07:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#35456 : test: Perform full reset of CoinsResult in order to avoid passing 21M BTC

2026-06-08 21:59:58 +02:00