mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-13 14:13:52 +02:00
4e29de719eprivate broadcast: add release note for limited cap (Gregory Sanders)cbf8c107c1Release cs_main between individual private tx re-attempts (Greg Sanders)5aea3d0373private broadcast: limit outstanding txs to count of 10,000 (Gregory Sanders) Pull request description: Add a belt-and-suspenders feature, limit the amount of memory and cpu possible when unlucky or simply misconfigured. The worst case limit is roughly 400kB * 10,000 = 4GB, regardless of usage pattern. Before this change, sheer volume of broadcasts, mismatches in standardness rules, or simply fee mismatches may result in unbounded growth of memory usage. As the feature may be expanded in the future, explicit bounds helps reasoning going forward. ACKs for top commit: frankomosh: tACK4e29de719e. Ran private_broadcast_tests and p2p_private_broadcast_cap.py. Great to have an explicit bound as the belt-and-suspenders against unbounded queue growth. vasild: ACK4e29de719eandrewtoth: ACK4e29de719estickies-v: ACK4e29de719eTree-SHA512: 18161755f37d07cca185a09e782dbe2fd0025b8befd4f6660e988865cc3a9b705d41769b816161e8142fe6ce31a56e0288bd78efc25135cedfc47fc855011799