merge-script bfce85d135 Merge bitcoin/bitcoin#30466: refactor: Make m_last_notified_header private ...

fa927055dd refactor: Make m_last_notified_header private (MarcoFalke)

Pull request description:

  Seems brittle to expose mutable fields public.

  Fix it by making it private.

  Fixes https://github.com/bitcoin/bitcoin/pull/30425#discussion_r1677633601

ACKs for top commit:
  dergoegge:
    utACK fa927055dd

Tree-SHA512: d9841c42571144ced0edeaa4bb1d96a177a011dca37c8342c66513477c37278602a1b88beb93068b94fc4443b1552c8fc9f98bcf0bda7d0fc101e61e90c33944

2024-07-17 15:53:33 +01:00

..

bench

Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)

2024-07-16 16:19:07 -04:00

common

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

compat

…

config

…

consensus

…

crc32c

…

crypto

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

index

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

init

…

interfaces

Merge bitcoin-core/gui#825: Show maximum mempool size in information window

2024-07-14 13:07:44 +01:00

ipc

…

kernel

Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default

2024-07-11 19:08:46 +01:00

leveldb

…

logging

…

minisketch

…

node

Merge bitcoin/bitcoin#30428: log: LogError with FlatFilePos in UndoReadFromDisk

2024-07-15 13:42:53 -04:00

policy

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

primitives

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

qt

Merge bitcoin-core/gui#827: OptionsDialog: Prefer to stretch actual options area rather than waste space

2024-07-15 12:15:09 +01:00

rpc

Merge bitcoin/bitcoin#30429: rpc: Use CHECK_NONFATAL over Assert

2024-07-16 16:00:33 -04:00

script

Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)

2024-07-16 16:19:07 -04:00

secp256k1

Update secp256k1 subtree to latest master

2024-06-25 15:01:00 +01:00

support

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

test

Merge bitcoin/bitcoin#28263: Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305

2024-07-16 12:13:02 +01:00

univalue

…

util

Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default

2024-07-11 19:08:46 +01:00

wallet

Merge bitcoin/bitcoin#30457: doc: getaddressinfo[isscript] is optional

2024-07-17 13:58:34 +01:00

zmq

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

.bear-tidy-config

…

.clang-format

…

.clang-tidy

Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment

2024-07-11 19:21:05 +01:00

addrdb.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

addrdb.h

…

addresstype.cpp

…

addresstype.h

…

addrman_impl.h

…

addrman.cpp

random: add RandomMixin::randbits with compile-known bits

2024-07-01 10:26:46 -04:00

addrman.h

…

arith_uint256.cpp

…

arith_uint256.h

Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment

2024-07-11 19:21:05 +01:00

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

kernel: De-globalize signature cache

2024-07-05 09:03:04 +02:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

…

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

…

bitcoin-util-res.rc

…

bitcoin-util.cpp

…

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

…

blockencodings.cpp

…

blockencodings.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

compressor.cpp

…

compressor.h

…

core_io.h

…

core_memusage.h

…

core_read.cpp

refactor: Mark some static global vars as const

2024-07-08 21:19:23 +02:00

core_write.cpp

…

cuckoocache.h

validation: Don't error if maxsigcachesize exceeds uint32::max

2024-07-04 22:35:29 +02:00

dbwrapper.cpp

…

dbwrapper.h

…

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

…

external_signer.cpp

…

external_signer.h

…

flatfile.cpp

…

flatfile.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

hash.cpp

…

hash.h

…

headerssync.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

headerssync.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

httprpc.cpp

Merge bitcoin/bitcoin#28167: init: Add option for rpccookie permissions (replace 26088)

2024-06-27 17:35:08 -04:00

httprpc.h

…

httpserver.cpp

rest: don't copy data when sending binary response

2024-06-26 06:47:30 +03:00

httpserver.h

Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default

2024-07-11 19:08:46 +01:00

i2p.cpp

Merge bitcoin/bitcoin#29833: i2p: fix and improve logs

2024-06-26 15:28:26 -04:00

i2p.h

…

indirectmap.h

…

init.cpp

Merge bitcoin/bitcoin#22729: Make it possible to disable Tor binds and abort startup on bind failure

2024-07-16 16:27:24 -04:00

init.h

…

key_io.cpp

…

key_io.h

…

key.cpp

…

key.h

…

logging.cpp

…

logging.h

…

Makefile.am

remove truc_policy.cpp from libbitcoin_common_a_SOURCES

2024-07-11 11:55:37 +01:00

Makefile.bench.include

Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)

2024-07-16 16:19:07 -04:00

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.minisketch.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

…

Makefile.test_util.include

random: move XoRoShiRo128PlusPlus into random module

2024-07-01 10:26:46 -04:00

Makefile.test.include

Add fuzz test for AEADChacha20Poly1305

2024-07-15 18:25:59 +05:30

Makefile.univalue.include

…

mapport.cpp

…

mapport.h

…

memusage.h

…

merkleblock.cpp

…

merkleblock.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

Merge bitcoin/bitcoin#30394: net: fix race condition in self-connect detection

2024-07-16 09:40:53 +01:00

net_processing.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

net_types.cpp

…

net_types.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

net.cpp

Merge bitcoin/bitcoin#22729: Make it possible to disable Tor binds and abort startup on bind failure

2024-07-16 16:27:24 -04:00

net.h

Merge bitcoin/bitcoin#30394: net: fix race condition in self-connect detection

2024-07-16 09:40:53 +01:00

netaddress.cpp

…

netaddress.h

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

netbase.cpp

…

netbase.h

…

netgroup.cpp

…

netgroup.h

…

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

protocol.cpp

…

protocol.h

…

psbt.cpp

…

psbt.h

Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default

2024-07-11 19:08:46 +01:00

pubkey.cpp

…

pubkey.h

…

random.cpp

random: replace construct/assign with explicit Reseed()

2024-07-01 12:39:57 -04:00

random.h

random: drop ad-hoc Shuffle in favor of std::shuffle

2024-07-06 09:06:36 -04:00

randomenv.cpp

util: Use SteadyClock in RandAddSeedPerfmon

2024-07-01 17:40:35 +02:00

randomenv.h

…

rest.cpp

rest: don't copy data when sending binary response

2024-06-26 06:47:30 +03:00

rest.h

…

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

signet.cpp

…

signet.h

…

span.h

…

streams.cpp

…

streams.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

sync.cpp

…

sync.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

threadsafety.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

tinyformat.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

torcontrol.cpp

…

torcontrol.h

…

txdb.cpp

…

txdb.h

…

txmempool.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

txmempool.h

…

txorphanage.cpp

…

txorphanage.h

…

txrequest.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

refactor: Make m_last_notified_header private

2024-07-17 09:12:28 +02:00

validation.h

refactor: Make m_last_notified_header private

2024-07-17 09:12:28 +02:00

validationinterface.cpp

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

validationinterface.h

…

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00