fanquake 65f5cfda65 Merge bitcoin/bitcoin#25311: refactor: remove CBlockIndex copy construction ...

36c201feb7 remove CBlockIndex copy construction (James O'Beirne)

Pull request description:

  Copy construction of CBlockIndex objects is a footgun because of the
  wide use of equality-by-pointer comparison in the code base. There are
  also potential lifetime confusions of using copied instances, since
  there are recursive pointer members (e.g. pprev).

  (See also https://github.com/bitcoin/bitcoin/pull/24008#discussion_r891949166)

  We can't just delete the copy constructors because they are used for
  derived classes (CDiskBlockIndex), so we mark them protected.

ACKs for top commit:
  ajtowns:
    ACK 36c201feb7 - code review only
  MarcoFalke:
    re-ACK 36c201feb7  🏻

Tree-SHA512: b1cf9a1cb992464a4377dad609713eea63cc099435df374e4553bfe62d362a4eb5e3c6c6649177832f38c0905b23841caf9d62196cef8e3084bfea0bfc26374b

2022-12-19 09:34:39 +00:00

..

util

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h

2022-11-30 10:37:57 +00:00

addition_overflow.cpp

util: Add SaturatingAdd helper

2022-02-21 14:32:53 +01:00

addrman.cpp

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

asmap_direct.cpp

…

asmap.cpp

[netgroupman] Add GetMappedAS() and GetGroup()

2022-04-20 14:35:52 +01:00

autofile.cpp

Use AutoFile where possible

2022-06-29 10:33:13 +02:00

banman.cpp

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

base_encode_decode.cpp

Use std::string_view throughout util strencodings/string

2022-04-27 14:13:39 +02:00

bech32.cpp

…

bitdeque.cpp

fuzz: Avoid timeout in bitdeque fuzz target

2022-09-05 15:38:33 +02:00

block_header.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

CDiskBlockIndex: rename GetBlockHash() to ConstructBlockHash()

2022-07-22 12:45:07 +02:00

checkqueue.cpp

test, bench: make prevector and checkqueue swap member functions noexcept

2022-04-28 20:34:43 +02:00

coins_view.cpp

fuzz: Remove useless GetUTXOStats fuzz case

2022-05-20 16:33:24 -04:00

connman.cpp

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Don't use zero as null pointer constant (-Wzero-as-null-pointer-constant)

2022-04-26 10:41:45 +01:00

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

[net] Move asmap into NetGroupManager

2022-04-20 14:29:29 +01:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

…

fuzz.cpp

Remove unused GetTimeSeconds

2022-05-11 16:39:23 +02:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

util: Add ParseHex<std::byte>() helper

2022-04-27 19:53:17 +02:00

http_request.cpp

Use std::string_view throughout util strencodings/string

2022-04-27 14:13:39 +02:00

i2p.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

integer.cpp

fuzz: add util/mempool/h.cpp

2022-10-04 21:12:50 +01:00

key_io.cpp

…

key.cpp

script/sign: remove needless IsSolvable() utility

2022-08-11 15:43:40 +02:00

kitchen_sink.cpp

…

load_external_block_file.cpp

refactor: Make mapBlocksUnknownParent local, and rename it

2022-07-18 12:06:14 -06:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

miniscript.cpp

miniscript: mark nodes with duplicate keys as insane

2022-05-30 15:16:43 +02:00

minisketch.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

…

net_permissions.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

net.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

netaddress.cpp

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

netbase_dns_lookup.cpp

[fuzz] Move ConsumeNetAddr to fuzz/util/net.h

2022-11-17 14:52:45 +00:00

node_eviction.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

p2p_transport_serialization.cpp

…

parse_hd_keypath.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

fuzz: refactor: Replace NullUniValue with UniValue{}

2022-07-25 17:20:56 +02:00

policy_estimator_io.cpp

Use AutoFile where possible

2022-06-29 10:33:13 +02:00

policy_estimator.cpp

refactor: Move txmempool_entry.h --> kernel/mempool_entry.h

2022-11-30 10:37:57 +00:00

pow.cpp

Merge bitcoin/bitcoin#25311: refactor: remove CBlockIndex copy construction

2022-12-19 09:34:39 +00:00

prevector.cpp

test, bench: make prevector and checkqueue swap member functions noexcept

2022-04-28 20:34:43 +02:00

primitives_transaction.cpp

…

process_message.cpp

Merge bitcoin/bitcoin#26295: Replace global g_cs_orphans lock with local

2022-11-28 10:59:02 +00:00

process_messages.cpp

Merge bitcoin/bitcoin#26295: Replace global g_cs_orphans lock with local

2022-11-28 10:59:02 +00:00

protocol.cpp

…

psbt.cpp

Make DecodeBase{32,64} always return vector, not string

2022-04-27 14:12:55 +02:00

random.cpp

…

rbf.cpp

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

rolling_bloom_filter.cpp

…

rpc.cpp

fuzz: add scanblocks as safe for fuzzing

2022-10-04 13:51:35 -04:00

script_assets_test_minimizer.cpp

scripted-diff: Use getInt<T> over get_int/get_int64

2022-05-18 19:15:03 +02:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_format.cpp

refactor: merge ScriptPubKeyToUniv & ScriptToUniv into one function

2022-03-30 20:00:23 +01:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

tests: Reduce calls to InitS*Cache()

2022-08-03 12:02:31 -04:00

script_sign.cpp

refactor: Change * to & in MutableTransactionSignatureCreator

2022-05-04 11:49:29 +02:00

script.cpp

script/sign: remove needless IsSolvable() utility

2022-08-11 15:43:40 +02:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

signet.cpp

…

socks5.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

span.cpp

…

spanparsing.cpp

…

string.cpp

refactor: move url.h/cpp from lib util to lib common

2022-10-31 10:17:04 +00:00

strprintf.cpp

…

system.cpp

…

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

Remove ::g_max_datacarrier_bytes global

2022-08-02 15:29:16 +02:00

tx_in.cpp

…

tx_out.cpp

Move minRelayTxFee to policy/settings

2022-05-31 15:05:57 +02:00

tx_pool.cpp

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

txorphan.cpp

Move all g_cs_orphans locking to txorphanage

2022-10-11 23:35:32 +10:00

txrequest.cpp

…

util.cpp

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

util.h

fuzz: Move-only net utils

2022-11-23 17:26:01 +01:00

utxo_snapshot.cpp

Require callers of AcceptBlockHeader() to perform anti-dos checks

2022-08-29 08:10:35 -04:00

validation_load_mempool.cpp

test: Remove unused txmempool include from tests

2022-10-18 14:02:09 +02:00

versionbits.cpp

…