highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
6154291cf9ab5dbf4951043339fa7eb2cdbb9fac
bitcoin/src/test/util
History
MarcoFalke 80a699fda9 Merge #21525: [Bundle 4.5/n] Followup fixups to bundle 4 
693414d271 node/ifaces: ChainImpl: Use an accessor for ChainMan (Carl Dong)
98c4e252f0 node/ifaces: NodeImpl: Use an accessor for ChainMan (Carl Dong)
7e8b5ee814 validation: Make BlockManager::LookupBlockIndex const (Carl Dong)
88aead263c node: Avoid potential UB by asserting assumptions (Carl Dong)
1dd8ed7a84 net_processing: Move comments to declarations (Carl Dong)
07156eb387 node/coinstats: Replace #include with fwd-declaration (Carl Dong)
7b8e976cd5 miner: Add chainstate member to BlockAssembler (Carl Dong)
e62067e7bc Revert "miner: Pass in chainstate to BlockAssembler::CreateNewBlock" (Carl Dong)
eede0647b0 Revert "scripted-diff: Invoke CreateNewBlock with chainstate" (Carl Dong)
0c1b2bc549 Revert "miner: Remove old CreateNewBlock w/o chainstate param" (Carl Dong)

Pull request description:

  Chronological history of this changeset:
  1. Bundle 4 (#21270) got merged
  2. Posthumous reviews were posted
  3. These changes were prepended in bundle 5
  4. More reviews were added in bundle 5
  5. Someone suggested that we split the prepended changes up to another PR
  6. This is that PR

  In the future, I will just do posthumous review changes in another PR instead. I apologize for the confusion.

  Addresses posthumous reviews on bundle 4:
    - From jnewbery:
      - https://github.com/bitcoin/bitcoin/pull/21270#issuecomment-796738048
        - I didn't fix this one, but I added a `TODO` comment so that we don't lost track of it
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592291225
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592296942
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592299738
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r592301704
    - From MarcoFalke:
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593096212
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593097032
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593097867
      - https://github.com/bitcoin/bitcoin/pull/21270#discussion_r593100570

  Addresses reviews on bundle 5:
  - Checking chainman existence before locking cs_main
    - MarcoFalke
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601776
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601876
  - Appropriate locking, usage of chainman, and control flow in `src/node/interfaces.cpp`
    - MarcoFalke
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r596601383
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597029360
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597029921
    - ryanofsky
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597163828
  - Style/comment formatting changes
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597026552
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597027186
  - Making LookupBlockIndex const
    - jnewbery
      - https://github.com/bitcoin/bitcoin/pull/21391#discussion_r597035062

ACKs for top commit:
  MarcoFalke:
    review ACK 693414d271 🛐
  ryanofsky:
    Code review ACK 693414d271. I reviewed this previously as part of #21391. I am a fan of the increasingly complicated bundle numbering, and kind of hope there in the next round there is some way we can get bundles 5.333333 and 5.666667!
  jamesob:
    ACK 693414d271 ([`jamesob/ackr/21525.1.dongcarl.bundle_4_5_n_followup_f`](https://github.com/jamesob/bitcoin/tree/ackr/21525.1.dongcarl.bundle_4_5_n_followup_f))

Tree-SHA512: 9bdc199f70400d01764e1bd03c25bdb6cff26dcef60e4ca3b649baf8d017a2dfc1f058099067962b4b6ccd32d078002b1389d733039f4c337558cb70324c0ee3
2021-04-01 10:58:53 +02:00
..
blockfilter.cpp
scripted-diff: test: Move setup_common to test library
2019-11-06 11:56:41 -05:00
blockfilter.h
scripted-diff: test: Move setup_common to test library
2019-11-06 11:56:41 -05:00
logging.cpp
scripted-diff: remove MakeUnique<T>()
2021-03-11 13:45:14 +08:00
logging.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
mining.cpp
miner: Add chainstate member to BlockAssembler
2021-03-24 15:40:56 -04:00
mining.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net.cpp
net: Treat raw message bytes as uint8_t
2020-11-20 15:11:21 +01:00
net.h
test: add I2P test for a runaway SAM proxy
2021-03-16 14:58:38 +01:00
README.md
doc: Add documentation for new test/lib
2019-11-06 11:56:53 -05:00
script.cpp
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
script.h
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
setup_common.cpp
Merge #21525: [Bundle 4.5/n] Followup fixups to bundle 4
2021-04-01 10:58:53 +02:00
setup_common.h
Move MakeNoLogFileContext to common libtest_util, and use it in bench
2021-03-03 09:17:37 +01:00
str.cpp
…
str.h
[test] move string helper functions into test library
2019-11-25 01:33:17 +01:00
transaction_utils.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
transaction_utils.h
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
validation.cpp
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
validation.h
test: Mock IBD in net_processing fuzzers
2020-11-07 07:50:59 +01:00
wallet.cpp
Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
2020-01-23 16:34:28 -05:00
wallet.h
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).

Reference in New Issue View Git Blame Copy Permalink