highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-07 20:43:03 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
620ac8c47539b5131e902df272fcc8b2d5a7c54a
bitcoin/src
History
Wladimir J. van der Laan 620ac8c475 Merge #19724: [net] Cleanup connection types- followups 
eb1c5d090f [doc] Follow developer notes, add comment about missing default. (Amiti Uttarwar)
d5a57cef62 [doc] Describe connection types in more depth. (Amiti Uttarwar)
4829b6fcc6 [refactor] Simplify connection type logic in ThreadOpenConnections (Amiti Uttarwar)
1e563aed78 [refactor] Simplify check for block-relay-only connection. (Amiti Uttarwar)
da3a0be61b [test] Add explicit tests that connection types get set correctly (Amiti Uttarwar)
1d74fc7df6 [trivial] Small style updates (Amiti Uttarwar)
ff6b9081ad [doc] Explain address handling logic in process messages (Amiti Uttarwar)
dff16b184b [refactor] Restructure logic to check for addr relay. (Amiti Uttarwar)
a6ab1e81f9 [net] Remove unnecessary default args on OpenNetworkConnection (Amiti Uttarwar)
8d6ff46f55 scripted-diff: Rename `OUTBOUND` ConnectionType to `OUTBOUND_FULL_RELAY` (Amiti Uttarwar)

Pull request description:

  This PR addresses outstanding review comments from #19316. It further simplifies `net.cpp` complexity and adds documentation about design goals about different connection types.

ACKs for top commit:
  naumenkogs:
    ACK eb1c5d090f
  laanwj:
    Code review ACK eb1c5d090f

Tree-SHA512: 2fe14e428404c95661e5518c8c90db07ab5b9ebb1bac921b3bdf82b181f444fae379f8fc0a2b619e6b4693f01c55bd246fbd8c8eedadd96849a30de3161afee5
2020-09-03 13:28:30 +02:00
..
bench
Merge #19710: bench: Prevent thread oversubscription and decreases the variance of result values
2020-08-31 08:29:27 +02:00
compat
…
config
…
consensus
…
crc32c
…
crypto
…
index
Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB
2020-08-21 12:48:46 +08:00
interfaces
refactor: Move wallet methods out of chain.h and node.h
2020-08-27 14:33:00 -04:00
leveldb
…
logging
…
node
refactor: Move wallet methods out of chain.h and node.h
2020-08-27 14:33:00 -04:00
policy
…
primitives
…
qt
remove usage of boost::bind
2020-08-31 19:34:57 +08:00
rpc
Merge #19717: rpc: Assert that RPCArg names are equal to CRPCCommand ones (mining,zmq,rpcdump)
2020-08-31 17:43:35 +02:00
script
Merge #19601: Refactoring CHashWriter & Get{Prevouts,Sequence,Outputs}Hash to SHA256 (Alternative to #18071)
2020-08-25 20:18:40 +08:00
secp256k1
…
support
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
test
[test] Add explicit tests that connection types get set correctly
2020-09-02 17:18:22 -07:00
univalue
…
util
Merge #19803: Bugfix: Define and use HAVE_FDATASYNC correctly outside LevelDB
2020-08-31 13:07:24 +08:00
wallet
Merge #19805: wallet: Avoid deserializing unused records when salvaging
2020-09-03 12:47:01 +08:00
zmq
Merge #14687: zmq: enable tcp keepalive
2020-09-02 09:09:18 +02:00
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
base58.h
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace usage of GetScriptForWitness with GetScriptForDestination
2020-08-14 08:44:42 +12:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Merge #19316: [net] Cleanup logic around connection types
2020-08-12 10:01:44 +08:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compat.h
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
Merge #19671: wallet: Remove -zapwallettxes
2020-09-01 09:26:28 +08:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #19840: Avoid callback when -blocknotify is empty
2020-09-02 15:14:34 +02:00
init.h
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_export_der(...)
2020-08-18 18:03:57 +00:00
key.h
…
limitedmap.h
…
logging.cpp
…
logging.h
…
Makefile.am
Move only: Move CDiskTxPos to its own file
2020-08-15 18:23:55 -04:00
Makefile.bench.include
…
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
Merge #19379: tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)
2020-08-31 10:56:34 +02:00
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
…
miner.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
[refactor] Simplify check for block-relay-only connection.
2020-09-02 17:18:22 -07:00
net_processing.h
Merge #19607: [p2p] Add Peer struct for per-peer data in net processing
2020-08-28 20:29:16 +02:00
net_types.h
…
net.cpp
[doc] Follow developer notes, add comment about missing default.
2020-09-02 17:18:22 -07:00
net.h
[doc] Follow developer notes, add comment about missing default.
2020-09-02 17:18:22 -07:00
netaddress.cpp
Merge #19797: net: Remove old check for 3-byte shifted IP addresses from pre-0.2.9 nodes
2020-08-28 17:51:37 +02:00
netaddress.h
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.cpp
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
optional.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
Merge #19070: p2p: Signal support for compact block filters with NODE_COMPACT_FILTERS
2020-08-13 15:44:48 +02:00
protocol.h
p2p: add CInv block message helper methods
2020-08-26 11:56:55 +02:00
psbt.cpp
…
psbt.h
…
pubkey.cpp
tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...)
2020-08-18 18:03:56 +00:00
pubkey.h
…
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
…
sync.cpp
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
sync.h
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
2020-08-18 10:46:53 +03:00
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
…
txmempool.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Pass mempool reference to chainstate constructor
2020-08-28 10:42:04 +02:00
validation.h
Merge #19668: Do not hide compile-time thread safety warnings
2020-09-01 08:18:26 +02:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…