mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00

Files

MarcoFalke 85883a9f8e Merge #16443 : refactor: have CCoins* data managed under CChainState

582d2cd747 Cover UTXO set access with lock annotations (James O'Beirne)
5693530685 refactor: have CCoins* data managed under CChainState (James O'Beirne)
fae6ab6aed refactor: pcoinsTip -> CChainState::CoinsTip() (James O'Beirne)

Pull request description:

  This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11):

  Parent PR: #15606
  Issue: #15605
  Specification: https://github.com/jamesob/assumeutxo-docs/tree/2019-04-proposal/proposal

  ---

  This change encapsulates UTXO set data within CChainState instances, removing global data `pcoinsTip` and `pcoinsviewdb`. This is necessary if we want to maintain multiple chainstates with their own rendering of the UTXO set.

  We introduce a class CoinsViews which consolidates the construction of a CCoins* hierarchy.

  This commit could be broken into smaller pieces, but it would require more ephemeral diffs to, e.g., temporarily change CCoinsViewDB's constructor invocations.

ACKs for top commit:
  Sjors:
    reACK 582d2cd747
  MarcoFalke:
    ACK 582d2cd747

Tree-SHA512: ec9d904fe5dca8cd2dc4b7916daa5d8bab30856dd4645987300f905e0a19f9919fce4f9d1ff03eda982943ca73e6e9a746be6cf53b46510de36e8c81a1eafba1

2019-08-15 12:47:15 -04:00

chain.cpp

Remove p2pEnabled from Chain interface

2019-08-08 22:57:35 -04:00

chain.h

Remove p2pEnabled from Chain interface

2019-08-08 22:57:35 -04:00

handler.cpp

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

handler.h

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

node.cpp

refactor: pcoinsTip -> CChainState::CoinsTip()

2019-08-06 13:13:06 -04:00

node.h

gui: Generate bech32 addresses by default (take 2, fixup)

2019-07-30 13:53:21 -04:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

Get rid of PendingWalletTx class.

2019-07-18 12:06:23 -04:00

wallet.h

Get rid of PendingWalletTx class.

2019-07-18 12:06:23 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.