highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-09-11 21:20:39 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
626d3464695ed513e555371b870a5899872d723b
bitcoin/src
History
Andrew Chow 7952a5934a Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization 
fa38d86235 Use only Span{} constructor for byte-like types where possible (MarcoFalke)
fa257bc831 util: Allow std::byte and char Span serialization (MarcoFalke)

Pull request description:

  Seems odd to require developers to cast all byte-like spans passed to serialization to `unsigned char`-spans. Fix that by passing and accepting byte-like spans as-is. Finally, add tests and update the code to use just `Span` where possible.

ACKs for top commit:
  sipa:
    utACK fa38d86235
  achow101:
    ACK fa38d86235
  ryanofsky:
    Code review ACK fa38d86235. This looks great. The second commit really removes a lot of boilerplate and shows why the first commit is useful.

Tree-SHA512: 788592d9ff515c3ebe73d48f9ecbb8d239f5b985af86f09974e508cafb0ca6d73a959350295246b4dfb496149bc56330a0b5d659fc434ba6723dbaba0b7a49e5
2023-06-28 15:12:12 -04:00
..
bench
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
common
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
compat
…
config
…
consensus
Use int32_t type for most transaction size/weight values
2023-06-12 19:47:19 +01:00
crc32c
…
crypto
…
index
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
init
init: remove config option names from translated -loglevel strings
2023-06-15 10:27:56 -06:00
interfaces
Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors
2023-06-12 12:54:49 -04:00
ipc
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel
refactor: Make m_count_with_* in CTxMemPoolEntry int64_t, drop UBSAN supp
2023-06-14 23:15:20 +02:00
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#27896: Remove the syscall sandbox
2023-06-27 18:19:21 -04:00
policy
Merge bitcoin/bitcoin#27914: feerate: For GetFeePerK() return nSatoshisPerK instead of round trip through GetFee
2023-06-26 09:43:38 +01:00
primitives
…
qt
Merge bitcoin/bitcoin#27708: Return EXIT_FAILURE on post-init fatal errors
2023-06-12 12:54:49 -04:00
rpc
Merge bitcoin/bitcoin#27896: Remove the syscall sandbox
2023-06-27 18:19:21 -04:00
script
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
secp256k1
Update src/secp256k1 subtree to version with ElligatorSwift support
2023-06-21 11:04:00 -04:00
support
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
test
Use only Span{} constructor for byte-like types where possible
2023-06-27 10:13:37 +02:00
univalue
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
util
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
wallet
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
zmq
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
.bear-tidy-config
…
.clang-format
…
.clang-tidy
…
addrdb.cpp
scripted-diff: move settings to common namespace
2023-05-30 17:26:51 +02:00
addrdb.h
fix includes for touched header files (iwyu)
2023-05-29 13:26:31 +02:00
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-chainstate.cpp
kernel: Remove chainparams, chainparamsbase, args, settings from kernel library
2023-05-30 17:15:22 +02:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
blockencodings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
…
checkqueue.h
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
Fix clang-tidy performance-unnecessary-copy-initialization warnings
2023-05-09 18:48:52 +02:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
…
headerssync.cpp
…
headerssync.h
…
httprpc.cpp
scripted-diff: Use UniValue::find_value method
2023-05-09 18:47:14 +02:00
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#27949: http: update libevent workaround to correct version
2023-06-28 12:20:25 +01:00
httpserver.h
…
i2p.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
i2p.h
…
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#27896: Remove the syscall sandbox
2023-06-27 18:19:21 -04:00
init.h
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
key_io.cpp
use 'byte'/'bytes' for bech32(m) validation error
2023-05-25 06:30:10 +00:00
key_io.h
…
key.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
key.h
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
logging.cpp
refactor: rename BCLog::BLOCKSTORE to BLOCKSTORAGE
2023-06-15 10:27:56 -06:00
logging.h
refactor: rename BCLog::BLOCKSTORE to BLOCKSTORAGE
2023-06-15 10:27:56 -06:00
Makefile.am
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
Makefile.bench.include
Bench test for EllSwift ECDH
2023-06-23 14:24:32 -04:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
fuzz: wallet, add target for CoinControl
2023-06-17 23:55:16 +05:30
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
Merge bitcoin/bitcoin#26261: p2p: cleanup LookupIntern, Lookup and LookupHost
2023-05-30 11:39:59 -04:00
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#27947: MaybePunishNodeForTx: Remove unused message arg and logging
2023-06-26 10:39:32 +01:00
net_processing.h
Support up to 3 parallel compact block txn fetchings
2023-05-23 13:07:49 -04:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
net.h
net: remove unused CConnmanTest
2023-06-23 18:03:06 -03:00
netaddress.cpp
…
netaddress.h
…
netbase.cpp
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
netbase.h
p2p, refactor: return std::optional<CNetAddr> in LookupHost
2023-05-26 13:41:07 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
protocol.h
doc: Remove unused NO_BLOOM_VERSION constant
2023-05-15 10:18:58 +02:00
psbt.cpp
…
psbt.h
…
pubkey.cpp
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
pubkey.h
Use only Span{} constructor for byte-like types where possible
2023-06-27 10:13:37 +02:00
random.cpp
Bench test for EllSwift ECDH
2023-06-23 14:24:32 -04:00
random.h
Bench test for EllSwift ECDH
2023-06-23 14:24:32 -04:00
randomenv.cpp
…
randomenv.h
…
rest.cpp
rest: bugfix, fix crash error when calling /deploymentinfo
2023-06-12 10:24:14 -03:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
…
serialize.h
util: Allow std::byte and char Span serialization
2023-06-27 10:13:29 +02:00
shutdown.cpp
Return EXIT_FAILURE on post-init fatal errors
2023-06-09 17:52:23 -03:00
shutdown.h
Return EXIT_FAILURE on post-init fatal errors
2023-06-09 17:52:23 -03:00
signet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
signet.h
…
span.h
Add ElligatorSwift key creation and ECDH logic
2023-06-23 14:22:33 -04:00
streams.h
streams: Drop confusing DataStream::Serialize method and << operator
2023-06-01 10:27:33 -04:00
sync.cpp
…
sync.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
torcontrol.h
…
txdb.cpp
refactor: Replace std::optional<bilingual_str> with util::Result
2023-05-24 08:55:47 -04:00
txdb.h
fix includes for touched header files (iwyu)
2023-05-29 13:26:31 +02:00
txmempool.cpp
refactor: Make m_count_with_* in CTxMemPoolEntry int64_t, drop UBSAN supp
2023-06-14 23:15:20 +02:00
txmempool.h
Use int32_t type for most transaction size/weight values
2023-06-12 19:47:19 +01:00
txorphanage.cpp
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txorphanage.h
scripted-diff: Following the C++ Standard rules for identifiers with _.
2023-06-20 10:23:08 +02:00
txrequest.cpp
Add public Boost headers explicitly
2023-05-31 15:43:01 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#26828: assumeutxo: catch and log fs::remove error instead of two exist checks
2023-06-23 16:21:43 -04:00
validation.h
Merge bitcoin/bitcoin#27334: util: implement noexcept move assignment & move ctor for prevector
2023-06-27 15:42:51 -04:00
validationinterface.cpp
…
validationinterface.h
…
version.h
doc: Remove unused NO_BLOOM_VERSION constant
2023-05-15 10:18:58 +02:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
warnings.h
…