laanwj
0ea92cad52
Merge bitcoin/bitcoin#24356 : refactor: replace CConnman::SocketEvents() with mockable Sock::WaitMany()
...
6e68ccbefe net: use Sock::WaitMany() instead of CConnman::SocketEvents() (Vasil Dimov)
ae263460ba net: introduce Sock::WaitMany() (Vasil Dimov)
cc74459768 net: also wait for exceptional events in Sock::Wait() (Vasil Dimov)
Pull request description:
_This is a piece of #21878 , chopped off to ease review._
`Sock::Wait()` waits for IO events on one socket. Introduce a similar `virtual` method `WaitMany()` that waits simultaneously for IO events on more than one socket.
Use `WaitMany()` instead of `CConnman::SocketEvents()` (and ditch the latter). Given that the former is a `virtual` method, it can be mocked by unit and fuzz tests. This will help to make bigger parts of `CConnman` testable (unit and fuzz).
ACKs for top commit:
laanwj:
Code review ACK 6e68ccbefe
jonatack:
re-ACK 6e68ccbefe per `git range-diff e18fd47 6747729 6e68ccb`, and verified rebase to master and debug build
Tree-SHA512: 917fb6ad880d64d3af1ebb301c06fbd01afd8ff043f49e4055a088ebed6affb7ffe1dcf59292d822f10de5f323b6d52d557cb081dd7434634995f9148efcf08f
2022-06-16 20:05:03 +02:00
..
2022-02-21 14:32:53 +01:00
2022-04-20 14:29:29 +01:00
2021-12-30 19:36:57 +02:00
2022-04-20 14:35:52 +01:00
2022-01-02 11:40:31 +01:00
2021-11-19 12:41:47 +01:00
2022-04-27 14:13:39 +02:00
2021-12-30 19:36:57 +02:00
2020-12-10 07:15:42 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-11-12 19:51:55 +00:00
2022-01-02 11:40:31 +01:00
2022-01-25 20:43:28 +01:00
2022-04-28 20:34:43 +02:00
2022-05-20 16:33:24 -04:00
2022-04-20 14:29:29 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-17 10:46:39 +01:00
2021-11-12 19:51:55 +00:00
2020-12-10 07:15:42 +01:00
2022-04-26 10:41:45 +01:00
2021-12-30 19:36:57 +02:00
2020-12-10 07:15:42 +01:00
2021-08-21 19:25:33 +02:00
2021-12-30 19:36:57 +02:00
2020-12-31 09:45:41 +01:00
2021-12-30 19:36:57 +02:00
2022-04-20 14:29:29 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2020-12-10 07:15:42 +01:00
2021-12-30 19:36:57 +02:00
2022-05-11 16:39:23 +02:00
2021-08-21 19:25:33 +02:00
2021-03-09 12:56:44 +01:00
2022-01-06 11:29:55 -05:00
2022-04-27 19:53:17 +02:00
2022-04-27 14:13:39 +02:00
2021-05-24 10:29:58 +02:00
2022-01-27 19:19:12 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2021-08-04 19:20:32 +08:00
2021-06-13 09:43:54 +02:00
2021-12-30 19:36:57 +02:00
2021-11-12 19:51:55 +00:00
2020-12-10 07:15:42 +01:00
2022-05-30 15:16:43 +02:00
2022-01-06 22:14:16 -05:00
2021-09-22 10:39:08 +02:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-03-18 11:35:56 +00:00
2022-02-11 15:21:52 +01:00
2021-12-07 13:13:18 +01:00
2022-03-18 11:35:58 +00:00
2022-01-15 20:59:19 +02:00
2020-12-31 09:45:41 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2020-12-31 09:45:41 +01:00
2021-12-30 19:36:57 +02:00
2021-03-03 09:17:37 +01:00
2021-11-19 12:41:47 +01:00
2021-12-17 10:46:39 +01:00
2022-04-28 20:34:43 +02:00
2020-12-10 07:15:42 +01:00
2021-12-01 12:15:01 +01:00
2021-12-01 12:15:01 +01:00
2020-12-10 07:15:42 +01:00
2022-04-27 14:12:55 +02:00
2020-12-10 07:15:42 +01:00
2021-12-30 19:36:57 +02:00
2021-10-05 11:10:37 +02:00
2022-05-05 14:56:48 +02:00
2022-05-18 19:15:03 +02:00
2020-12-10 07:15:42 +01:00
2021-12-30 19:36:57 +02:00
2021-12-30 19:36:57 +02:00
2022-03-30 20:00:23 +01:00
2020-12-10 07:15:42 +01:00
2021-11-12 19:51:55 +00:00
2020-12-15 19:00:36 +01:00
2022-05-04 11:49:29 +02:00
2022-02-15 12:19:34 +01:00
2021-11-12 19:51:55 +00:00
2020-12-10 07:15:42 +01:00
2020-12-10 07:15:42 +01:00
2022-05-17 17:18:58 +01:00
2021-03-03 09:17:37 +01:00
2021-03-16 19:52:37 +01:00
2020-12-10 07:15:42 +01:00
2020-12-31 09:45:41 +01:00
2022-05-04 07:34:48 +02:00
2021-05-09 10:25:21 +02:00
2021-09-29 13:24:14 +02:00
2021-12-30 19:36:57 +02:00
2021-11-12 19:51:55 +00:00
2022-03-30 20:00:27 +01:00
2020-12-31 09:45:41 +01:00
2022-05-31 15:05:57 +02:00
2022-06-06 15:38:09 -04:00
2021-12-30 19:36:57 +02:00
2022-06-09 14:20:18 +02:00
2022-06-16 20:05:03 +02:00
2022-05-10 12:09:33 +10:00
2021-06-10 15:04:39 -04:00
2022-01-15 04:37:56 +10:00