laanwj 6300b9556e Merge bitcoin/bitcoin#24357: refactor: make setsockopt() and SetSocketNoDelay() mockable/testable ...

a2c4a7acd1 net: use Sock::SetSockOpt() instead of standalone SetSocketNoDelay() (Vasil Dimov)
d65b6c3fb9 net: use Sock::SetSockOpt() instead of setsockopt() (Vasil Dimov)
184e56d668 net: add new method Sock::SetSockOpt() that wraps setsockopt() (Vasil Dimov)

Pull request description:

  _This is a piece of #21878, chopped off to ease review._

  Add a `virtual` (thus mockable) method `Sock::SetSockOpt()` that wraps the system `setsockopt()`.

  Convert the standalone `SetSocketNoDelay()` function to a `virtual` (thus mockable) method `Sock::SetNoDelay()`.

  This will help avoid syscalls during testing and to mock them to return whatever is suitable for the tests.

ACKs for top commit:
  laanwj:
    Code review ACK a2c4a7acd1
  jonatack:
    ACK a2c4a7acd1 change since last review is folding `Sock::SetNoDelay()` into the callers

Tree-SHA512: 3e2b016c1e4128317a28c17dc9b30472949e1ac3b071b2697c6d30cbcc830df1ee4392a4e23b2ea1ab4e3fb0f59ef450e2a4f3c1df3d8c803dd081652b6c7387

2022-04-19 16:43:47 +02:00

..

asmap.cpp

…

asmap.h

…

bip32.cpp

…

bip32.h

…

bytevectorhash.cpp

…

bytevectorhash.h

…

check.cpp

util/check: stop using lambda for Assert/Assume

2022-03-30 23:09:13 +10:00

check.h

util/check: avoid unused parameter warnings

2022-04-01 14:10:46 +10:00

epochguard.h

…

error.cpp

…

error.h

…

fastrange.h

…

fees.cpp

…

fees.h

…

getuniquepath.cpp

…

getuniquepath.h

…

golombrice.h

…

hash_type.h

…

hasher.cpp

…

hasher.h

…

macros.h

…

message.cpp

…

message.h

…

moneystr.cpp

…

moneystr.h

…

overflow.h

…

overloaded.h

…

rbf.cpp

…

rbf.h

…

readwritefile.cpp

…

readwritefile.h

…

serfloat.cpp

…

serfloat.h

…

settings.cpp

…

settings.h

…

sock.cpp

net: add new method Sock::SetSockOpt() that wraps setsockopt()

2022-04-15 09:14:49 +02:00

sock.h

net: add new method Sock::SetSockOpt() that wraps setsockopt()

2022-04-15 09:14:49 +02:00

spanparsing.cpp

…

spanparsing.h

…

strencodings.cpp

…

strencodings.h

…

string.cpp

…

string.h

…

syscall_sandbox.cpp

Remove gui-only syscalls

2022-04-05 13:30:06 +02:00

syscall_sandbox.h

init: Disable syscall sandbox in the bitcoin-qt process

2022-04-05 13:29:42 +02:00

system.cpp

build: Fix Boost.Process test for Boost 1.78

2022-03-21 16:52:27 +00:00

system.h

…

thread.cpp

…

thread.h

…

threadnames.cpp

refactor: add missing std:: includes to threadnames.cpp

2022-04-01 14:49:13 +01:00

threadnames.h

…

time.cpp

Simplify GetTime

2022-04-16 13:15:14 +02:00

time.h

…

tokenpipe.cpp

…

tokenpipe.h

…

trace.h

…

translation.h

…

types.h

…

ui_change_type.h

…

url.cpp

…

url.h

…

vector.h

…