mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-19 12:10:19 +01:00
fc162299f0
1cb2399703doc: clarify the GetAddresses/GetAddressesUnsafe documentation (Daniela Brozzoni)e5a7dfd79fp2p: rename GetAddresses -> GetAddressesUnsafe (Daniela Brozzoni) Pull request description: Rename GetAddresses to GetAddressesUnsafe to make it clearer that this function should only be used in trusted contexts. This helps avoid accidental privacy leaks by preventing the uncached version from being used in non-trusted scenarios, like P2P. Additionally, better reflect in the documentation that the two methods should be used in different contexts. Also update the outdated "call the function without a parameter" phrasing in the cached version. This wording was accurate when the cache was introduced in #18991, but became outdated after later commits (f26502e9fc,81b00f8780) added parameters to each function, and the previous commit changed the function naming completely. ACKs for top commit: stickies-v: re-ACK1cb2399703l0rinc: ACK1cb2399703luisschwab: ACK1cb2399703brunoerg: ACK1cb2399703theStack: Code-review ACK1cb2399703mzumsande: Code review ACK1cb2399703Tree-SHA512: 02c05d88436abcdfabad994f47ec5144e9ba47668667a2c1818f57bf8710727505faf8426fd0672c63de14fcf20b96f17cea2acc39fe3c1f56abbc2b1a9e9c23