Andrew Chow 3aa851ad2a

Merge bitcoin/bitcoin#24820: test: 3 new tests for SelectCoins function ...

3f8def51d53a078a5ee71ec675b5e06b784147de add 3 new test cases for SelectCoins() (akankshakashyap)

Pull request description:

  Three new tests have been added.

  1. More coins should be selected when effective fee < long term fee.
  2. Less coin should be selected when effective fee > long term fee.
  3. If a coin is preselected, it should be selected even if disadvantageous.

ACKs for top commit:
  achow101:
    ACK 3f8def51d53a078a5ee71ec675b5e06b784147de
  brunoerg:
    ACK 3f8def51d53a078a5ee71ec675b5e06b784147de

Tree-SHA512: 8db6dd942b02a38c99953b801605f98c4c17729768fdfcf7605c5bbdb17509500a39d0a78a4b19aab37812d2994ec7630d2b4e78d1d348f1c27b67588d74e155

2022-05-20 12:06:30 -04:00

..

rpc

Merge bitcoin/bitcoin#25171: rpc: wallet: remove -deprecatedrpc=exclude_coinbase logic

2022-05-20 08:48:09 +01:00

test

Merge bitcoin/bitcoin#24820: test: 3 new tests for SelectCoins function

2022-05-20 12:06:30 -04:00

bdb.cpp

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

wallet: track which coin selection algorithm produced a SelectionResult

2022-04-14 12:40:36 -04:00

coinselection.h

wallet: Add some tracepoints for coin selection

2022-04-14 13:41:36 -04:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

wallet: CreateTransaction(): return out-params as (optional) struct

2022-05-16 17:46:34 +02:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains

2022-04-28 15:59:47 -04:00

interfaces.cpp

Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

2022-05-18 16:23:43 +02:00

ismine.h

…

load.cpp

…

load.h

…

receive.cpp

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

receive.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

…

scriptpubkeyman.h

…

spend.cpp

wallet: CreateTransaction(): return out-params as (optional) struct

2022-05-16 17:46:34 +02:00

spend.h

wallet: CreateTransaction(): return out-params as (optional) struct

2022-05-16 17:46:34 +02:00

sqlite.cpp

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

sqlite.h

…

transaction.cpp

…

transaction.h

…

wallet.cpp

Merge bitcoin/bitcoin#25148: refactor: Remove NO_THREAD_SAFETY_ANALYSIS from non-test/benchmarking code

2022-05-18 16:23:43 +02:00

wallet.h

Add more proper thread safety annotations

2022-05-16 20:51:40 +02:00

walletdb.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

walletdb.h

…

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

…