highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-21 05:00:10 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
65526fc8666fef35ef908dbc225f706bef642c7e
bitcoin/src
History
MarcoFalke 65526fc866 Merge #15777: [docs] Add doxygen comments for keypool classes 
f1a77b0c51 [docs] Add doxygen comment for CReserveKey (John Newbery)
37796b2dd4 [docs] Add doxygen comment for CKeyPool (John Newbery)
ef2d515af3 [wallet] move-only: move CReserveKey to be next to CKeyPool (John Newbery)

Pull request description:

  Docs/move-only

  Adds doxygen comments for the CKeyPool and CReserveKey objects. The way these work is pretty confusing and it's easy to overlook details (eg https://github.com/bitcoin/bitcoin/pull/15557#discussion_r271956393).

  These are on the verbose side, but I think too much commenting is better than not enough. Happy to take feedback on what's an appropriate level.

ACKs for commit f1a77b:
  jonatack:
    Thanks, John. Re-ACK f1a77b0c51, doc-only changes with respect to previous review.
  jb55:
    ACK f1a77b0c51

Tree-SHA512: 8bc97c7029cd2e8d9bfd2d2144eeff73474c71eda5a9d10817e1578ca0b70da677252037d83143faaff1808e2193408a21a8a89d36049eac77fd313990f0b67b
2019-05-14 09:16:33 -04:00
..
bench
[refactor] interfaces: Add missing LockAnnotation for cs_main
2019-05-13 14:46:01 -04:00
compat
Document assumptions about C++ compiler
2019-03-05 11:19:32 +01:00
config
…
consensus
Separate reason for premature spends (coinbase/locktime)
2019-05-02 15:30:58 -04:00
crypto
Merge #15512: Add ChaCha20 encryption option (XOR)
2019-05-10 09:26:23 +02:00
index
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
interfaces
[refactor] interfaces: Add missing LockAnnotation for cs_main
2019-05-13 14:46:01 -04:00
leveldb
…
node
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp
2019-04-09 17:53:08 -04:00
obj
…
obj-test
…
policy
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
primitives
Merge #14039: Disallow extended encoding for non-witness transactions
2019-04-25 14:15:43 -04:00
qt
[refactor] interfaces: Add missing LockAnnotation for cs_main
2019-05-13 14:46:01 -04:00
rpc
Merge #14802: rpc: faster getblockstats using BlockUndo data
2019-05-10 13:20:48 -04:00
script
Merge #15452: Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-05-09 18:54:43 +02:00
secp256k1
…
support
…
test
Merge #15988: Add test for ArgsManager::GetChainName
2019-05-14 08:53:37 -04:00
univalue
…
util
Merge #15650: Handle the result of posix_fallocate system call
2019-05-02 08:43:57 -04:00
wallet
Merge #15777: [docs] Add doxygen comments for keypool classes
2019-05-14 09:16:33 -04:00
zmq
…
.clang-format
…
addrdb.cpp
…
addrdb.h
…
addrman.cpp
[addrman] Improve collision logging and address nits
2019-03-01 16:15:50 -05:00
addrman.h
[addrman] Ensure collisions eventually get resolved
2019-02-27 16:53:44 -05:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge #15564: cli: remove duplicate wallet fields from -getinfo
2019-03-11 10:28:42 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
threads: introduce util/threadnames, refactor thread naming
2019-04-29 13:42:25 -04:00
blockencodings.cpp
CorruptionPossible -> BLOCK_MUTATED
2019-05-02 15:14:12 -04:00
blockencodings.h
…
blockfilter.cpp
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
blockfilter.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
bloom.cpp
…
bloom.h
…
chain.cpp
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chain.h
refactor: combine Chain::findFirstBlockWithTime/findFirstBlockWithTimeAndHeight
2019-03-27 18:29:48 -04:00
chainparams.cpp
Update assumevalid, minimumchainwork, and getchaintxstats to height 563378.
2019-02-17 03:38:08 +00:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
Merge #15267: doc: explain AcceptToMemoryPoolWorker's coins_to_uncache
2019-04-26 13:09:30 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_memusage.h
…
core_read.cpp
Move PSBT decoding functions from core_io to psbt.cpp
2019-03-26 17:38:00 -07:00
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
dbwrapper.h
…
dummywallet.cpp
Bugfix: dummywallet: Add -ignorepartialspends to list of ignored wallet options
2019-04-28 04:42:38 +00:00
flatfile.cpp
Style cleanup.
2019-02-22 17:38:45 -08:00
flatfile.h
Style cleanup.
2019-02-22 17:38:45 -08:00
fs.cpp
Avoid redefine warning
2019-04-10 12:16:52 +01:00
fs.h
Replace deprecated Boost Filesystem function
2019-04-30 10:05:54 +03:00
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
threads: introduce util/threadnames, refactor thread naming
2019-04-29 13:42:25 -04:00
httpserver.h
[build] Add several util units
2019-04-09 17:53:08 -04:00
indirectmap.h
…
init.cpp
Merge #14364: doc: Clarify -blocksdir usage
2019-05-13 12:46:03 -04:00
init.h
…
key_io.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
key_io.h
…
key.cpp
…
key.h
…
keystore.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
keystore.h
…
limitedmap.h
…
logging.cpp
threads: prefix log messages with thread names
2019-04-29 13:49:15 -04:00
logging.h
threads: prefix log messages with thread names
2019-04-29 13:49:15 -04:00
Makefile.am
Merge #15849: Thread names in logs and deadlock debug tools
2019-04-30 15:26:01 -04:00
Makefile.bench.include
Merge #15512: Add ChaCha20 encryption option (XOR)
2019-05-10 09:26:23 +02:00
Makefile.leveldb.include
…
Makefile.qt.include
GUI: Move QRImageWidget to its own file-pair
2019-05-02 12:18:18 +00:00
Makefile.qttest.include
scripted-diff: Rename test_bitcoin to test/setup_common
2019-04-11 10:12:36 -04:00
Makefile.test.include
tests: add threadutil tests
2019-04-29 13:43:01 -04:00
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
miner.h
…
net_processing.cpp
Merge #15948: refactor: rename chainActive
2019-05-07 11:51:30 -04:00
net_processing.h
…
net.cpp
net: Remove unused unsanitized user agent string CNode::strSubVer
2019-03-23 11:32:40 -04:00
net.h
Merge #15654: net: Remove unused unsanitized user agent string CNode::strSubVer
2019-04-04 16:45:23 -04:00
netaddress.cpp
docs: Improve netaddress comments
2019-04-10 11:48:47 -04:00
netaddress.h
docs: Improve netaddress comments
2019-04-10 11:48:47 -04:00
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
optional.h
…
outputtype.cpp
Replace CScriptID and CKeyID in CTxDestination with dedicated types
2019-04-29 10:15:23 -04:00
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
Merge #14266: refactor: Lift prevector default vals to the member declaration
2019-05-06 15:32:24 -04:00
protocol.cpp
…
protocol.h
…
psbt.cpp
Silence GCC 7 warning "control reaches end of non-void function" (-Wreturn-type) in psbt.cpp
2019-05-02 15:08:22 +02:00
psbt.h
[build] Move AnalyzePSBT from psbt.cpp to node/psbt.cpp
2019-04-09 17:53:08 -04:00
pubkey.cpp
…
pubkey.h
…
random.cpp
Add ChaCha20 encryption option (XOR)
2019-05-03 20:31:18 +02:00
random.h
Add ChaCha20 encryption option (XOR)
2019-05-03 20:31:18 +02:00
rest.cpp
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
reverse_iterator.h
…
reverselock.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
serialize: Serialization support for big-endian 32-bit ints.
2019-04-06 12:03:21 -07:00
shutdown.cpp
…
shutdown.h
…
span.h
…
streams.h
…
sync.cpp
threads: add thread names to deadlock debugging message
2019-04-29 13:51:59 -04:00
sync.h
Add WITH_LOCK macro: run code while locking a mutex
2019-04-20 08:13:34 -04:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
init: Add CLI option to enable block filter index.
2019-04-06 12:10:55 -07:00
txmempool.cpp
Merge #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo
2019-05-01 10:06:15 -04:00
txmempool.h
scripted-diff: replace chainActive -> ::ChainActive()
2019-05-03 15:02:54 -04:00
ui_interface.cpp
Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
2019-04-23 13:03:41 -04:00
ui_interface.h
Merge #15699: Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
2019-04-23 13:03:41 -04:00
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
[refactor] interfaces: Add missing LockAnnotation for cs_main
2019-05-13 14:46:01 -04:00
validation.h
[refactor] interfaces: Add missing LockAnnotation for cs_main
2019-05-13 14:46:01 -04:00
validationinterface.cpp
[wallet] Schedule tx rebroadcasts in wallet
2019-04-09 10:38:13 -04:00
validationinterface.h
[cleanup] Remove unused CReserveKey
2019-04-10 11:44:40 -04:00
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…