mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-04-06 21:57:54 +02:00
5440280891
20fb7618b0args: make most ArgsManager members private (w0xlt)22b40f34f3args: replace cs_args RecursiveMutex with Mutex (w0xlt)3a16ec8582test: scope cs_args locks to avoid recursive locking (w0xlt)70b51fef7aargs: eliminate all recursive locking of cs_args (w0xlt)7d61e03c70args: extract lock-requiring internal helpers (w0xlt) Pull request description: Part of #19303. Replace `ArgsManager::cs_args` from `RecursiveMutex` to `Mutex`. The conversion follows the pattern established in prior `RecursiveMutex` removals (e.g. `CAddrMan` in #19238, `CBlockPolicyEstimator` in #22014): extract private lock-held helpers with trailing underscore naming (`GetSetting_()`, `GetArgFlags_()`, `GetPathArg_()`), then replace recursive calls in methods that already hold `cs_args` with those helpers. ACKs for top commit: l0rinc: ACK20fb7618b0rkrux: Concept ACK20fb7618b0sedited: Re-ACK20fb7618b0hebasto: ACK20fb7618b0, only rebased and suggested changes since my recent [review](https://github.com/bitcoin/bitcoin/pull/34745#pullrequestreview-3916715262). Tree-SHA512: 7ab4278737f00deaa3f3da75e08469f91e95aa31e916820d02af737c754751ae4f73c1c8650f120eeff142a134f9209cf581499696a7b88ffc83d296515e40f2