mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-08-05 16:01:46 +02:00
5311b15727
7e19ce200brpc: Fix descriptorprocesspsbt internal bug on invalid signatures (b-l-u-e) Pull request description: Fixes #32849 descriptorprocesspsbt crashes with an internal bug assertion when given a PSBT whose inputs looked “finalized” that is non-empty final_script_sig / witness but whose signatures did not verify like invalid Schnorr bytes with unusual sighash combinations such as SIGHASH_SINGLE | ANYONECANPAY. Completeness was inferred with PSBTInputSigned, which only checks that final fields are present, not that they pass script verification. That let the RPC treat the PSBT as complete and call FinalizeAndExtractPSBT, where a failing invariant surfaced as CHECK_NONFATAL instead of a normal incomplete outcome. This PR determines complete the same way as the wallet path: after ProcessPSBT, it recomputes PrecomputedTransactionData and sets complete only if every input passes PSBTInputSignedAndVerified. Invalid signatures then yield complete: false and no hex, without going through the finalize path that asserted. ACKs for top commit: achow101: ACK7e19ce200brkrux: lgtm re-ACK7e19ce200bTree-SHA512: c534fb5bd3401ee3ac0bc27eaedaaaaf23e5e8510ed9b96a747bb0e41e2bd3d2031b6b08e933e139bb426e97bd05fab6e91397205f4be1db9d17630eea49a8bf