MarcoFalke 01b45b2e01 Merge #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp} ...

8b3136bd30 refactor: replace CNode pointers by references within net_processing.{h,cpp} (Sebastian Falbesoner)

Pull request description:

  This PR is inspired by a [recent code review comment](https://github.com/bitcoin/bitcoin/pull/19010#discussion_r426954791) on a PR that introduced new functions to the net_processing module. The point of the discussion was basically that whenever we pass something not by value (in the concrete example it was about `CNode*` and `CConnman*`) we should either use
  * a pointer (```CType*```) with null pointer check or
  * a reference (```CType&```)

  To keep things simple, this PR for a first approach
  * only tackles `CNode*` pointers
  * only within the net_processing module, i.e. no changes that would need adaption in other modules
  * keeps the names of the variables as they are

  I'm aware that PRs like this are kind of a PITA to review, but I think the code quality would increase if we get rid of pointers without nullptr check -- bloating up the code by adding all the missing checks would be the worse alternative, in my opinion.

  Possible follow-up PRs, in case this is received well:
  * replace CNode pointers by references for net module
  * replace CConnman pointers by references for net_processing module
  * ...

ACKs for top commit:
  MarcoFalke:
    ACK 8b3136bd30 🔻
  practicalswift:
    ACK 8b3136bd30

Tree-SHA512: 15b6a569ecdcb39341002b9f4e09b38ed4df077e3a3a50dfb1b72d98bdc9f9769c7c504f106456aa7748af8591af7bb836b72d46086df715ab116e4ac3224b3b

2020-06-04 14:45:32 -04:00

..

addition_overflow.cpp

tests: Add fuzzing harness for AdditionOverflow(...)

2020-04-08 14:45:27 +00:00

addrdb.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

asmap_direct.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

asmap.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

base_encode_decode.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

bech32.cpp

…

block_header.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

block.cpp

tests: Fill fuzzing coverage gaps for functions in consensus/validation.h

2020-05-14 18:45:42 +00:00

blockfilter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

chain.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

checkqueue.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

coins_view.cpp

tests: Add fuzzing harness for CCoinsViewCache

2020-05-25 10:05:06 +00:00

cuckoocache.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

decode_tx.cpp

…

descriptor_parse.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

deserialize.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

eval_script.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

fee_rate.cpp

…

fees.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

flatfile.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

float.cpp

…

fuzz.cpp

tests: Don't limit fuzzing inputs to 1 MB for afl-fuzz (now: ∞ ∀ fuzzers)

2020-05-22 15:15:46 +00:00

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

hex.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

http_request.cpp

fuzz: http_request workaround for libevent < 2.1.1

2020-04-17 19:00:19 +02:00

integer.cpp

Merge #18413: script: prevent UB when computing abs value for num opcode serialize

2020-05-02 21:24:05 +08:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

tests: Add fuzzing coverage for JSONRPCTransactionError(...) and RPCErrorFromTransactionError(...)

2020-04-26 20:23:56 +00:00

locale.cpp

fuzz: fix unused variable compiler warning

2020-04-17 13:45:43 +02:00

merkleblock.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

message.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

multiplication_overflow.cpp

…

net_permissions.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

netaddress.cpp

…

p2p_transport_deserializer.cpp

…

parse_hd_keypath.cpp

tests: Add fuzzing coverage for FormatHDKeypath(...) and WriteHDKeypath(...)

2020-04-26 20:23:56 +00:00

parse_iso8601.cpp

…

parse_numbers.cpp

…

parse_script.cpp

…

parse_univalue.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

policy_estimator.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

pow.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

prevector.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

primitives_transaction.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

process_message.cpp

Merge #19053: refactor: replace CNode pointers by references within net_processing.{h,cpp}

2020-06-04 14:45:32 -04:00

process_messages.cpp

fuzz: Stop nodes in process_message* fuzzers

2020-05-12 07:28:12 -04:00

protocol.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

psbt.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

random.cpp

…

rbf.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

rolling_bloom_filter.cpp

Switch from Optional<T> to std::optional<T> (C++17). Run clang-format.

2020-05-14 18:52:57 +00:00

script_bitcoin_consensus.cpp

tests: Add fuzzing harness for functions in script/bitcoinconsensus.h

2020-05-30 10:37:01 +00:00

script_descriptor_cache.cpp

tests: Add fuzzing harness for functions in script/descriptor.h

2020-05-30 10:37:01 +00:00

script_flags.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

script_interpreter.cpp

tests: Add fuzzing harness for functions in script/interpreter.h

2020-05-30 10:37:01 +00:00

script_ops.cpp

script: Remove undocumented and unused operator+

2020-04-15 10:01:55 -04:00

script_sigcache.cpp

tests: Add fuzzing harness for functions in script/sigcache.h

2020-05-30 10:37:01 +00:00

script_sign.cpp

tests: Add fuzzing harness for functions in script/sign.h

2020-05-30 10:37:01 +00:00

script.cpp

tests: Fill fuzzing coverage gaps for functions in script/script.h, script/script_error.h and script/standard.h

2020-05-30 10:37:01 +00:00

scriptnum_ops.cpp

script: prevent UB when computing abs value for num opcode serialize

2020-04-09 08:32:00 +09:00

signature_checker.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

span.cpp

…

spanparsing.cpp

…

string.cpp

tests: Fill fuzzing coverage gaps for functions in script/script.h, script/script_error.h and script/standard.h

2020-05-30 10:37:01 +00:00

strprintf.cpp

tests: Fill fuzzing coverage gaps for functions in util/translation.h

2020-05-14 18:52:57 +00:00

system.cpp

fuzz: fix vector size problem in system fuzzer

2020-05-08 20:21:48 +02:00

timedata.cpp

…

transaction.cpp

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

tx_in.cpp

…

tx_out.cpp

…

util.h

tests: Add fuzzing helper functions ConsumeDataStream, ConsumeTxDestination and ConsumeUInt160

2020-05-29 16:44:22 +00:00