MarcoFalke 6677be64f6 Merge #17473: refactor: Settings code cleanups ...

e9fd366044 refactor: Remove null setting check in GetSetting() (Russell Yanofsky)
cba2710220 scripted-diff: Remove unused ArgsManager type flags in tests (Russell Yanofsky)
425bb30725 refactor: Add util_CheckValue test (Russell Yanofsky)
0fa54358b0 refactor: Add ArgsManager::GetSettingsList method (Russell Yanofsky)
3e185522ac refactor: Get rid of ArgsManagerHelper class (Russell Yanofsky)
dc0f148074 refactor: Replace FlagsOfKnownArg with GetArgFlags (Russell Yanofsky)
57e8b7a727 refactor: Clean up includeconf comments (Russell Yanofsky)
3f7dc9b808 refactor: Clean up long lines in settings code (Russell Yanofsky)

Pull request description:

  This PR doesn't change behavior. It just implements some suggestions from #15934 and #16545 and few other small cleanups.

ACKs for top commit:
  jnewbery:
    Code review ACK e9fd366044
  MarcoFalke:
    ACK e9fd366044 🚟

Tree-SHA512: 6e100d92c72f72bc39567187ab97a3547b3c06e5fcf1a1b74023358b8bca552124ca6a53c0ab53179b7f1329c03d9a73faaef6d73d2cd1a2321568a0286525e2

2019-12-20 03:05:28 +07:00

..

bip32.cpp

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}

2019-02-14 14:00:28 -05:00

bip32.h

Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}

2019-02-14 14:00:28 -05:00

bytevectorhash.cpp

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

bytevectorhash.h

blockfilter: Use unordered_set instead of set in blockfilter.

2018-11-05 09:30:56 -08:00

check.h

util: Add CHECK_NONFATAL and use it in src/rpc

2019-10-18 17:19:36 -04:00

error.cpp

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

error.h

util: Make util/error bilingual_str (refactor)

2019-08-28 15:52:26 -04:00

fees.cpp

util: Add missing headers to util/fees.cpp

2019-11-12 09:30:52 +02:00

fees.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

macros.h

refactor: consolidate PASTE macros

2019-09-25 10:56:00 -04:00

memory.h

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

moneystr.cpp

util: Don't allow ParseMoney(...) of strings with embedded NUL characters

2019-12-16 09:04:35 +00:00

moneystr.h

Remove unused includes

2019-10-15 22:56:43 +00:00

rbf.cpp

[build] Add several util units

2019-04-09 17:53:08 -04:00

rbf.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

settings.cpp

refactor: Remove null setting check in GetSetting()

2019-11-13 15:23:06 -05:00

settings.h

refactor: Clean up long lines in settings code

2019-11-13 04:20:30 -05:00

spanparsing.cpp

Abstract out some of the descriptor Span-parsing helpers

2019-09-18 12:12:13 -07:00

spanparsing.h

Add documenting comments to spanparsing.h

2019-09-18 12:25:55 -07:00

strencodings.cpp

util: Don't allow DecodeBase32(...) of strings with embedded NUL characters

2019-12-16 09:04:36 +00:00

strencodings.h

util: refactor upper/lowercase functions

2019-08-08 11:35:14 +09:00

string.cpp

util: Add Join helper to join a list of strings

2019-08-20 16:51:41 -04:00

string.h

util: Move TrimString(...). Introduce default pattern (trims whitespace). Add NODISCARD.

2019-12-16 22:50:49 +00:00

system.cpp

Merge #17473: refactor: Settings code cleanups

2019-12-20 03:05:28 +07:00

system.h

Merge #17473: refactor: Settings code cleanups

2019-12-20 03:05:28 +07:00

threadnames.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

threadnames.h

Don't rename main thread at process level

2019-10-03 06:58:47 +02:00

time.cpp

Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp

2019-10-27 01:00:05 +03:00

time.h

Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp

2019-10-27 01:00:05 +03:00

translation.h

MOVEONLY: Move key handling code out of wallet to keyman file

2019-10-25 19:20:24 -04:00

url.cpp

[build] Add several util units

2019-04-09 17:53:08 -04:00

url.h

[build] Add several util units

2019-04-09 17:53:08 -04:00

validation.cpp

[validation] Add CValidationState subclasses

2019-10-29 15:46:45 -04:00

validation.h

[validation] Add CValidationState subclasses

2019-10-29 15:46:45 -04:00

vector.h

Add some general std::vector utility functions

2019-10-16 08:56:57 -07:00