MarcoFalke a8fdfea77b Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug ...

724c497562 [fuzz] Add ConsumeAsmap() function (John Newbery)
5840476714 [addrman] Make m_asmap private (John Newbery)
f9002cb5db [net] Rename the copyStats arg from m_asmap to asmap (John Newbery)
f572f2b204 [addrman] Set m_asmap in CAddrMan initializer list (John Newbery)
593247872d [net] Remove CConnMan::SetAsmap() (John Newbery)
50fd77045e [init] Read/decode asmap before constructing addrman (John Newbery)

Pull request description:

  Commit 181a1207 introduced an initialization order bug: CAddrMan's m_asmap must be set before deserializing peers.dat.

  The first commit restores the correct initialization order. The remaining commits make `CAddrMan::m_asmap` usage safer:

  - don't reach into `CAddrMan`'s internal data from `CConnMan`
  - set `m_asmap` in the initializer list and make it const
  - make `m_asmap` private, and access it (as a reference to const) from a getter.

  This ensures that peers.dat deserialization must happen after setting m_asmap, since m_asmap is set during CAddrMan construction.

ACKs for top commit:
  mzumsande:
    Tested ACK 724c497562
  amitiuttarwar:
    code review but utACK 724c497562
  naumenkogs:
    utACK 724c497562
  vasild:
    ACK 724c497562
  MarcoFalke:
    review ACK 724c497562 👫

Tree-SHA512: 684a4cf9e3d4496c9997fb2bc4ec874809987055c157ec3fad1d2143b8223df52b5a0af787d028930b27388c8efeba0aeb2446cb35c337a5552ae76112ade726

2021-09-06 12:41:36 +02:00

..

addition_overflow.cpp

…

addrman.cpp

[fuzz] Add ConsumeAsmap() function

2021-08-27 11:01:45 +01:00

asmap_direct.cpp

…

asmap.cpp

…

autofile.cpp

…

banman.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

base_encode_decode.cpp

fuzz: add missing ECCVerifyHandle to base_encode_decode

2021-06-18 23:13:07 +00:00

bech32.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

fuzz: Avoid timeout in blockfilter fuzz target

2021-08-20 15:45:15 +02:00

bloom_filter.cpp

…

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

Merge bitcoin/bitcoin#22232: refactor: Pass interpreter flags as uint32_t instead of signed int

2021-07-20 15:36:23 +02:00

connman.cpp

[addrman] Set m_asmap in CAddrMan initializer list

2021-08-27 10:55:41 +01:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

cuckoocache.cpp

…

data_stream.cpp

[addrman] Set m_asmap in CAddrMan initializer list

2021-08-27 10:55:41 +01:00

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug

2021-09-06 12:41:36 +02:00

eval_script.cpp

…

fee_rate.cpp

…

fees.cpp

…

flatfile.cpp

…

float.cpp

fuzz: Increase branch coverage of the float fuzz target

2021-06-07 13:41:14 +02:00

fuzz.cpp

…

fuzz.h

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

util: make ParseMoney return a std::optional<CAmount>

2021-08-04 19:48:24 +08:00

key_io.cpp

fuzz: Move CTxDestination fuzzing to script fuzz target

2021-07-04 21:30:50 +02:00

key.cpp

…

kitchen_sink.cpp

make ParseOutputType return a std::optional<OutputType>

2021-08-04 19:20:32 +08:00

load_external_block_file.cpp

refactor: Remove chainparams arg from CChainState member functions

2021-06-13 09:43:54 +02:00

locale.cpp

…

merkleblock.cpp

…

message.cpp

…

muhash.cpp

…

multiplication_overflow.cpp

build: Fix undefined reference to __mulodi4

2021-07-27 14:53:24 +03:00

net_permissions.cpp

…

net.cpp

Merge bitcoin/bitcoin#22791: init: Fix asmap/addrman initialization order bug

2021-09-06 12:41:36 +02:00

netaddress.cpp

fuzz: reduce possible networks check

2021-06-04 16:12:04 +02:00

netbase_dns_lookup.cpp

…

node_eviction.cpp

p2p: remove unused m_is_onion member from NodeEvictionCandidate struct

2021-06-14 13:58:05 +02:00

p2p_transport_serialization.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

util: make ParseMoney return a std::optional<CAmount>

2021-08-04 19:48:24 +08:00

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

pow.cpp

…

prevector.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

primitives_transaction.cpp

…

process_message.cpp

scripted-diff: Revert "fuzz: Add Temporary debug assert for oss-fuzz issue"

2021-07-19 19:12:54 +02:00

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

…

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

Change SignTransaction's input_errors to use bilingual_str

2021-07-01 12:57:53 -04:00

script.cpp

fuzz: Move CTxDestination fuzzing to script fuzz target

2021-07-04 21:30:50 +02:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

make ParseOutputType return a std::optional<OutputType>

2021-08-04 19:20:32 +08:00

strprintf.cpp

…

system.cpp

fuzz: Avoid OOM in system fuzz target

2021-08-06 12:31:28 +02:00

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

…

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

txrequest.cpp

…

util.cpp

Move implementations of non-template fuzz helpers

2021-07-14 18:45:53 +05:30

util.h

Move implementations of non-template fuzz helpers

2021-07-14 18:45:53 +05:30

utxo_snapshot.cpp

…

validation_load_mempool.cpp

fuzz: Initialize a TestingSetup for test_one_input

2021-06-10 15:04:39 -04:00

versionbits.cpp

…