merge-script dfb7d58108 Merge bitcoin/bitcoin#31897: mining: drop unused -nFees and sigops from CBlockTemplate ...

226d81f8b7 mining: drop unused -nFees and sigops from CBlockTemplate (Sjors Provoost)
53ad845fb9 test: check fees and sigops in getblocktemplate (Sjors Provoost)

Pull request description:

  For the coinbase `vTxFees` used a dummy value of -nFees.

  Similarly the first `vTxSigOpsCost` entry was calculated from
  the dummy coinbase transaction.

  This was introduced in #2115, but the values were never returned by the RPC or used in a test.

  Drop 'm and add code comments to prevent confusion.

  This PR also adds test coverage for the `fees` and `sigops` fields in `getblocktemplate`, so it closes #32053.

ACKs for top commit:
  ismaelsadeeq:
    re-ACK 226d81f8b7
  ryanofsky:
    Code review ACK 226d81f8b7. New test was added since last review, which seems very cleanly written and fixes some missing coverage.
  glozow:
    ACK 226d81f8b7

Tree-SHA512: 79c534e6bc4810d29114b04dd6db798877732cb473e773bf3cc28f83d14ee3982392587bd0baa39857bd53a79eae3b730d7a7029b08a9b6c3b5c51f86657ca5d

2025-03-25 08:41:59 -04:00

..

blockchain.cpp

Merge bitcoin/bitcoin#31583: rpc: add target to getmininginfo field and show next block info

2025-01-22 15:01:23 -05:00

blockchain.h

Add target to getblock(header) in RPC and REST

2025-01-22 12:04:02 +01:00

client.cpp

Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity

2024-11-27 12:23:35 -05:00

client.h

refactor: rpc: hide and rename ParseNonRFCJSONValue()

2023-03-23 18:18:46 +00:00

external_signer.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

fees.cpp

[rpc, fees]: add more detail on the fee estimation modes

2024-08-02 15:40:43 +01:00

mempool.cpp

Merge bitcoin/bitcoin#31397: p2p: track and use all potential peers for orphan resolution

2025-01-16 13:42:26 +00:00

mempool.h

rpc: Move mempool RPCs to new file

2022-03-11 17:46:58 +01:00

mining.cpp

mining: drop unused -nFees and sigops from CBlockTemplate

2025-03-13 11:16:57 +01:00

mining.h

rpc: create rpc/mining.h, hoist default max tries values to constant

2020-06-01 15:08:36 +02:00

net.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

node.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

output_script.cpp

refactor: Fix remaining clang-tidy performance-inefficient-vector errors

2024-11-25 20:09:44 +01:00

protocol.h

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

rawtransaction_util.cpp

Merge bitcoin/bitcoin#28307: rpc, wallet: fix incorrect segwit redeem script size limit

2024-06-04 21:39:49 -04:00

rawtransaction_util.h

rpc: bugfix, incorrect segwit redeem script size used in signrawtransactionwithkey

2024-05-03 14:20:45 -03:00

rawtransaction.cpp

scripted-diff: Bump copyright headers after std::span changes

2025-03-12 19:46:54 +01:00

register.h

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

request.cpp

args: Support -norpccookiefile for bitcoind and bitcoin-cli

2024-12-03 10:38:21 +01:00

request.h

Merge bitcoin/bitcoin#28167: init: Add option for rpccookie permissions (replace 26088)

2024-06-27 17:35:08 -04:00

server_util.cpp

rpc: add next to getmininginfo

2025-01-22 12:28:45 +01:00

server_util.h

rpc: add next to getmininginfo

2025-01-22 12:28:45 +01:00

server.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

server.h

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

signmessage.cpp

util: move util/message to common/signmessage

2024-05-16 11:16:08 -04:00

txoutproof.cpp

scripted-diff: rename block and undo functions for consistency

2025-01-09 15:17:02 +01:00

util.cpp

scripted-diff: modernize outdated trait patterns - types

2025-02-21 10:41:27 +01:00

util.h

rpc: add GetTarget helper

2025-01-22 12:04:02 +01:00