mirror of https://github.com/bitcoin/bitcoin.git synced 2025-12-17 08:06:59 +01:00

Files

W. J. van der Laan 907d636e5e Merge bitcoin/bitcoin#21353 : interfaces: Stop exposing wallet destdata to gui

f5ba424cd4 wallet: Add IsAddressUsed / SetAddressUsed methods (Russell Yanofsky)
62252c95e5 interfaces: Stop exposing wallet destdata to gui (Russell Yanofsky)
985430d9b2 test: Add gui test for wallet receive requests (Russell Yanofsky)

Pull request description:

  Stop giving GUI access to destdata rows in database. Replace with narrow API just for saving and reading receive request information.

  This simplifies code and should prevent the GUI from interfering with other destdata like address-used status. It also adds some more GUI test coverage.

  There are no changes in behavior.

ACKs for top commit:
  jarolrod:
    tACK f5ba424cd4
  laanwj:
    Code review ACK f5ba424cd4

Tree-SHA512: 5423df4786e537a59013cb5bfb9e1bc29a7ca4b8835360c00cc2165a59f925fdc355907a4ceb8bca0285bb4946ba235bffa7645537a951ad03fd3b4cee17b6b0

2021-06-03 15:57:30 +02:00

chain.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

echo.cpp

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

echo.h

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

handler.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

handler.h

…

init.cpp

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

init.h

multiprocess: Add echoipc RPC method and test

2021-04-23 03:02:50 -05:00

ipc.h

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

node.h

net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection

2021-03-04 19:54:17 +00:00

README.md

multiprocess: Add comments and documentation

2021-04-23 03:02:50 -05:00

wallet.h

interfaces: Stop exposing wallet destdata to gui

2021-03-03 10:19:35 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #19160.
Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.