highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2025-04-24 23:52:00 +02:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
MarcoFalke 83650e4df5
Merge #20199: wallet: ignore (but warn) on duplicate -wallet parameters 
58cfbc38e040925b51cb8d35d23b50e9cf06fb2a Ignoring (but warn) on duplicate -wallet parameters (Jonas Schnelli)

Pull request description:

  I expect that there are many users with load on startup wallet definitions in `bitcoin.conf` or via startup CLI argument.
  With the new `settings.json` r/w configuration file, users unloading and loading a wallet through the GUI or via the RPC calls might end up with a duplicate `-wallet` entry (one that still remains in bitcoin.conf or CLI) plus the new duplication in `settings.json` due to the unload/load.

  Steps to reproduce
  * create wallet (if via RPC set `load_on_startup` or unloadwallet/loadwallet then set `load_on_startup`).
  * stop bitcoin
  * start bitcoind again with same `--wallet=mywallet`

  I guess it is acceptable to skip duplicates.

ACKs for top commit:
  achow101:
    Tested ACK 58cfbc38e040925b51cb8d35d23b50e9cf06fb2a
  meshcollider:
    Code review ACK 58cfbc38e040925b51cb8d35d23b50e9cf06fb2a
  ryanofsky:
    Code review ACK 58cfbc38e040925b51cb8d35d23b50e9cf06fb2a. Changes since previous review: rebased, tweaked warning message, squashed/fixed test

Tree-SHA512: f94e5a999bdd7dc291f0bc142911b0a8033929350d6f6a35b58c4a06a3c8f83147be0f0c402d4e946dedbbcc85b7e023b672c731b6d7a8984d4780017c961cfb
2020-11-05 07:51:07 +01:00
..
bench
Only relay Taproot spends if next block has it active
2020-10-30 15:52:19 -07:00
compat
…
config
…
consensus
doc: Move assumed-values doxygen comments to header
2020-10-15 11:28:13 +02:00
crc32c
…
crypto
Merge #19845: net: CNetAddr: add support to (un)serialize as ADDRv2
2020-09-28 12:27:08 -07:00
index
Merge #19733: Move comment about BaseIndex::DB from TxIndex::DB
2020-08-21 12:48:46 +08:00
interfaces
[send] Make send RPCs return fee reason
2020-09-26 17:57:26 -07:00
leveldb
…
logging
…
node
style and nits for fee-checking in BroadcastTransaction
2020-10-08 14:11:16 -07:00
policy
Only relay Taproot spends if next block has it active
2020-10-30 15:52:19 -07:00
primitives
Report and verify expirations
2020-10-12 12:14:53 -07:00
qt
Merge #20156: build: Make sqlite support optional (compile-time)
2020-10-29 12:03:36 +01:00
rpc
Merge #20220: wallet, rpc: explicit fee rate follow-ups/fixes for 0.21
2020-11-04 16:35:23 +13:00
script
script: Make ComputeEntrySchnorr and ComputeEntryECDSA const to clarify contract
2020-10-16 06:26:46 +00:00
secp256k1
Update secp256k1 subtree to latest master
2020-10-27 23:08:48 -07:00
support
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
test
Merge #20300: fuzz: Add missing ECC_Start to descriptor_parse test
2020-11-04 20:38:18 +01:00
univalue
…
util
Merge #20080: Strip any trailing / in -datadir and -blocksdir paths
2020-11-02 11:41:38 +13:00
wallet
Merge #20199: wallet: ignore (but warn) on duplicate -wallet parameters
2020-11-05 07:51:07 +01:00
zmq
zmq: Append address to notify log output
2020-10-01 00:33:38 +02:00
.clang-format
tools: clang-format 6 compatibility
2020-07-06 03:52:37 +02:00
addrdb.cpp
p2p: Add ReadAnchors()
2020-10-09 14:29:04 +03:00
addrdb.h
p2p: Add ReadAnchors()
2020-10-09 14:29:04 +03:00
addrman.cpp
[addrman] Specify max addresses and pct when calling GetAddresses()
2020-08-12 09:22:07 +01:00
addrman.h
net: CAddress & CAddrMan: (un)serialize as ADDRv2
2020-10-09 16:42:49 +02:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
Ignore incorrectly-serialized banlist.dat entries
2020-10-12 15:35:08 -07:00
banman.h
Clean up separated ban/discourage interface
2020-07-03 20:43:55 -07:00
base58.cpp
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
base58.h
Merge #19739: refactor: remove c-string interfaces for DecodeBase58{Check}
2020-08-28 16:50:57 +02:00
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli -netinfo: print oversized/extreme ping times as "-"
2020-10-25 16:51:21 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
scripted diff: Improve invalid vout value rpc error message
2020-09-30 20:43:05 +03:30
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
doc: Document that wallet salvage is experimental
2020-10-30 13:53:28 +01:00
bitcoind-res.rc
…
bitcoind.cpp
doc: Update comments for new chain settings (-signet and -chain=signet)
2020-09-22 22:32:25 +02:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
Make CHash256/CHash160 output to Span
2020-07-30 13:57:54 -07:00
blockfilter.h
…
bloom.cpp
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
bloom.h
…
chain.cpp
…
chain.h
chain: Remove UB CChain comparison
2020-08-27 20:07:27 -04:00
chainparams.cpp
Update assumed chain params
2020-11-02 09:22:08 +01:00
chainparams.h
Remove gArgs global from CreateChainParams to aid testing
2020-09-29 10:20:05 +02:00
chainparamsbase.cpp
net: Add alternative port for onion service
2020-09-29 09:59:51 +03:00
chainparamsbase.h
net, refactor: Refactor CBaseChainParams::RPCPort function
2020-09-29 09:59:52 +03:00
chainparamsseeds.h
net: Hardcoded seeds update for 0.21
2020-10-25 14:25:00 +01:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
coins.h
Add CChainState::ResizeCoinsCaches
2020-07-01 14:44:28 -04:00
compat.h
Move Win32 defines to configure.ac to ensure they are globally defined
2020-08-20 17:55:06 +00:00
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
Merge #17775: DecodeHexTx: Try case where txn has inputs first
2020-10-15 10:55:44 +02:00
core_write.cpp
refactor: Avoid duplicate map lookup in ScriptToAsmStr
2020-09-04 10:25:44 +01:00
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
Drop unused CDBWrapper methods
2020-07-08 14:26:14 +03:00
dummywallet.cpp
Merge #19671: wallet: Remove -zapwallettxes
2020-09-01 09:26:28 +08:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
Add missing includes to fix compile errors
2020-06-16 15:15:46 -04:00
fs.h
…
hash.cpp
Add TaggedHash function (BIP 340)
2020-10-12 02:06:32 -07:00
hash.h
Add TaggedHash function (BIP 340)
2020-10-12 02:06:32 -07:00
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
httpserver.h
…
indirectmap.h
…
init.cpp
Merge #19991: net: Use alternative port for incoming Tor connections
2020-10-02 13:37:23 +02:00
init.h
refactor: Create interfaces earlier during initialization
2020-08-27 14:33:00 -04:00
key_io.cpp
…
key_io.h
…
key.cpp
tests: Add fuzzing harness for ec_seckey_import_der(...) and ec_seckey_export_der(...)
2020-08-18 18:03:57 +00:00
key.h
…
logging.cpp
log: remove deprecated db log category
2020-06-07 17:03:49 +02:00
logging.h
…
Makefile.am
Make sqlite support optional (compile-time)
2020-10-20 13:44:43 +00:00
Makefile.bench.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
qt: Pre-splitoff translations update
2020-10-27 19:40:44 +01:00
Makefile.qt.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.qttest.include
Add libsqlite3
2020-10-14 11:18:12 -04:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
Merge #19953: Implement BIP 340-342 validation (Schnorr/taproot/tapscript)
2020-10-15 10:22:35 +02:00
memusage.h
…
merkleblock.cpp
Make Hash[160] consume range-like objects
2020-07-30 13:57:54 -07:00
merkleblock.h
…
miner.cpp
refactor: Remove unused BlockAssembler::pblock member var
2020-06-15 08:08:19 -04:00
miner.h
Remove mapLinks in favor of entry inlined structs with iterator type erasure
2020-09-04 09:46:44 -07:00
net_permissions.cpp
Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
2020-10-12 12:14:53 -07:00
net_permissions.h
Reduce MAX_PEER_TX_ANNOUNCEMENTS for non-PF_RELAY peers
2020-10-12 12:14:53 -07:00
net_processing.cpp
Merge #20212: net: fix output of peer address in version message
2020-11-04 13:41:52 +01:00
net_processing.h
Avoid calling CAddrMan::Connected() on block-relay-only peer addresses
2020-10-27 11:14:58 -04:00
net_types.h
…
net.cpp
Avoid test-before-evict evictions of current peers
2020-10-27 11:15:21 -04:00
net.h
Refactor test for existing peer connection into own function
2020-10-27 11:15:21 -04:00
netaddress.cpp
Merge #20140: Restore compatibility with old CSubNet serialization
2020-10-15 11:44:36 +02:00
netaddress.h
Merge #20140: Restore compatibility with old CSubNet serialization
2020-10-15 11:44:36 +02:00
netbase.cpp
net: change CNetAddr::ip to have flexible size
2020-08-24 21:50:59 +02:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
noui.h
…
optional.h
…
outputtype.cpp
Enable Wswitch for OutputType
2020-07-01 18:03:12 -04:00
outputtype.h
Remove confusing OutputType::CHANGE_AUTO
2020-07-01 18:02:38 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
net: advertise support for ADDRv2 via new message
2020-10-09 16:42:50 +02:00
protocol.h
net: advertise support for ADDRv2 via new message
2020-10-09 16:42:50 +02:00
psbt.cpp
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
psbt.h
psbt: always put a non_witness_utxo and don't remove it
2020-06-24 16:32:19 -04:00
pubkey.cpp
Implement Taproot validation (BIP 341)
2020-10-12 17:17:56 -07:00
pubkey.h
Implement Taproot validation (BIP 341)
2020-10-12 17:17:56 -07:00
random.cpp
Merge #17563: lib: fix a compiler warning: unused GetDevURandom()
2020-08-10 21:30:42 +08:00
random.h
…
randomenv.cpp
random: fixes read buffer resizing in RandAddSeedPerfmon
2020-10-07 20:46:49 -04:00
randomenv.h
…
rest.cpp
Merge #19849: Assert that RPCArg names are equal to CRPCCommand ones (blockchain,rawtransaction)
2020-09-22 17:08:08 +02:00
reverse_iterator.h
…
scheduler.cpp
clang-format scheduler
2020-06-21 06:02:59 -04:00
scheduler.h
clang-format scheduler
2020-06-21 06:02:59 -04:00
serialize.h
Support bypassing range check in ReadCompactSize
2020-10-09 10:32:19 +02:00
shutdown.cpp
…
shutdown.h
…
signet.cpp
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
signet.h
refactor: Remove SignetTxs::m_valid and use optional instead
2020-09-22 22:31:31 +02:00
span.h
Add MakeUCharSpan, to help constructing Span<[const] unsigned char>
2020-07-30 13:57:09 -07:00
streams.h
net: CAddress & CAddrMan: (un)serialize as ADDRv2
2020-10-09 16:42:49 +02:00
sync.cpp
sync.h: Make runtime lock checks require compile-time lock checks
2020-08-29 20:46:47 +03:00
sync.h
Remove unused LockAssertion struct
2020-09-19 18:02:42 +03:00
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
Drop deprecated and unused GUARDED_VAR and PT_GUARDED_VAR annotations
2020-08-18 10:46:53 +03:00
timedata.cpp
Avoid the use of abs64 in timedata
2020-10-12 19:50:16 -07:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Merge #19954: Complete the BIP155 implementation and upgrade to TORv3
2020-10-11 08:51:57 +08:00
torcontrol.h
net: Pass onion service target to Tor controller
2020-10-01 19:00:07 +03:00
txdb.cpp
Merge #18637: coins: allow cache resize after init
2020-07-29 07:53:19 +02:00
txdb.h
txdb: add CCoinsViewDB::ChangeCacheSize
2020-07-01 14:44:24 -04:00
txmempool.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
txmempool.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
txrequest.cpp
p2p: declare Announcement::m_state as uint8_t, add getter/setter
2020-10-16 23:33:44 +02:00
txrequest.h
Report and verify expirations
2020-10-12 12:14:53 -07:00
uint256.cpp
Add txrequest module
2020-10-12 11:01:16 -07:00
uint256.h
Add txrequest module
2020-10-12 11:01:16 -07:00
undo.h
…
validation.cpp
Only relay Taproot spends if next block has it active
2020-10-30 15:52:19 -07:00
validation.h
[validation] Remove absurdfee from accepttomempool
2020-10-05 04:55:01 -07:00
validationinterface.cpp
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
validationinterface.h
Add 'sequence' zmq publisher to track all block (dis)connects, mempool deltas
2020-09-22 11:34:30 -04:00
version.h
net: CNetAddr: add support to (un)serialize as ADDRv2
2020-09-17 22:17:17 +02:00
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
Activate Taproot/Tapscript on regtest (BIP 341, BIP 342)
2020-10-12 17:18:47 -07:00
versionbitsinfo.h
…
walletinitinterface.h
refactor: add unused ArgsManager to replace gArgs
2020-07-29 16:36:44 +07:00
warnings.cpp
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00
warnings.h
Make SetMiscWarning() accept bilingual_str argument
2020-06-10 15:01:20 +03:00