W. J. van der Laan c006ab29ce

Merge bitcoin/bitcoin#23219: p2p, refactor: tidy up LookupSubNet() ...

c44c20108f7b7314f59f034110789385a24db280 p2p, refactor: drop unused DNSLookupFn param in LookupSubnet() (Vasil Dimov)
f0c9e68080432c1ab11b14e571b8dfb7cfe727f8 p2p, refactor: tidy up LookupSubNet() (Jon Atack)

Pull request description:

  This pull originally resolved a code `TO-DO`, as well as fixing different param names between the function declaration and definition, updating the function to current style standards, clearer variable naming, and improving the Doxygen documentation.

  Following the merge of #17160, it now does the non-`TODO` changes and also now drops an unused param to simplify the function.

ACKs for top commit:
  dunxen:
    ACK c44c201
  vasild:
    ACK c44c20108f7b7314f59f034110789385a24db280
  shaavan:
    crACK c44c20108f7b7314f59f034110789385a24db280

Tree-SHA512: 55f64c7f403819dec84f4da06e63db50f7c0601a2d9a1ec196fda667c220ec6f5ad2a3c95e0e02275da9f6da6b984275d1dc10e19ed82005c5e13da5c5ecab02

2021-12-18 15:56:24 +01:00

..

addition_overflow.cpp

…

addrman.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

asmap_direct.cpp

…

asmap.cpp

More Span simplifications

2021-11-29 17:59:44 -05:00

autofile.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

banman.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

base_encode_decode.cpp

…

bech32.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

fuzz: Avoid timeout in blockfilter fuzz target

2021-08-20 15:45:15 +02:00

bloom_filter.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

buffered_file.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

chain.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

checkqueue.cpp

…

coins_view.cpp

policy: Treat taproot as always active

2021-11-16 08:20:33 +01:00

connman.cpp

Merge bitcoin/bitcoin#23636: Remove GetAdjustedTime from init.cpp

2021-12-02 15:24:55 +01:00

crypto_aes256.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_aes256cbc.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_chacha20_poly1305_aead.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_chacha20.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_common.cpp

…

crypto_diff_fuzz_chacha20.cpp

Refactor the chacha20 differential fuzz test

2021-12-17 23:04:04 +05:30

crypto_hkdf_hmac_sha256_l32.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

crypto_poly1305.cpp

…

crypto.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

cuckoocache.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

eval_script.cpp

…

fee_rate.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

fees.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

FuzzedDataProvider.h

…

golomb_rice.cpp

Remove unused (and broken) functionality in SpanReader

2021-12-06 16:18:14 -05:00

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

fuzz: Move ISO8601 to one place

2021-12-10 13:58:55 +01:00

key_io.cpp

fuzz: Move CTxDestination fuzzing to script fuzz target

2021-07-04 21:30:50 +02:00

key.cpp

…

kitchen_sink.cpp

make ParseOutputType return a std::optional<OutputType>

2021-08-04 19:20:32 +08:00

load_external_block_file.cpp

…

locale.cpp

Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)

2021-09-30 14:21:17 +00:00

merkleblock.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

message.cpp

…

minisketch.cpp

fuzz: Add minisketch fuzz test

2021-11-16 19:18:05 +01:00

muhash.cpp

fuzz: Cleanup muhash fuzz target

2021-09-22 10:39:08 +02:00

multiplication_overflow.cpp

build: Fix undefined reference to __mulodi4

2021-07-27 14:53:24 +03:00

net_permissions.cpp

…

net.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

netaddress.cpp

…

netbase_dns_lookup.cpp

p2p, refactor: drop unused DNSLookupFn param in LookupSubnet()

2021-12-07 13:13:18 +01:00

node_eviction.cpp

scripted-diff: Rename touched member variables

2021-12-13 13:32:08 +01:00

p2p_transport_serialization.cpp

[net] Don't return an optional from TransportDeserializer::GetMessage()

2021-08-19 18:20:12 +01:00

parse_hd_keypath.cpp

…

parse_iso8601.cpp

fuzz: Move ISO8601 to one place

2021-12-10 13:58:55 +01:00

parse_numbers.cpp

Merge bitcoin/bitcoin#23156: refactor: Remove unused ParsePrechecks and ParseDouble

2021-10-04 15:06:37 +02:00

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

pow.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

prevector.cpp

fuzz: Use LIMITED_WHILE instead of limit_max_ops

2021-08-21 19:25:33 +02:00

primitives_transaction.cpp

…

process_message.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

process_messages.cpp

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

rolling_bloom_filter.cpp

scripted-diff: Move bloom to src/common

2021-10-05 11:10:37 +02:00

rpc.cpp

fuzz: Fix RPC internal bug detection

2021-12-08 14:20:16 +01:00

script_assets_test_minimizer.cpp

Remove unused (and broken) functionality in SpanReader

2021-12-06 16:18:14 -05:00

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

script_flags.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

script_interpreter.cpp

…

script_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

script_sigcache.cpp

…

script_sign.cpp

moveonly: Move (Un)Serialize(To/From)Vector, (De)SerializeHDKeypaths to psbt module

2021-12-10 08:29:47 -05:00

script.cpp

scripted-diff: Use clang-tidy syntax for C++ named arguments

2021-11-19 12:41:47 +01:00

scriptnum_ops.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

fuzz: Rework ConsumeScript

2021-11-01 12:25:29 +01:00

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)

2021-09-30 14:21:17 +00:00

strprintf.cpp

…

system.cpp

fuzz: Fix memory leak in system fuzz target

2021-09-29 13:24:14 +02:00

timedata.cpp

…

torcontrol.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00

transaction.cpp

Merge bitcoin/bitcoin#23546: scripted-diff: Use clang-tidy syntax for C++ named arguments (tests only)

2021-12-01 18:44:54 +08:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

Remove CTxMemPool params from ATMP

2021-12-07 18:56:29 -03:00

txrequest.cpp

Make GenTxid boolean constructor private

2021-10-22 12:32:16 +02:00

util.cpp

fuzz: Rework FillNode

2021-12-01 12:15:08 +01:00

util.h

refactor: Set fSuccessfullyConnected in FillNode

2021-12-01 12:15:01 +01:00

utxo_snapshot.cpp

Merge bitcoin/bitcoin#23413: Replace MakeSpan helper with Span deduction guide

2021-12-03 10:44:37 +01:00

validation_load_mempool.cpp

…

versionbits.cpp

fuzz: replace every fuzzer-controlled loop with a LIMITED_WHILE loop

2021-11-12 19:51:55 +00:00