highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-24 22:45:41 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
6cd1e0f3416fc88240eb37a99a56d2900292f1c0
bitcoin/src
History
fanquake 09ad512369 Merge bitcoin/bitcoin#23628: Check descriptors returned by external signers 
5493e92501 Check descriptors returned by external signers (sstone)

Pull request description:

  Check that descriptors returned by external signers have been parsed properly when creating a new wallet.
  See https://github.com/bitcoin/bitcoin/issues/23627 for context.

  The problem is that parsing an invalid descriptor will return `null` which is not checked for in `CWallet::SetupDescriptorScriptPubKeyMans()`.

  I'm not completely sure what the best fix is since there several strategies for dealing with errors in the current codebase but the proposed fix is very simple and consistent with other validation checks in `CWallet::SetupDescriptorScriptPubKeyMans()`.

ACKs for top commit:
  jamesob:
    Code review ACK 5493e92501
  achow101:
    ACK 5493e92501

Tree-SHA512: 63259f4aa519405a86c554b6813efdb741314bdaa18bf005b70ea8bb92a27abc6e2b65f7c584641dc257fc78a6499f42b51b5310c243e611c4663430dccf3d04
2021-12-10 09:17:35 +08:00
..
bench
Merge bitcoin/bitcoin#22019: wallet: Introduce SelectionResult for encapsulating a coin selection solution
2021-12-09 17:21:46 +01:00
common
scripted-diff: Move bloom to src/common
2021-10-05 11:10:37 +02:00
compat
compat: remove glibc_compat.cpp
2021-09-10 11:18:58 +08:00
config
…
consensus
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
crc32c
Update crc32c subtree
2021-09-29 14:10:29 +02:00
crypto
Fix K1/K2 use in the comments in ChaCha20-Poly1305 AEAD
2021-10-20 11:54:03 +05:30
index
Fix outdated comments referring to ::ChainActive()
2021-10-12 14:36:51 +13:00
init
Merge bitcoin/bitcoin#23006: multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations
2021-10-26 15:54:52 +01:00
interfaces
wallet: Replace confusing getAdjustedTime() with GetTime()
2021-12-01 16:26:11 +01:00
ipc
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
leveldb
…
logging
log, timer: add LOG_TIME_MILLIS_WITH_CATEGORY_MSG_ONCE macro
2021-10-05 17:28:02 +02:00
minisketch
Merge commit 'b6487dc4ef47ec9ea894eceac25f37d0b806f8aa' as 'src/minisketch'
2021-10-21 09:36:07 +08:00
node
mining, refactor: add m_mempool.cs thread safety lock assertions
2021-12-07 15:01:43 +01:00
policy
Merge bitcoin/bitcoin#23413: Replace MakeSpan helper with Span deduction guide
2021-12-03 10:44:37 +01:00
primitives
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
qt
qt: Handle Android back key in the Node window
2021-12-03 01:03:30 +02:00
rpc
Merge bitcoin/bitcoin#23703: scripted-diff: Use named args in RPC docs
2021-12-09 17:14:26 +08:00
script
More Span simplifications
2021-11-29 17:59:44 -05:00
secp256k1
…
support
refactor: remove references to deprecated values under std::allocator
2021-10-20 18:36:40 -04:00
test
fuzz: Fix RPC internal bug detection
2021-12-08 14:20:16 +01:00
univalue
Update univalue subtree to latest upstream
2021-10-11 20:45:56 +08:00
util
fuzz: Fix RPC internal bug detection
2021-12-08 14:20:16 +01:00
wallet
Merge bitcoin/bitcoin#23628: Check descriptors returned by external signers
2021-12-10 09:17:35 +08:00
zmq
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
.clang-format
Use c++17 in clang-format
2021-11-12 11:46:34 +01:00
.clang-tidy
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
addrdb.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
addrdb.h
scripted-diff: Rename CAddrMan to AddrMan
2021-09-28 22:21:10 -04:00
addrman_impl.h
Merge bitcoin/bitcoin#22872: log: improve checkaddrman logging with duration in milliseconds
2021-11-10 17:38:45 +01:00
addrman.cpp
Merge bitcoin/bitcoin#22872: log: improve checkaddrman logging with duration in milliseconds
2021-11-10 17:38:45 +01:00
addrman.h
[addrman] Remove AddrMan friends
2021-11-09 17:09:50 +00:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
base58.cpp
Replace MakeSpan helper with Span deduction guide
2021-11-29 17:58:53 -05:00
base58.h
…
bech32.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bech32.h
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
cli: hoist networks class data members to a constant
2021-11-11 13:14:01 +01:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
bitcoin-tx: Reject non-integral and out of range multisig numbers
2021-10-12 12:45:55 +02:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Merge bitcoin/bitcoin#23346: util, refactor: Improve headers for bitcoin-wallet tool
2021-12-09 13:44:24 +01:00
bitcoind-res.rc
…
bitcoind.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
blockfilter.h
…
chain.cpp
doc: Tidy up nMinDiskSpace comment
2021-11-26 11:17:43 +01:00
chain.h
Merge bitcoin/bitcoin#13875: [doc] nChainTx needs to become a 64-bit earlier due to SegWit
2021-10-20 15:52:08 +02:00
chainparams.cpp
Use absolute FQDN for DNS seed domains
2021-10-14 17:49:52 +05:30
chainparams.h
…
chainparamsbase.cpp
scripted-diff: disable unimplemented ArgsManager BOOL/INT/STRING flags
2021-10-25 10:44:17 -04:00
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
Exit early for an empty vChecks in CCheckQueue::Add
2021-11-03 11:26:57 +02:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
[tracing] tracepoints to utxocache add, spent and uncache
2021-11-28 11:51:21 +05:30
coins.h
…
compat.h
…
compressor.cpp
…
compressor.h
Replace MakeSpan helper with Span deduction guide
2021-11-29 17:58:53 -05:00
core_io.h
rpc: Add level 3 verbosity to getblock RPC call.
2021-10-05 10:42:34 +02:00
core_memusage.h
…
core_read.cpp
bitcoin-tx: Avoid treating overflow as OP_0
2021-10-11 09:17:28 +02:00
core_write.cpp
core_write: Rename calculate_fee to have_undo for clarity
2021-10-05 10:42:34 +02:00
cuckoocache.h
refactor: Fix implicit-signed-integer-truncation in cuckoocache.h
2021-11-29 14:32:51 +01:00
dbwrapper.cpp
Improve fs::PathToString documentation
2021-11-15 12:08:49 -05:00
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
Remove -rescan startup parameter
2021-09-30 12:06:27 +13:00
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
flatfile.h
…
fs.cpp
refactor: include a missing <limits> header in fs.cpp
2021-10-22 04:03:45 +03:00
fs.h
Improve fs::PathToString documentation
2021-11-15 12:08:49 -05:00
hash.cpp
refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization
2021-10-05 23:53:33 +02:00
hash.h
…
httprpc.cpp
…
httprpc.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
httpserver.cpp
Merge bitcoin/bitcoin#20487: Add syscall sandboxing using seccomp-bpf (Linux secure computing mode)
2021-10-04 22:45:43 +02:00
httpserver.h
…
i2p.cpp
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
i2p.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
indirectmap.h
…
init.cpp
Remove GetAdjustedTime from init.cpp
2021-11-30 17:19:49 +01:00
init.h
…
key_io.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
key_io.h
Add Bech32 error location function
2021-10-12 12:03:14 +13:00
key.cpp
Make signing follow BIP340 exactly w.r.t. aux randomness
2021-11-12 12:04:20 -05:00
key.h
Make signing follow BIP340 exactly w.r.t. aux randomness
2021-11-12 12:04:20 -05:00
logging.cpp
blockstorage: use debug log category
2021-10-11 21:45:49 +10:00
logging.h
blockstorage: use debug log category
2021-10-11 21:45:49 +10:00
Makefile.am
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
Makefile.bench.include
…
Makefile.crc32c.include
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
Makefile.leveldb.include
build: remove build stubs for external leveldb
2021-10-15 01:02:45 +00:00
Makefile.minisketch.include
build: add minisketch build file and include it
2021-10-21 09:37:30 +08:00
Makefile.qt_locale.include
…
Makefile.qt.include
build: Fix make apk if ccache enabled
2021-11-08 07:19:10 +02:00
Makefile.qttest.include
multiprocess: Add new bitcoin-gui, bitcoin-qt, bitcoin-wallet init implementations
2021-09-16 13:17:01 -05:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
move-only: unittest: add test/util/chainstate.h
2021-09-15 15:46:48 -04:00
Makefile.test.include
Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe
2021-11-25 19:41:53 +01:00
Makefile.univalue.include
Integrate univalue into our buildsystem
2021-10-11 20:46:25 +08:00
mapport.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
style: Sort
2021-10-05 11:11:18 +02:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
net_processing.h
rpc: getblockfrompeer
2021-12-02 13:16:18 +07:00
net_types.cpp
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#23413: Replace MakeSpan helper with Span deduction guide
2021-12-03 10:44:37 +01:00
net.h
Replace addrman.h include with forward decl in net.h
2021-11-30 14:46:16 +01:00
netaddress.cpp
More Span simplifications
2021-11-29 17:59:44 -05:00
netaddress.h
Replace MakeSpan helper with Span deduction guide
2021-11-29 17:58:53 -05:00
netbase.cpp
Merge bitcoin/bitcoin#17160: refactor: net: subnet lookup: use single-result LookupHost()
2021-12-06 19:59:35 +01:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
protocol.h
…
psbt.cpp
Merge bitcoin/bitcoin#22513: rpc: Allow walletprocesspsbt to sign without finalizing
2021-11-29 17:20:20 +01:00
psbt.h
Replace MakeSpan helper with Span deduction guide
2021-11-29 17:58:53 -05:00
pubkey.cpp
refactor: use {Read,Write}BE32 helpers for BIP32 nChild (de)serialization
2021-10-05 23:53:33 +02:00
pubkey.h
More Span simplifications
2021-11-29 17:59:44 -05:00
random.cpp
…
random.h
…
randomenv.cpp
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
randomenv.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
rest.cpp
rpc: move Ensure* helpers to server_util.h
2021-12-02 13:15:32 +07:00
reverse_iterator.h
…
scheduler.cpp
Add syscall sandboxing (seccomp-bpf)
2021-10-01 13:51:10 +00:00
scheduler.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
serialize.h
…
shutdown.cpp
…
shutdown.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
signet.cpp
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
signet.h
…
span.h
More Span simplifications
2021-11-29 17:59:44 -05:00
streams.h
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
sync.cpp
log: Avoid broken DEBUG_LOCKORDER log
2021-09-29 18:46:30 +02:00
sync.h
sync: inline lock contention logging macro to fix time duration
2021-09-06 23:43:51 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
threadsafety.h
…
timedata.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
Remove strtol in torcontrol
2021-11-18 18:13:21 +01:00
torcontrol.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00
txdb.cpp
scripted-diff: Rename overloaded int GetArg to GetIntArg
2021-09-27 06:57:20 -04:00
txdb.h
…
txmempool.cpp
clean up txmempool includes
2021-12-02 14:49:19 +00:00
txmempool.h
clean up txmempool includes
2021-12-02 14:49:19 +00:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
Make GenTxid boolean constructor private
2021-10-22 12:32:16 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
validation.h
Merge bitcoin/bitcoin#23465: Remove CTxMemPool params from ATMP
2021-12-08 10:00:55 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
doc: Fix typos in endif header comments
2021-11-16 09:56:45 +01:00