highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-05-24 12:54:07 +02:00
Code Issues Packages Projects Releases Wiki Activity
Files
6cd1e0f3416fc88240eb37a99a56d2900292f1c0
bitcoin/src
History
fanquake 09ad512369 Merge bitcoin/bitcoin#23628: Check descriptors returned by external signers 
5493e92501 Check descriptors returned by external signers (sstone)

Pull request description:

  Check that descriptors returned by external signers have been parsed properly when creating a new wallet.
  See https://github.com/bitcoin/bitcoin/issues/23627 for context.

  The problem is that parsing an invalid descriptor will return `null` which is not checked for in `CWallet::SetupDescriptorScriptPubKeyMans()`.

  I'm not completely sure what the best fix is since there several strategies for dealing with errors in the current codebase but the proposed fix is very simple and consistent with other validation checks in `CWallet::SetupDescriptorScriptPubKeyMans()`.

ACKs for top commit:
  jamesob:
    Code review ACK 5493e92501
  achow101:
    ACK 5493e92501

Tree-SHA512: 63259f4aa519405a86c554b6813efdb741314bdaa18bf005b70ea8bb92a27abc6e2b65f7c584641dc257fc78a6499f42b51b5310c243e611c4663430dccf3d04
2021-12-10 09:17:35 +08:00
..
bench
Merge bitcoin/bitcoin#22019: wallet: Introduce SelectionResult for encapsulating a coin selection solution
2021-12-09 17:21:46 +01:00
common
…
compat
…
config
…
consensus
…
crc32c
…
crypto
…
index
…
init
…
interfaces
…
ipc
…
leveldb
…
logging
…
minisketch
…
node
mining, refactor: add m_mempool.cs thread safety lock assertions
2021-12-07 15:01:43 +01:00
policy
…
primitives
…
qt
…
rpc
Merge bitcoin/bitcoin#23703: scripted-diff: Use named args in RPC docs
2021-12-09 17:14:26 +08:00
script
…
secp256k1
…
support
…
test
fuzz: Fix RPC internal bug detection
2021-12-08 14:20:16 +01:00
univalue
…
util
fuzz: Fix RPC internal bug detection
2021-12-08 14:20:16 +01:00
wallet
Merge bitcoin/bitcoin#23628: Check descriptors returned by external signers
2021-12-10 09:17:35 +08:00
zmq
…
.clang-format
…
.clang-tidy
…
addrdb.cpp
…
addrdb.h
…
addrman_impl.h
…
addrman.cpp
…
addrman.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
…
banman.h
…
base58.cpp
…
base58.h
…
bech32.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bech32.h
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
…
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
…
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Merge bitcoin/bitcoin#23346: util, refactor: Improve headers for bitcoin-wallet tool
2021-12-09 13:44:24 +01:00
bitcoind-res.rc
…
bitcoind.cpp
…
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
blockfilter.h
…
chain.cpp
…
chain.h
…
chainparams.cpp
…
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
…
coins.h
…
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
…
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
…
external_signer.h
…
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
…
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
…
init.h
…
key_io.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
key_io.h
…
key.cpp
…
key.h
…
logging.cpp
…
logging.h
…
Makefile.am
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
Makefile.bench.include
…
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
…
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
…
Makefile.univalue.include
…
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
net_processing.h
…
net_types.cpp
…
net_types.h
…
net.cpp
…
net.h
…
netaddress.cpp
…
netaddress.h
…
netbase.cpp
Merge bitcoin/bitcoin#17160: refactor: net: subnet lookup: use single-result LookupHost()
2021-12-06 19:59:35 +01:00
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
…
psbt.cpp
…
psbt.h
…
pubkey.cpp
…
pubkey.h
…
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
…
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
…
shutdown.cpp
…
shutdown.h
…
signet.cpp
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
signet.h
…
span.h
…
streams.h
Remove unused (and broken) functionality in SpanReader
2021-12-06 16:18:14 -05:00
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
…
torcontrol.h
…
txdb.cpp
…
txdb.h
…
txmempool.cpp
…
txmempool.h
…
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
…
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#20295: rpc: getblockfrompeer
2021-12-08 10:39:37 +01:00
validation.h
Merge bitcoin/bitcoin#23465: Remove CTxMemPool params from ATMP
2021-12-08 10:00:55 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…