Ava Chow 592e01398e Merge bitcoin/bitcoin#28833: wallet: refactor: remove unused SignatureData instances in spkm's FillPSBT methods ...

e2ad343f69 wallet: remove unused `SignatureData` instances in spkm's `FillPSBT` methods (Sebastian Falbesoner)

Pull request description:

  These are filled with signature data from a PSBT input, but not used anywhere after, hence they can be removed. Note that the same code is in the `SignPSBTInput` function where the `sigdata` result is indeed used.

ACKs for top commit:
  achow101:
    ACK e2ad343f69
  brunoerg:
    crACK e2ad343f69

Tree-SHA512: f0cabcc000bcea6bc7d7ec9d3be2e2a8accbdbffbe35252250ea2305b65a5813fde2b8096fbdd2c7cccdf417ea285183dc325fc2d210d88bce62978ce642930e

2024-02-06 13:35:41 -05:00

..

bench

Merge bitcoin/bitcoin#26684: bench: add readblock benchmark

2024-01-02 11:12:32 -05:00

common

init: settings, do not load auto-generated warning msg

2024-01-23 21:01:32 -03:00

compat

…

config

…

consensus

…

crc32c

…

crypto

Merge bitcoin/bitcoin#29180: crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256

2024-01-26 18:56:41 -05:00

index

refactor: Remove calls to StartShutdown from KernelNotifications

2023-12-04 15:39:15 -04:00

init

doc: add unconditional info loglevel following merge of PR 28318

2024-01-11 11:01:28 -06:00

interfaces

Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion

2024-01-05 10:42:10 +00:00

ipc

…

kernel

Merge bitcoin/bitcoin#29254: log: Don't use scientific notation in log messages

2024-02-05 14:21:10 +00:00

leveldb

…

logging

…

minisketch

…

node

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

policy

Don't use scientific notation in log messages

2024-01-31 21:20:05 +02:00

primitives

…

qt

Merge bitcoin-core/gui#789: Avoid non-self-contained Windows header

2024-01-26 20:40:46 +00:00

rpc

Merge bitcoin/bitcoin#29356: test: make v2transport arg in addconnection mandatory and few cleanups

2024-02-06 11:02:36 +00:00

script

wallet: fix key parsing check for miniscript expressions in ParseScript

2023-12-08 06:54:00 -03:00

secp256k1

Update secp256k1 subtree to latest master

2024-01-04 14:40:28 +00:00

support

…

test

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

univalue

…

util

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

wallet

Merge bitcoin/bitcoin#28833: wallet: refactor: remove unused SignatureData instances in spkm's FillPSBT methods

2024-02-06 13:35:41 -05:00

zmq

Remove deprecated -rpcserialversion

2023-12-11 18:22:13 +01:00

.bear-tidy-config

…

.clang-format

refactor: Print verbose serialize compiler error messages

2023-12-15 15:20:54 +01:00

.clang-tidy

…

addrdb.cpp

…

addrdb.h

…

addresstype.cpp

…

addresstype.h

…

addrman_impl.h

…

addrman.cpp

Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check

2023-12-06 11:22:42 -05:00

addrman.h

doc, test: Test and explain service flag handling

2024-01-15 16:19:53 -05:00

arith_uint256.cpp

…

arith_uint256.h

…

attributes.h

…

banman.cpp

…

banman.h

…

base58.cpp

…

base58.h

…

bech32.cpp

…

bech32.h

…

bip324.cpp

…

bip324.h

…

bitcoin-chainstate.cpp

Remove GetAdjustedTime

2024-01-05 17:16:38 +00:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

Fix -netinfo backward compat with getpeerinfo pre-v26

2024-01-09 15:27:08 -06:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

doc: Update bitcoin-tx replaceable documentation

2023-12-11 13:08:46 -05:00

bitcoin-util-res.rc

…

bitcoin-util.cpp

…

bitcoin-wallet-res.rc

…

bitcoin-wallet.cpp

…

bitcoind-res.rc

…

bitcoind.cpp

Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly

2023-12-04 15:39:15 -04:00

blockencodings.cpp

…

blockencodings.h

…

blockfilter.cpp

…

blockfilter.h

…

chain.cpp

…

chain.h

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

chainparams.cpp

…

chainparams.h

…

chainparamsbase.cpp

…

chainparamsbase.h

…

chainparamsseeds.h

…

checkqueue.h

…

clientversion.cpp

…

clientversion.h

…

coins.cpp

…

coins.h

…

compressor.cpp

…

compressor.h

…

core_io.h

Remove deprecated -rpcserialversion

2023-12-11 18:22:13 +01:00

core_memusage.h

…

core_read.cpp

…

core_write.cpp

Remove deprecated -rpcserialversion

2023-12-11 18:22:13 +01:00

cuckoocache.h

…

dbwrapper.cpp

…

dbwrapper.h

…

deploymentinfo.cpp

…

deploymentinfo.h

…

deploymentstatus.cpp

…

deploymentstatus.h

…

dummywallet.cpp

…

external_signer.cpp

…

external_signer.h

…

flatfile.cpp

…

flatfile.h

…

hash.cpp

crypto, hash: replace custom rotl32 with std::rotl

2024-01-05 17:12:38 +01:00

hash.h

…

headerssync.cpp

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

headerssync.h

…

httprpc.cpp

…

httprpc.h

…

httpserver.cpp

Merge bitcoin/bitcoin#28318: logging: Simplify API for level based logging

2024-01-10 14:11:32 -05:00

httpserver.h

refactor: Remove call to ShutdownRequested from HTTPRequest

2023-12-04 15:39:15 -04:00

i2p.cpp

net: create I2P sessions with both ECIES-X25519 and ElGamal encryption

2024-01-07 16:24:08 -06:00

i2p.h

…

indirectmap.h

…

init.cpp

Merge bitcoin/bitcoin#28956: Nuke adjusted time from validation (attempt 2)

2024-01-31 15:58:47 -05:00

init.h

Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly

2023-12-04 15:39:15 -04:00

key_io.cpp

refactor: Allow std::span construction from CKey

2024-01-16 15:29:18 +01:00

key_io.h

…

key.cpp

refactor: Allow std::span construction from CKey

2024-01-16 15:29:18 +01:00

key.h

refactor: Allow std::span construction from CKey

2024-01-16 15:29:18 +01:00

logging.cpp

logging: add -loglevelalways=1 option

2023-12-15 11:03:25 +10:00

logging.h

logging: add LogError, LogWarning, LogInfo, LogDebug, LogTrace

2023-12-20 15:59:48 +10:00

Makefile.am

Merge bitcoin/bitcoin#29180: crypto: remove use of BUILD_BITCOIN_INTERNAL macro in sha256

2024-01-26 18:56:41 -05:00

Makefile.bench.include

Merge bitcoin/bitcoin#26684: bench: add readblock benchmark

2024-01-02 11:12:32 -05:00

Makefile.crc32c.include

…

Makefile.leveldb.include

…

Makefile.minisketch.include

…

Makefile.qt_locale.include

…

Makefile.qt.include

…

Makefile.qttest.include

…

Makefile.test_fuzz.include

…

Makefile.test_util.include

…

Makefile.test.include

Merge bitcoin/bitcoin#28170: p2p: adaptive connections services flags

2024-01-31 11:44:41 -05:00

Makefile.univalue.include

…

mapport.cpp

…

mapport.h

…

memusage.h

…

merkleblock.cpp

…

merkleblock.h

…

net_permissions.cpp

…

net_permissions.h

…

net_processing.cpp

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

net_processing.h

net: move state dependent peer services flags

2024-01-15 10:28:20 -03:00

net_types.cpp

…

net_types.h

…

net.cpp

Merge bitcoin/bitcoin#28170: p2p: adaptive connections services flags

2024-01-31 11:44:41 -05:00

net.h

Merge bitcoin/bitcoin#29347: net: enable v2transport by default

2024-01-31 15:33:57 -05:00

netaddress.cpp

…

netaddress.h

fuzz: extend ConsumeNetAddr() to return I2P and CJDNS addresses

2024-01-23 11:49:32 +01:00

netbase.cpp

…

netbase.h

…

netgroup.cpp

Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check

2023-12-06 11:22:42 -05:00

netgroup.h

net: Add continuous ASMap health check logging

2023-12-02 22:03:08 +01:00

netmessagemaker.h

…

noui.cpp

…

noui.h

…

outputtype.cpp

…

outputtype.h

…

pow.cpp

…

pow.h

…

prevector.h

refactor: Mark prevector iterator with std::contiguous_iterator_tag

2024-01-18 19:29:34 +01:00

protocol.cpp

net: remove now unused global 'g_initial_block_download_completed'

2024-01-23 10:25:16 -03:00

protocol.h

net: remove now unused global 'g_initial_block_download_completed'

2024-01-23 10:25:16 -03:00

psbt.cpp

…

psbt.h

…

pubkey.cpp

…

pubkey.h

Add missing XOnlyPubKey::data() to get mutable data

2024-01-16 10:58:57 +01:00

random.cpp

…

random.h

…

randomenv.cpp

…

randomenv.h

…

rest.cpp

Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion

2024-01-05 10:42:10 +00:00

rest.h

…

reverse_iterator.h

…

scheduler.cpp

…

scheduler.h

…

serialize.h

Allow std::byte C-style array serialization

2023-12-15 15:21:22 +01:00

signet.cpp

…

signet.h

…

span.h

refactor: Print verbose serialize compiler error messages

2023-12-15 15:20:54 +01:00

streams.cpp

…

streams.h

…

sync.cpp

…

sync.h

…

threadsafety.h

…

timedata.cpp

Remove GetAdjustedTime

2024-01-05 17:16:38 +00:00

timedata.h

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

tinyformat.h

…

torcontrol.cpp

Merge bitcoin/bitcoin#28318: logging: Simplify API for level based logging

2024-01-10 14:11:32 -05:00

torcontrol.h

…

txdb.cpp

…

txdb.h

…

txmempool.cpp

refactor: remove CTxMemPool::queryHashes()

2024-01-18 21:54:56 +00:00

txmempool.h

refactor: remove CTxMemPool::queryHashes()

2024-01-18 21:54:56 +00:00

txorphanage.cpp

fuzz: Improve fuzzing stability for txorphan harness

2023-12-08 13:14:46 +00:00

txorphanage.h

fuzz: Improve fuzzing stability for txorphan harness

2023-12-08 13:14:46 +00:00

txrequest.cpp

refactor: modernize-use-default-member-init for bit-fields (C++20)

2023-12-07 11:06:01 +01:00

txrequest.h

…

uint256.cpp

…

uint256.h

…

undo.h

…

validation.cpp

refactor: Fix timedata includes

2024-02-01 13:52:05 +01:00

validation.h

Remove GetAdjustedTime

2024-01-05 17:16:38 +00:00

validationinterface.cpp

…

validationinterface.h

doc: fix typo and update incorrect comment

2024-01-02 12:40:11 +01:00

versionbits.cpp

…

versionbits.h

…

walletinitinterface.h

…

warnings.cpp

…

warnings.h

…