highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 06:43:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
6f9db1ebcab4064065ccd787161bf2b87e03cc1f
bitcoin/src
History
Ava Chow 6f9db1ebca Merge bitcoin/bitcoin#30357: Fix cases of calls to FillPSBT errantly returning complete=true 
7e36dca657 test: add test for modififed walletprocesspsbt calls (willcl-ark)
39cea21ec5 wallet: fix FillPSBT errantly showing as complete (willcl-ark)

Pull request description:

  Fixes: #30077

  Fix cases of calls to `FillPSBT` returning `complete=true` when it's not
  the case.

  This can happen when some inputs have been signed but the transaction is
  subsequently modified, e.g. in the context of PayJoins.

  Also fixes a related bug where a finalized hex string is attempted to be
  added during `walletprocesspsbt` but a CHECK_NONFATAL causes an abort.

ACKs for top commit:
  achow101:
    ACK 7e36dca657
  ismaelsadeeq:
    Tested ACK 7e36dca657
  pinheadmz:
    re-ACK 7e36dca657

Tree-SHA512: e35d19789899c543866d86d513506494d672e4bed9aa36a995dbec4e72f0a8ec5536b57c4a940a18002ae4a8efd0b007c77ba64e57cd52af98e4ac0e7bf650d6
2024-07-16 17:10:19 -04:00
..
bench
Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)
2024-07-16 16:19:07 -04:00
common
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
compat
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
config
…
consensus
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
index
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
init
Introduce Mining interface
2024-06-18 18:47:51 +02:00
interfaces
Merge bitcoin-core/gui#825: Show maximum mempool size in information window
2024-07-14 13:07:44 +01:00
ipc
multiprocess: Add type conversion code for UniValue types
2023-11-28 12:35:50 -05:00
kernel
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
leveldb
Update leveldb-subtree subtree to latest upstream
2024-06-13 13:17:57 +01:00
logging
Use steady clock for logging timer
2023-01-31 18:48:50 +01:00
minisketch
Update minisketch subtree to latest master
2024-06-12 14:38:39 +01:00
node
Merge bitcoin/bitcoin#30428: log: LogError with FlatFilePos in UndoReadFromDisk
2024-07-15 13:42:53 -04:00
policy
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
Merge bitcoin-core/gui#827: OptionsDialog: Prefer to stretch actual options area rather than waste space
2024-07-15 12:15:09 +01:00
rpc
Merge bitcoin/bitcoin#30429: rpc: Use CHECK_NONFATAL over Assert
2024-07-16 16:00:33 -04:00
script
Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)
2024-07-16 16:19:07 -04:00
secp256k1
Update secp256k1 subtree to latest master
2024-06-25 15:01:00 +01:00
support
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
test
Merge bitcoin/bitcoin#28263: Add fuzz test for FSChaCha20Poly1305, AEADChacha20Poly1305
2024-07-16 12:13:02 +01:00
univalue
test: Fix failing univalue float test
2024-04-16 16:35:12 +02:00
util
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
wallet
Merge bitcoin/bitcoin#30357: Fix cases of calls to FillPSBT errantly returning complete=true
2024-07-16 17:10:19 -04:00
zmq
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
.bear-tidy-config
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
.clang-format
refactor: Print verbose serialize compiler error messages
2023-12-15 15:20:54 +01:00
.clang-tidy
Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment
2024-07-11 19:21:05 +01:00
addrdb.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
addresstype.h
bugfix: Mark CNoDestination and PubKeyDestination constructor explicit
2023-10-25 22:46:55 +02:00
addrman_impl.h
Remove timedata
2024-04-10 17:01:27 +02:00
addrman.cpp
random: add RandomMixin::randbits with compile-known bits
2024-07-01 10:26:46 -04:00
addrman.h
doc, test: Test and explain service flag handling
2024-01-15 16:19:53 -05:00
arith_uint256.cpp
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
arith_uint256.h
Merge bitcoin/bitcoin#30234: Enable clang-tidy checks for self-assignment
2024-07-11 19:21:05 +01:00
attributes.h
Introduce platform-agnostic ALWAYS_INLINE macro
2023-05-04 20:57:51 +01:00
banman.cpp
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
banman.h
net_processing: remove Misbehavior score and increments
2024-05-30 08:35:18 -04:00
base58.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
base58.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
bech32.cpp
Reduce memory copying operations in bech32 encode
2024-06-05 13:18:13 +02:00
bech32.h
refactor: Model the bech32 charlimit as an Enum
2024-05-13 12:07:47 +02:00
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
kernel: De-globalize signature cache
2024-07-05 09:03:04 +02:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
Merge bitcoin/bitcoin#29015: kernel: Streamline util library
2024-06-12 17:12:54 -04:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#29015: kernel: Streamline util library
2024-06-12 17:12:54 -04:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes
2024-05-01 08:33:04 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
Merge bitcoin/bitcoin#29015: kernel: Streamline util library
2024-06-12 17:12:54 -04:00
bitcoind-res.rc
…
bitcoind.cpp
refactor: remove warnings globals
2024-06-13 11:20:49 +01:00
blockencodings.cpp
test: Make blockencodings_tests deterministic
2024-06-19 22:56:30 +01:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
chain.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
chainparams.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
seeds: Update testnet seeds
2024-03-04 19:53:30 -05:00
checkqueue.h
refactor: Make CCheckQueue non-copyable and non-movable explicitly
2023-10-03 10:52:17 +01:00
clientversion.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
clientversion.h
scripted-diff: Add IWYU pragma keep to bitcoin-config.h includes
2024-05-01 08:33:04 +02:00
coins.cpp
log: use error level for critical log messages
2024-06-10 13:46:56 +02:00
coins.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
core_io.h
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
core_memusage.h
…
core_read.cpp
refactor: Mark some static global vars as const
2024-07-08 21:19:23 +02:00
core_write.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
dbwrapper.h
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
deploymentinfo.cpp
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentinfo.h
Decouple RegTestChainParams from ArgsManager
2023-03-15 16:42:42 +01:00
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
dummywallet.cpp
wallet, test: Be able to always swap BDB endianness
2024-05-16 15:03:13 -04:00
external_signer.cpp
external_signer: replace boost::process with cpp-subprocess
2024-03-27 14:16:37 +00:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
scripted-diff: Replace error() with LogError()
2024-03-11 13:49:37 +01:00
flatfile.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
hash.cpp
crypto, hash: replace custom rotl32 with std::rotl
2024-01-05 17:12:38 +01:00
hash.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
headerssync.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
Merge bitcoin/bitcoin#28167: init: Add option for rpccookie permissions (replace 26088)
2024-06-27 17:35:08 -04:00
httprpc.h
…
httpserver.cpp
rest: don't copy data when sending binary response
2024-06-26 06:47:30 +03:00
httpserver.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
i2p.cpp
Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
2024-06-26 15:28:26 -04:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#22729: Make it possible to disable Tor binds and abort startup on bind failure
2024-07-16 16:27:24 -04:00
init.h
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
key_io.cpp
refactor: Allow std::span construction from CKey
2024-01-16 15:29:18 +01:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
refactor: remove unused CKey::Negate method
2024-06-03 16:59:43 +02:00
key.h
refactor: add self-assign checks to classes which violate the clang-tidy check
2024-06-14 10:27:03 +00:00
logging.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
logging.h
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
Makefile.am
remove truc_policy.cpp from libbitcoin_common_a_SOURCES
2024-07-11 11:55:37 +01:00
Makefile.bench.include
Merge bitcoin/bitcoin#28923: script/sign: avoid duplicated signature verification after signing (+introduce signing benchmarks)
2024-07-16 16:19:07 -04:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
build: remove minisketch clz check
2024-04-12 14:28:34 +02:00
Makefile.qt_locale.include
qt: 27.0 translations update
2024-03-04 10:02:26 +00:00
Makefile.qt.include
build, test, doc: Temporarily remove Android-related stuff
2024-05-06 11:29:14 +01:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
fuzz: move MockedDescriptorConverter to fuzz/util
2023-11-20 15:57:50 -03:00
Makefile.test_util.include
random: move XoRoShiRo128PlusPlus into random module
2024-07-01 10:26:46 -04:00
Makefile.test.include
Add fuzz test for AEADChacha20Poly1305
2024-07-15 18:25:59 +05:30
Makefile.univalue.include
…
mapport.cpp
upnp: add compatibility for miniupnpc 2.2.8
2024-06-18 12:24:48 +00:00
mapport.h
Remove configure-time setting of DEFAULT_UPNP
2023-01-28 15:24:13 +00:00
memusage.h
add std::list to memusage
2023-09-13 11:37:45 +01:00
merkleblock.cpp
[clang-tidy] Enable the misc-no-recursion check
2024-04-07 14:04:45 +01:00
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
net_permissions.h
Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections
2024-02-28 10:05:56 -03:00
net_processing.cpp
Merge bitcoin/bitcoin#30394: net: fix race condition in self-connect detection
2024-07-16 09:40:53 +01:00
net_processing.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_types.cpp
rpc: avoid copying into UniValue
2024-05-20 16:48:19 +00:00
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Merge bitcoin/bitcoin#22729: Make it possible to disable Tor binds and abort startup on bind failure
2024-07-16 16:27:24 -04:00
net.h
Merge bitcoin/bitcoin#30394: net: fix race condition in self-connect detection
2024-07-16 09:40:53 +01:00
netaddress.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
netaddress.h
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
netbase.cpp
refactor: use #ifdef HAVE_SOCKADDR_UN
2024-06-21 09:43:46 +01:00
netbase.h
netbase: extend CreateSock() to support creating arbitrary sockets
2024-06-14 14:23:50 +02:00
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
node: Use log levels in noui_ThreadSafeMessageBox
2024-03-21 16:41:16 +01:00
noui.h
…
outputtype.cpp
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
outputtype.h
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
pow.cpp
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
pow.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
prevector.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
protocol.cpp
protocol: make message types constexpr
2024-02-28 18:03:23 +01:00
protocol.h
Merge bitcoin/bitcoin#29421: net: make the list of known message types a compile time constant
2024-05-21 13:59:33 -04:00
psbt.cpp
util: add TransactionError includes and namespace declarations
2024-05-16 10:16:08 -05:00
psbt.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
pubkey.cpp
crypto: add NUMS_H const
2024-05-14 10:24:31 +02:00
pubkey.h
crypto: add NUMS_H const
2024-05-14 10:24:31 +02:00
random.cpp
random: replace construct/assign with explicit Reseed()
2024-07-01 12:39:57 -04:00
random.h
random: drop ad-hoc Shuffle in favor of std::shuffle
2024-07-06 09:06:36 -04:00
randomenv.cpp
util: Use SteadyClock in RandAddSeedPerfmon
2024-07-01 17:40:35 +02:00
randomenv.h
…
rest.cpp
rest: don't copy data when sending binary response
2024-06-26 06:47:30 +03:00
rest.h
…
reverse_iterator.h
doc: remove usages of C++11
2023-01-12 13:42:44 +00:00
scheduler.cpp
scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner
2024-02-15 14:43:14 +01:00
scheduler.h
kernel: Remove dependency on CScheduler
2024-02-16 17:12:52 +01:00
serialize.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
signet.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
signet.h
…
span.h
Allow int8_t optimized vector serialization
2023-12-22 09:58:19 +01:00
streams.cpp
Add AutoFile::seek and tell
2024-04-01 14:37:24 -04:00
streams.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
sync.cpp
util: avoid using thread_local variable that has a destructor
2024-05-16 18:16:46 +02:00
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
torcontrol.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
torcontrol.h
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
txmempool.h
[[refactor]] Check CTxMemPool options in constructor
2024-05-17 23:37:25 +02:00
txorphanage.cpp
scripted-diff: Replace nNextSweep with m_next_sweep
2024-05-29 09:02:07 -07:00
txorphanage.h
Don't use iterator addresses in IteratorComparator
2024-06-19 10:14:31 +01:00
txrequest.cpp
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
txrequest.h
…
uint256.cpp
refactor: modernize the implementation of uint256.*
2022-12-10 14:34:44 -06:00
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
Merge bitcoin/bitcoin#30425: kernel: De-globalize static validation variables
2024-07-16 10:14:23 -04:00
validation.h
refactor: De-globalize last notified header index
2024-07-08 21:19:22 +02:00
validationinterface.cpp
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
validationinterface.h
kernel: Remove dependency on CScheduler
2024-02-16 17:12:52 +01:00
versionbits.cpp
refactor: use braced init for integer constants instead of c style casts
2023-01-03 19:31:29 -06:00
versionbits.h
scripted-diff: Bump copyright headers
2022-12-24 23:49:50 +00:00
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00