mirror of
https://github.com/bitcoin/bitcoin.git
synced 2025-03-27 10:12:16 +01:00
71383f2fad
Don't enable `-Werror` (in the CI) for compilers at least older than our current release compiler (GCC 10). It provides little-to-no value, other than turning compiler bugs & false positives into build failures, and we aren't going to mutate perfectly fine/working code, for the sake of avoid a warning that shouldn't even exist. I also do not see the point of playing whack-a-mole and turning off various warnings/trying to further work around the broken compiler, just to acheive warningless builds for the sake of warningless builds. One anecdote from "How SQLite Is Tested": > Static analysis has found a few bugs in SQLite, but those are the > exceptions. More bugs have been introduced into SQLite while trying > to get it to compile without warnings than have been found by static > analysis. https://www.sqlite.org/testing.html.