mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-20 07:09:15 +01:00

Files

MarcoFalke 54a7ef612a Merge #17399 : validation: Templatize ValidationState instead of subclassing

10efc0487c Templatize ValidationState instead of subclassing (Jeffrey Czyz)
10e85d4adc Remove ValidationState's constructor (Jeffrey Czyz)
0aed17ef28 Refactor FormatStateMessage into ValidationState (Jeffrey Czyz)

Pull request description:

  This removes boilerplate code in the subclasses which otherwise only
  differ by the result type.

  The subclassing was introduced in a27a295.

ACKs for top commit:
  MarcoFalke:
    ACK 10efc0487c 🐱
  ajtowns:
    ACK 10efc0487c -- looks good to me
  jonatack:
    ACK 10efc048 code review, build/tests green, nice cleanup

Tree-SHA512: 765dd52dde7d49b9a5c6d99d97c96f4492673e2aed0b0604faa88db0308fa4500a26bf755cca0b896be283874096c215932e1110a2d01dc012cd36a5fce58a42

2020-03-01 15:34:05 -05:00

blockfilter.cpp

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

blockfilter.h

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

logging.cpp

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

logging.h

scripted-diff: test: Move setup_common to test library

2019-11-06 11:56:41 -05:00

mining.cpp

rpc: Remove mempool global from miner

2019-12-23 06:12:10 +07:00

mining.h

rpc: Remove mempool global from miner

2019-12-23 06:12:10 +07:00

README.md

doc: Add documentation for new test/lib

2019-11-06 11:56:53 -05:00

setup_common.cpp

Refactor FormatStateMessage into ValidationState

2020-02-27 17:59:07 -08:00

setup_common.h

[lib] add scheduler to node context

2020-02-17 14:49:34 -08:00

str.cpp

tests: Move CaseInsensitiveEqual to test/util/str

2019-11-05 09:23:44 +00:00

str.h

[test] move string helper functions into test library

2019-11-25 01:33:17 +01:00

transaction_utils.cpp

refactor: test/bench: dedup SetupDummyInputs()

2020-02-28 21:09:03 +01:00

transaction_utils.h

refactor: test/bench: dedup SetupDummyInputs()

2020-02-28 21:09:03 +01:00

wallet.cpp

Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman

2020-01-23 16:34:28 -05:00

wallet.h

[test] move wallet helper functions into test library

2019-11-25 16:40:09 +01:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).