highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-21 21:20:07 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
7317e14a44c6efc545e6fb9bcedee7174e93a8fa
bitcoin/src
History
MarcoFalke 7317e14a44 Merge bitcoin/bitcoin#22263: refactor: wrap CCoinsViewCursor in unique_ptr 
7ad414f4bf doc: add comment about CCoinsViewDBCursor constructor (James O'Beirne)
0f8a5a4dd5 move-only(ish): don't expose CCoinsViewDBCursor (James O'Beirne)
615c1adfb0 refactor: wrap CCoinsViewCursor in unique_ptr (James O'Beirne)

Pull request description:

  I tripped over this one for a few hours at the beginning of the week, so I've sort of got a personal vendetta against `CCoinsView::Cursor()` returning a raw pointer.

  Specifically in the case of CCoinsViewDB, if a raw cursor is allocated and not freed, a cryptic leveldb assertion failure occurs on CCoinsViewDB destruction (`Assertion 'dummy_versions_.next_ == &dummy_versions_' failed.`).

  This is a pretty simple change.

  Related to: https://github.com/bitcoin/bitcoin/issues/21766
  See also: https://github.com/google/leveldb/issues/142#issuecomment-414418135

ACKs for top commit:
  MarcoFalke:
    review ACK 7ad414f4bf 🔎
  jonatack:
    re-ACK 7ad414f4bf modulo suggestion
  ryanofsky:
    Code review ACK 7ad414f4bf. Two new commits look good and thanks for clarifying constructor comment

Tree-SHA512: 6471d03e2de674d84b1ea0d31e25f433d52aa1aa4996f7b4aab1bd02b6bc340b15e64cc8ea07bbefefa3b5da35384ca5400cc230434e787c30931b8574c672f9
2021-06-23 18:32:35 +02:00
..
bench
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
compat
Remove support for double serialization
2021-05-24 16:15:05 -07:00
config
…
consensus
Mark CheckTxInputs [[nodiscard]] (out-param txfee only set if call is successful). Avoid UUM in fuzzing harness coins_view.
2021-05-25 21:09:05 +00:00
crc32c
…
crypto
…
index
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
init
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
interfaces
refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage
2021-06-16 10:48:58 +02:00
ipc
…
leveldb
…
logging
…
node
script, doc: spelling update
2021-06-23 13:33:18 +02:00
policy
MOVEONLY: context-free package policies
2021-06-02 17:26:44 +01:00
primitives
…
qt
gui: misc external signer fixes and translation hints
2021-06-16 10:48:58 +02:00
rpc
Merge bitcoin/bitcoin#22263: refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-23 18:32:35 +02:00
script
script, doc: spelling update
2021-06-23 13:33:18 +02:00
secp256k1
…
support
…
test
Merge bitcoin/bitcoin#22263: refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-23 18:32:35 +02:00
univalue
…
util
refactor: reduce #ifdef ENABLE_EXTERNAL_SIGNER usage
2021-06-16 10:48:58 +02:00
wallet
Merge bitcoin/bitcoin#22166: Add support for inferring tr() descriptors
2021-06-23 22:42:30 +12:00
zmq
zmq: use msg: prefix over errno= in zmqError
2021-06-09 19:25:13 +08:00
.clang-format
…
addrdb.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrdb.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
addrman.cpp
Add AssertLockHeld to CAddrMan private functions
2021-06-14 17:28:38 +03:00
addrman.h
refactor: Make CAddrMan::cs non-recursive
2021-06-14 17:28:38 +03:00
amount.h
…
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
banman.h
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
rpc: Prefix rpcwaittimeout error with details on its nature
2021-06-03 11:23:22 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
…
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
…
bitcoind-res.rc
…
bitcoind.cpp
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
…
blockfilter.h
…
bloom.cpp
…
bloom.h
…
chain.cpp
…
chain.h
doc: Various validation doc fixups
2021-06-03 13:53:31 +02:00
chainparams.cpp
CRegTestParams: Use args instead of gArgs.
2021-06-02 22:36:48 +02:00
chainparams.h
…
chainparamsbase.cpp
…
chainparamsbase.h
…
chainparamsseeds.h
contrib: remove torv2 seed nodes
2021-06-03 14:04:06 +02:00
checkqueue.h
…
clientversion.cpp
…
clientversion.h
…
coins.cpp
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
coins.h
refactor: wrap CCoinsViewCursor in unique_ptr
2021-06-17 09:47:08 -04:00
compat.h
…
compressor.cpp
…
compressor.h
…
core_io.h
…
core_memusage.h
…
core_read.cpp
Add support for SIGHASH_DEFAULT in RPCs, and make it default
2021-06-12 12:38:17 -07:00
core_write.cpp
…
cuckoocache.h
…
dbwrapper.cpp
…
dbwrapper.h
…
dummywallet.cpp
…
external_signer.cpp
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
external_signer.h
refactor: make ExternalSigner NetworkArg() and m_chain private
2021-06-16 10:48:58 +02:00
flatfile.cpp
…
flatfile.h
…
fs.cpp
…
fs.h
…
hash.cpp
…
hash.h
…
httprpc.cpp
…
httprpc.h
…
httpserver.cpp
Merge bitcoin/bitcoin#19033: http: Release work queue after event base finish
2021-06-21 11:15:42 +02:00
httpserver.h
…
i2p.cpp
…
i2p.h
…
indirectmap.h
…
init.cpp
banman: save the banlist in a JSON format on disk
2021-06-21 14:39:44 +02:00
init.h
Make SetupServerArgs callable without NodeContext
2021-06-10 09:58:45 -05:00
key_io.cpp
Separate WitnessV1Taproot variant in CTxDestination
2021-05-24 12:14:16 -07:00
key_io.h
…
key.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
key.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
logging.cpp
…
logging.h
…
Makefile.am
Merge bitcoin/bitcoin#22084: package testmempoolaccept followups
2021-06-10 19:09:54 +08:00
Makefile.bench.include
…
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.qt_locale.include
…
Makefile.qt.include
Merge bitcoin/bitcoin#21654: build, qt: Make Qt rcc output always deterministic
2021-06-03 21:25:30 +08:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
…
Makefile.test_util.include
…
Makefile.test.include
fuzz: fix fuzz binary linking order
2021-06-16 10:41:24 +02:00
mapport.cpp
…
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
…
miner.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
miner.h
miner: Pass in chainman to RegenerateCommitments
2021-05-27 13:50:11 -04:00
net_permissions.cpp
…
net_permissions.h
…
net_processing.cpp
script, doc: spelling update
2021-06-23 13:33:18 +02:00
net_processing.h
…
net_types.h
…
net.cpp
Merge bitcoin/bitcoin#22144: Randomize message processing peer order
2021-06-16 11:27:16 +08:00
net.h
p2p: extend inbound eviction protection by network to I2P peers
2021-06-14 14:01:35 +02:00
netaddress.cpp
p2p, rpc, fuzz: various tiny follow-ups
2021-06-06 15:49:22 +02:00
netaddress.h
Merge bitcoin/bitcoin#18722: addrman: improve performance by using more suitable containers
2021-06-12 11:41:27 +08:00
netbase.cpp
…
netbase.h
…
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
…
outputtype.h
…
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
…
protocol.h
Add roundtrip fuzz tests for CAddress serialization
2021-05-24 18:06:35 -07:00
psbt.cpp
Make GetInputUTXO safer: verify non-witness UTXO match
2021-06-12 12:25:28 -07:00
psbt.h
Construct and use PrecomputedTransactionData in PSBT signing
2021-06-12 12:25:28 -07:00
pubkey.cpp
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
pubkey.h
Add CKey::SignSchnorr function for BIP 340/341 signing
2021-06-12 12:25:28 -07:00
random.cpp
…
random.h
…
randomenv.cpp
…
randomenv.h
…
rest.cpp
validation: Farewell, global Chainstate!
2021-06-10 15:05:25 -04:00
reverse_iterator.h
…
scheduler.cpp
…
scheduler.h
…
serialize.h
refactor: Switch serialize to uint8_t (1/n)
2021-05-31 14:56:17 +02:00
shutdown.cpp
…
shutdown.h
…
signet.cpp
…
signet.h
…
span.h
…
streams.h
…
sync.cpp
…
sync.h
…
threadinterrupt.cpp
…
threadinterrupt.h
…
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
scripted-diff: Replace GetDataDir() calls with gArgs.GetDataDirNet() calls
2021-05-24 10:29:58 +02:00
torcontrol.h
…
txdb.cpp
doc: add comment about CCoinsViewDBCursor constructor
2021-06-18 14:15:39 -04:00
txdb.h
move-only(ish): don't expose CCoinsViewDBCursor
2021-06-18 14:14:15 -04:00
txmempool.cpp
scripted-diff: tree-wide: Remove all review-only assertions
2021-06-10 15:05:24 -04:00
txmempool.h
[refactor] comment/naming improvements
2021-06-02 09:40:40 +01:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
…
txrequest.h
…
uint256.cpp
…
uint256.h
Make XOnlyPubKey act like byte container
2021-05-24 12:14:16 -07:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#22102: Remove Warning: from warning message printed for unknown new rules
2021-06-13 09:21:46 +02:00
validation.h
validation: Farewell, global Chainstate!
2021-06-10 15:05:25 -04:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
…
versionbits.h
…
versionbitsinfo.cpp
…
versionbitsinfo.h
…
walletinitinterface.h
…
warnings.cpp
…
warnings.h
…