MarcoFalke 74a960a220 Merge bitcoin/bitcoin#21714: refactor: Drop CCoinControl::SetNull ...

c5a470eee1 refactor: Drop CCoinControl::SetNull (João Barbosa)

Pull request description:

  The only external call to `SetNull` is changed as follow

  ```diff
  - m_coin_control->SetNull();
  + m_coin_control = std::make_unique<CCoinControl>();
  ```

ACKs for top commit:
  theStack:
    Code-Review ACK c5a470eee1
  MarcoFalke:
    review ACK c5a470eee1 🍤

Tree-SHA512: 2588828720cdcf405fc4fb06f2aa17ad4eef2a645e12d820311006127e732258dd084993f17f23742f8e7f782e18289a6199dcec3690efc9b92458f90b816a8f

2021-04-26 09:20:44 +02:00

..

test

test: Reset mocktime in the common setup

2021-04-14 17:38:07 +02:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coinselection.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

coinselection.h

Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping

2021-02-01 22:43:17 +13:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

wallet: List all wallets in non-SQLite or non-BDB builds

2020-12-04 11:03:28 -04:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

external_signer_scriptpubkeyman.h

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

feebumper.cpp

Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing

2021-03-09 10:42:21 +13:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

…

init.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

interfaces.cpp

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

ismine.h

doc: Add developer documentation to isminetype

2021-01-19 19:04:45 +08:00

load.cpp

remove unnecessary newline from initWarning() argument

2021-03-24 04:31:48 -06:00

load.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

rpcdump.cpp

rpc: Keep default argument value in correct type

2021-04-17 00:22:53 +01:00

rpcwallet.cpp

rpc: Keep default argument value in correct type

2021-04-17 00:22:53 +01:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

scriptpubkeyman.h

wallet: ExternalSigner: add GetDescriptors method

2021-02-23 14:34:31 +01:00

sqlite.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

wallet.cpp

wallet: remove CWallet::GetExternalSigner()

2021-04-13 20:09:33 +08:00

wallet.h

wallet: remove CWallet::GetExternalSigner()

2021-04-13 20:09:33 +08:00

walletdb.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

walletutil.h

wallet: add external_signer flag

2021-02-23 14:34:30 +01:00