mirror of https://github.com/bitcoin/bitcoin.git synced 2025-05-02 16:01:58 +02:00

History

Merge bitcoin/bitcoin#28200 : refactor: Remove unused includes from wallet.cpp

fa6286891fa4164510e4fbf4bc214ce3033b2d1b Remove unused includes from wallet.cpp (MarcoFalke)
fa8fdbe22932a4717d2bc4060269da9bff228728 Remove unused includes from blockfilter.h (MarcoFalke)
fad8c36aa9011c3f7b1183f8380577e16a2167a6 move-only: Create src/kernel/mempool_removal_reason.h (MarcoFalke)
fa5760880094c4e4238249f6d1837cd74383cc3a Remove unused includes from txmempool.h (MarcoFalke)

Pull request description:

  This makes compilation of wallet.cpp use a few % less memory and time, locally.

  Created in the context of https://github.com/bitcoin/bitcoin/issues/28109, but I don't think it is enough to actually fix this problem.

ACKs for top commit:
  hebasto:
    ACK fa6286891fa4164510e4fbf4bc214ce3033b2d1b, I have reviewed the code and it looks OK.

Tree-SHA512: 06f1120af2a8ef3368dbd9ae747acda88ace2507bd261bcc10341d476a0b3d71c8485377ea6c108b47df3e4c13b7f75a15f486bafa6a8466303168dde16ebbc8

2023-08-22 10:34:10 +01:00

all-lint.py

Use same Python executable for subprocesses as for all-lint.py

2023-01-03 23:23:07 +02:00

check-doc.py

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

commit-script-check.sh

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

git-subtree-check.sh

scripted-diff: Bump copyright headers

2021-12-30 19:36:57 +02:00

lint-assertions.py

test: Make linter to look for BOOST_ASSERT macros

2023-06-14 16:26:11 +01:00

lint-circular-dependencies.py

Remove unused includes from wallet.cpp

2023-08-18 08:20:43 +02:00

lint-files.py

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

lint-format-strings.py

tidy: Integrate bicoin-tidy clang-tidy plugin

2023-08-03 17:52:24 +01:00

lint-git-commit-check.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-include-guards.py

tidy: Integrate bicoin-tidy clang-tidy plugin

2023-08-03 17:52:24 +01:00

lint-includes.py

tidy: Integrate bicoin-tidy clang-tidy plugin

2023-08-03 17:52:24 +01:00

lint-locale-dependence.py

fuzz: Remove legacy int parse fuzz tests

2023-03-27 16:37:31 +02:00

lint-python-dead-code.py

lint: Convert Python dead code linter to Python

2022-04-06 00:55:22 +02:00

lint-python-mutable-default-parameters.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-python-utf8-encoding.py

lint: Ignore check_fileopens failure on **kwargs

2023-07-20 09:15:43 +02:00

lint-python.py

lint: stop ignoring LIEF imports

2023-05-29 10:23:52 +01:00

lint-shell-locale.py

refactor: cleanups post unsubtree'ing univalue

2022-06-15 12:56:44 +01:00

lint-shell.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-spelling.py

contrib: remove builder keys

2022-12-19 17:21:35 +00:00

lint-submodule.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-tests.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

lint-whitespace.py

scripted-diff: Use new python 3.7 keywords

2023-01-18 13:00:34 +01:00

README.md

ci: Use DOCKER_BUILDKIT for lint image

2023-07-16 13:18:18 +02:00

run-lint-format-strings.py

refactor: Enforce C-str fmt strings in WalletLogPrintf()

2023-08-08 10:55:11 +02:00

spelling.ignore-words.txt

script: update ignored-words.txt

2023-06-29 16:14:07 -06:00

README.md

This folder contains lint scripts.

Running locally

To run linters locally with the same versions as the CI environment, use the included Dockerfile:

DOCKER_BUILDKIT=1 docker build -t bitcoin-linter --file "./ci/lint_imagefile" ./

docker run --rm -v $(pwd):/bitcoin -it bitcoin-linter

After building the container once, you can simply run the last command any time you want to lint.

check-doc.py

Check for missing documentation of command line options.

commit-script-check.sh

Verification of scripted diffs. Scripted diffs are only assumed to run on the latest LTS release of Ubuntu. Running them on other operating systems might require installing GNU tools, such as GNU sed.

git-subtree-check.sh

Run this script from the root of the repository to verify that a subtree matches the contents of the commit it claims to have been updated to.

Usage: test/lint/git-subtree-check.sh [-r] DIR [COMMIT]
       test/lint/git-subtree-check.sh -?

DIR is the prefix within the repository to check.
COMMIT is the commit to check, if it is not provided, HEAD will be used.
-r checks that subtree commit is present in repository.

To do a full check with -r, make sure that you have fetched the upstream repository branch in which the subtree is maintained:

for src/secp256k1: https://github.com/bitcoin-core/secp256k1.git (branch master)
for src/leveldb: https://github.com/bitcoin-core/leveldb-subtree.git (branch bitcoin-fork)
for src/crypto/ctaes: https://github.com/bitcoin-core/ctaes.git (branch master)
for src/crc32c: https://github.com/bitcoin-core/crc32c-subtree.git (branch bitcoin-fork)
for src/minisketch: https://github.com/sipa/minisketch.git (branch master)

To do so, add the upstream repository as remote:

git remote add --fetch secp256k1 https://github.com/bitcoin-core/secp256k1.git

all-lint.py

Calls other scripts with the lint- prefix.