mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-19 14:53:43 +01:00
7502d4e940
fabc2615aftest: Use extra_port() helper in feature_bind_extra.py (MarcoFalke) Pull request description: This is a refactor for self-validating and self-documenting code. Currently, the test assumes that extra ports are available and just increments them without checking. However, this may not be the case when the test is modified to use more ports. In this case, the tests may fail intermittently and the failure is hard to debug. Fix this confusion, by calling `p2p_port` each time. This ensures the required `assert n <= MAX_NODES` is checked each time. Closes https://github.com/bitcoin/bitcoin/issues/33250 ACKs for top commit: achow101: ACKfabc2615afjanb84: crACKfabc2615afw0xlt: ACKfabc2615afTree-SHA512: 1eff00be7f43104ae8a66e79fbf64075ec22bb20f392ac1e4c8a7dd694d4f1760aa44ea54ab7b1f2b947ab018851ab3c10d3c717714c0bee4d8d24617594c2bb
107 lines
3.9 KiB
Python
Executable File
107 lines
3.9 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""
|
|
Test starting bitcoind with -bind and/or -bind=...=onion, confirm that
|
|
it binds to the expected ports, and verify that duplicate or conflicting
|
|
-bind/-whitebind configurations are rejected with a descriptive error.
|
|
"""
|
|
|
|
from itertools import combinations_with_replacement
|
|
from test_framework.netutil import (
|
|
addr_to_hex,
|
|
get_bind_addrs,
|
|
)
|
|
from test_framework.test_framework import (
|
|
BitcoinTestFramework,
|
|
)
|
|
from test_framework.test_node import ErrorMatch
|
|
from test_framework.util import (
|
|
assert_equal,
|
|
p2p_port,
|
|
rpc_port,
|
|
)
|
|
|
|
class BindExtraTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.setup_clean_chain = True
|
|
# Avoid any -bind= on the command line. Force the framework to avoid
|
|
# adding -bind=127.0.0.1.
|
|
self.bind_to_localhost_only = False
|
|
self.num_nodes = 3
|
|
|
|
def skip_test_if_missing_module(self):
|
|
# Due to OS-specific network stats queries, we only run on Linux.
|
|
self.skip_if_platform_not_linux()
|
|
|
|
def setup_network(self):
|
|
loopback_ipv4 = addr_to_hex("127.0.0.1")
|
|
|
|
# Start custom ports by reusing unused p2p ports
|
|
def extra_port():
|
|
port = p2p_port(extra_port.index)
|
|
extra_port.index += 1
|
|
return port
|
|
extra_port.index = self.num_nodes
|
|
|
|
# Array of tuples [command line arguments, expected bind addresses].
|
|
self.expected = []
|
|
|
|
# Node0, no normal -bind=... with -bind=...=onion, thus only the tor target.
|
|
port = extra_port()
|
|
self.expected.append(
|
|
[
|
|
[f"-bind=127.0.0.1:{port}=onion"],
|
|
[(loopback_ipv4, port)],
|
|
],
|
|
)
|
|
|
|
# Node1, both -bind=... and -bind=...=onion.
|
|
port = [extra_port(), extra_port()]
|
|
self.expected.append(
|
|
[
|
|
[f"-bind=127.0.0.1:{port[0]}", f"-bind=127.0.0.1:{port[1]}=onion"],
|
|
[(loopback_ipv4, port[0]), (loopback_ipv4, port[1])],
|
|
],
|
|
)
|
|
|
|
# Node2, no -bind=...=onion, thus no extra port for Tor target.
|
|
port = extra_port()
|
|
self.expected.append(
|
|
[
|
|
[f"-bind=127.0.0.1:{port}"],
|
|
[(loopback_ipv4, port)],
|
|
],
|
|
)
|
|
|
|
self.extra_args = list(map(lambda e: e[0], self.expected))
|
|
self.setup_nodes()
|
|
|
|
def run_test(self):
|
|
for i, (args, expected_services) in enumerate(self.expected):
|
|
self.log.info(f"Checking listening ports of node {i} with {args}")
|
|
pid = self.nodes[i].process.pid
|
|
binds = set(get_bind_addrs(pid))
|
|
# Remove IPv6 addresses because on some CI environments "::1" is not configured
|
|
# on the system (so our test_ipv6_local() would return False), but it is
|
|
# possible to bind on "::". This makes it unpredictable whether to expect
|
|
# that bitcoind has bound on "::1" (for RPC) and "::" (for P2P).
|
|
ipv6_addr_len_bytes = 32
|
|
binds = set(filter(lambda e: len(e[0]) != ipv6_addr_len_bytes, binds))
|
|
# Remove RPC ports. They are not relevant for this test.
|
|
binds = set(filter(lambda e: e[1] != rpc_port(i), binds))
|
|
assert_equal(binds, set(expected_services))
|
|
|
|
self.stop_node(0)
|
|
|
|
addr = "127.0.0.1:11012"
|
|
for opt1, opt2 in combinations_with_replacement([f"-bind={addr}", f"-bind={addr}=onion", f"-whitebind=noban@{addr}"], 2):
|
|
self.nodes[0].assert_start_raises_init_error(
|
|
[opt1, opt2],
|
|
"Error: Duplicate binding configuration",
|
|
match=ErrorMatch.PARTIAL_REGEX)
|
|
|
|
if __name__ == '__main__':
|
|
BindExtraTest(__file__).main()
|