fanquake e826b22da2 Merge bitcoin/bitcoin#22275: A few follow-ups for taproot signing ...

08f57a0057 Assert that IsComplete() in GetSpendData() (Pieter Wuille)
d8f4b976d5 Remove default nHashTypeIn arguments to MutableTransactionSignatureCreator (Pieter Wuille)
c7048aae95 Simplify SignTransaction precomputation loop (Pieter Wuille)
addb9b5a71 Improve comments in taproot signing logic (Pieter Wuille)

Pull request description:

  This addresses a few review comments from #21365 that were left at the time of merge (as well as some from #22166 applying to the commit it shared with #21365).

  I do not think any are blockers for a 22.0 release.

ACKs for top commit:
  theStack:
    re-ACK 08f57a0057 🌴
  Zero-1729:
    crACK 08f57a0
  jonatack:
    Code review ACK 08f57a0057 per `git range-diff e9d6eb1 9336670 08f57a0` followed by re-code review per commit to swap context back into memory and debug build/run unit tests + feature_taproot.py as a sanity check

Tree-SHA512: 968750109ba8d6faf3016035a38f81c6aefb724c632a3cab0bbf43cf31b9d187b6b0fddd8772768f57338df11eb07ab9c4c6dacdf3cf35b71f29699c67a301ea

2021-08-23 12:25:49 +08:00

..

bitcoinconsensus.cpp

Make all SignatureChecker explicit about missing data

2021-03-15 17:29:39 -07:00

bitcoinconsensus.h

build: test for __declspec(dllexport) in configure

2021-02-12 09:04:16 +08:00

descriptor.cpp

Pass in DescriptorCache to ToNormalizedString

2021-06-24 14:08:45 -04:00

descriptor.h

Pass in DescriptorCache to ToNormalizedString

2021-06-24 14:08:45 -04:00

interpreter.cpp

Avoid temporary vectors/uint256s in VerifyTaprootCommitment

2021-08-20 14:30:59 -04:00

interpreter.h

Improve comments in taproot signing logic

2021-08-20 14:29:23 -04:00

keyorigin.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

script_error.cpp

Implement Tapscript script validation rules (BIP 342)

2020-10-12 17:18:24 -07:00

script_error.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

script.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

script.h

Implement Tapscript script validation rules (BIP 342)

2020-10-12 17:18:24 -07:00

sigcache.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

sigcache.h

Make all SignatureChecker explicit about missing data

2021-03-15 17:29:39 -07:00

sign.cpp

Simplify SignTransaction precomputation loop

2021-08-20 14:29:23 -04:00

sign.h

Remove default nHashTypeIn arguments to MutableTransactionSignatureCreator

2021-08-20 14:29:23 -04:00

signingprovider.cpp

Add TaprootSpendData data structure, equivalent to script map for P2[W]SH

2021-06-12 12:25:28 -07:00

signingprovider.h

Add TaprootSpendData data structure, equivalent to script map for P2[W]SH

2021-06-12 12:25:28 -07:00

standard.cpp

Assert that IsComplete() in GetSpendData()

2021-08-20 14:29:23 -04:00

standard.h

Improve comments in taproot signing logic

2021-08-20 14:29:23 -04:00