Andrew Chow c109e7d51c Merge bitcoin/bitcoin#24530: wallet: assert BnB's internally calculated waste is the same as GetSelectionWaste ...

ec7d73628a [wallet] assert BnB internally calculated waste is the same as GetSelectionWaste() (glozow)

Pull request description:

  #22009 introduced a `GetSelectionWaste()` function to determine how much "waste" a coin selection solution has, and is a mirror of the waste calculated inside of `SelectCoinsBnB()`. It would be bad for these two waste metrics to deviate, since it could negatively affect how often we select the BnB solution. Add an assertion to help tests catch a potential accidental change.

ACKs for top commit:
  achow101:
    ACK ec7d73628a
  Xekyo:
    ACK ec7d73628a

Tree-SHA512: 3ab7ad45ae92e7ce3f21824fb975105b6be8382edf47c252df5d13d973a3abdcb675132d223b42fcbb669cca879672c904b8a58d0676e12bf381a9219f4db37c

2022-03-11 16:40:17 +00:00

..

rpc

Merge bitcoin/bitcoin#24453: Bugfix: doc: Correct change_address/changeAddress in wallet RPC help

2022-03-11 16:11:17 +01:00

test

blockstorage: Make m_block_index own CBlockIndex's

2022-02-22 11:52:19 -05:00

bdb.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

[wallet] assert BnB internally calculated waste is the same as GetSelectionWaste()

2022-03-11 12:22:34 +00:00

coinselection.h

…

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

db.h

…

dump.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

dump.h

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

…

interfaces.cpp

…

ismine.h

…

load.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

load.h

…

receive.cpp

wallet: Avoid dropping confirmed coins

2022-01-25 10:15:12 +01:00

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

[wallet] assert BnB internally calculated waste is the same as GetSelectionWaste()

2022-03-11 12:22:34 +00:00

spend.h

…

sqlite.cpp

wallet: refactor: dedup sqlite blob binding

2022-03-06 20:43:16 +01:00

sqlite.h

…

transaction.cpp

…

transaction.h

wallet: add GetWitnessHash()

2022-02-01 08:44:51 -03:00

wallet.cpp

Merge bitcoin/bitcoin#24401: wallet: Add external-signer-support specific error message

2022-02-23 17:19:49 -05:00

wallet.h

wallet: Allow user specified input size to override

2022-01-24 11:23:31 -05:00

walletdb.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

walletdb.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

…