Ava Chow b4a05751b6

Merge bitcoin/bitcoin#29586: wallet: default wallet migration, modify inconvenient backup filename ...

a951dba3a9d7663f009701140d663338e6c526a4 wallet: default wallet migration, modify inconvenient backup filename (furszy)

Pull request description:

  Fixes #29584

  On default legacy wallets, the backup filename starts with an "-" due to the wallet name being empty. This is inconvenient for systems who treat what follows the initial "-" character as flags.

  Note:
  As the user can freely set the wallet name to anything, we could also guard the backup filename against other inconvenient characters in the future (we need to be careful here, because the wallet name could also be a path).

ACKs for top commit:
  achow101:
    ACK a951dba3a9d7663f009701140d663338e6c526a4
  brunoerg:
    utACK a951dba3a9d7663f009701140d663338e6c526a4
  vasild:
    ACK  a951dba3a9d7663f009701140d663338e6c526a4

Tree-SHA512: 6347bb12cfb50526a4baad96e4f1df9d82b493f79f0a0f7e0a1c8335a86a1e8e147c7b7f95cec6ede6f4507506a7eaf7972bd35131a2d5ed4cbbf38d94f0a9ca

2024-03-11 08:59:06 -04:00

..

rpc

Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup

2024-02-20 13:07:48 +00:00

test

Merge bitcoin/bitcoin#28960: kernel: Remove dependency on CScheduler

2024-03-08 20:58:04 -05:00

bdb.cpp

wallet: bdb batch 'ErasePrefix', do not create txn internally

2024-02-12 16:05:15 -03:00

bdb.h

…

coincontrol.cpp

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coincontrol.h

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coinselection.cpp

opt: Skip over barren combinations of tiny UTXOs

2024-02-09 11:03:18 +01:00

coinselection.h

coinselection: Track whether CG completed

2024-02-09 10:50:10 +01:00

context.cpp

…

context.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

crypter.cpp

…

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

wallet: remove unused 'accept_no_keys' arg from decryption process

2024-02-03 12:56:43 -03:00

dump.cpp

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

dump.h

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

external_signer_scriptpubkeyman.cpp

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

external_signer_scriptpubkeyman.h

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

feebumper.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Fix bitcoin_config_h includes

2024-02-13 20:10:44 +00:00

interfaces.cpp

wallet: use optional for change position as an optional in CreateTransaction

2023-12-08 17:12:19 -05:00

load.cpp

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

load.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

receive.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#26008: wallet: cache IsMine scriptPubKeys to improve performance of descriptor wallets

2024-02-20 10:17:46 +00:00

scriptpubkeyman.h

Fix CI-detected codespell warnings

2024-02-23 23:01:07 +01:00

spend.cpp

Merge bitcoin/bitcoin#27877: wallet: Add CoinGrinder coin selection algorithm

2024-02-09 16:38:13 -05:00

spend.h

refactor: pass CRecipient to FundTransaction

2024-01-19 15:04:56 +01:00

sqlite.cpp

Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup

2024-02-20 13:07:48 +00:00

sqlite.h

sqlite: Ensure that only one SQLiteBatch is writing to db at a time

2024-02-06 12:24:36 -05:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

types.h

…

wallet.cpp

wallet: default wallet migration, modify inconvenient backup filename

2024-03-08 19:40:11 -03:00

wallet.h

Merge bitcoin/bitcoin#26008: wallet: cache IsMine scriptPubKeys to improve performance of descriptor wallets

2024-02-20 10:17:46 +00:00

walletdb.cpp

Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup

2024-02-20 13:07:48 +00:00

walletdb.h

wallet: db, introduce 'RunWithinTxn()' helper function

2024-02-12 16:05:14 -03:00

wallettool.cpp

wallettool: Don't create CWallet when dumping DB

2023-12-19 16:54:06 -05:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00