mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
794a753958
e4d80e7001test: close the loop after the network thread has completed (Vasil Dimov)29fba5ddbbtest: close the listeners before terminating the event loop (Vasil Dimov) Pull request description: Whenever a test creates a new `P2PInterface` object a new listener is created inside `NetworkThread.create_listen_server()` by calling `cls.network_event_loop.create_server()`. These listeners are never closed which might result in: ``` 2026-06-10T22:13:35.3934880Z Task was destroyed but it is pending! 2026-06-10T22:13:35.3936020Z task: <Task pending name='Task-54' coro=<BaseSelectorEventLoop._accept_connection2() done, defined at /opt/homebrew/Cellar/python@3.14/3.14.5/Frameworks/Python.framework/Versions/3.14/lib/python3.14/asyncio/selector_events.py:217> wait_for=<Future finished result=None>> ``` when the event loop is closed. Fix that by closing the listeners. Fixes: https://github.com/bitcoin/bitcoin/issues/35508 ACKs for top commit: andrewtoth: ACKe4d80e7001sedited: ACKe4d80e7001Tree-SHA512: b93d06526b4eb31ac445a1a0e379e5ec947661f8ea29f2e07ac88b9e4760b0cc5348638b320ab8d60735f34fc163fcdd18eba42b20e0a7726a98a5136433bd64