mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 21:52:53 +02:00
794befd4b0
0654511e1butil: Check write failures before renaming settings.json (Shrey) Pull request description: This PR Fixes #35373. The error message was updated from: "This is probably caused by disk corruption or a crash" to: "This is probably caused by a full disk, disk corruption or a crash" The following files were updated: 1. src/common/settings.cpp -- Updated the main string formatting for the parse failure. 2. src/test/settings_tests.cpp -- Updated the exact string expectation in the C++ unit test. 3. test/functional/feature_settings.py -- Updated the expected error message in the Python test suite. Configured the Bitcoin Core project natively on Windows using Visual Studio (cmake --preset vs2026-static -DBUILD_GUI=OFF) and it compiled with 100% of the C++ tests passed successfully (347 out of 347). ACKs for top commit: maflcko: review ACK0654511e1b💧 winterrdog: ACK0654511e1bsedited: ACK0654511e1bryanofsky: Code review ACK0654511e1bwith commit message and error message improved since last review Tree-SHA512: d7b49860f2081a5a9d1d44917b0cf372a77f10cf21773c9b3291871c788a122ec5dde063fdf9e1052cf45b8d2667e15585b952e9f037e84f98fb41546bdd1fa9