highperfocused/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-19 14:53:43 +01:00
Code Issues Packages Projects Releases Wiki Activity
Files
799fd7a488362c155cbe730f9a9e85e0c2109fcc
bitcoin/src
History
fanquake 17fdbefd3f Merge bitcoin/bitcoin#23970: Remove pointless and confusing shift in RelayAddress 
fa9f4554ca refactor: Remove pointless and confusing shift in RelayAddress (MarcoFalke)

Pull request description:

  The second argument written to the siphash is already quantized to 24 hours, so it seems confusing to quantize the first argument to 32 bits (out of 64 bits).

  > The shifting is pointless, we should get rid of it. It seems to be a silly evolution of this 2010 Satoshi code: 5cbf753 (where it made sense because everything was XORed together, and the address used the high bits, while the time used the low ones).

  (Copied from https://github.com/bitcoin/bitcoin/pull/18642#issuecomment-613773120)

  (The original code was `uint256 hashRand = hashSalt ^ (((int64)addr.ip)<<32) ^ ((GetTime()+addr.ip)/(24*60*60));`)

  This also allows to remove a integer sanitizer suppression for the whole file.

ACKs for top commit:
  laanwj:
    Code review ACK fa9f4554ca
  sipa:
    utACK fa9f4554ca
  promag:
    Code review ACK fa9f4554ca.

Tree-SHA512: f5fd107464ccd839d6749aed6914b4935e39ab42906546b3f3810a7339fc4633fef931a1783a287572af5ec64525626fa91d147d8ff52eb076740465bf5cf839
2022-01-06 07:35:01 +08:00
..
bench
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
common
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compat
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
config
…
consensus
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
crc32c
Update crc32c subtree
2021-09-29 14:10:29 +02:00
crypto
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
index
Merge bitcoin/bitcoin#23411: refactor: Avoid integer overflow in ApplyStats when activating snapshot
2022-01-05 10:34:29 +01:00
init
scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader
2021-12-22 13:44:55 -05:00
interfaces
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
ipc
refactor: Block unsafe fs::path std::string conversion calls
2021-10-05 11:10:47 -04:00
leveldb
…
logging
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
minisketch
Merge commit 'b6487dc4ef47ec9ea894eceac25f37d0b806f8aa' as 'src/minisketch'
2021-10-21 09:36:07 +08:00
node
doc: Fix typo in LoadBlockIndex
2022-01-05 10:41:16 -03:00
policy
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
primitives
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
qt
Merge bitcoin-core/gui#516: Change 'Show' icon
2022-01-04 12:55:29 +02:00
rpc
doc: Fix typo in getmempoolinfo
2022-01-05 11:40:57 +01:00
script
rpc: Quote user supplied descriptor in error msg
2022-01-01 00:26:08 +13:00
secp256k1
Update secp256k1 subtree to latest upstream master
2021-12-15 09:19:50 -05:00
support
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
test
Merge bitcoin/bitcoin#21879: refactor: wrap accept() and extend usage of Sock
2022-01-05 15:32:53 +01:00
univalue
Update univalue subtree to latest upstream
2021-10-11 20:45:56 +08:00
util
Merge bitcoin/bitcoin#21879: refactor: wrap accept() and extend usage of Sock
2022-01-05 15:32:53 +01:00
wallet
Merge bitcoin/bitcoin#23834: wallettool: Check that the dumpfile checksum is the correct size
2022-01-05 19:16:28 +01:00
zmq
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
.clang-format
Use c++17 in clang-format
2021-11-12 11:46:34 +01:00
.clang-tidy
Enable clang-tidy bugprone-argument-comment and fix violations
2021-09-07 09:11:10 +02:00
addrdb.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
addrdb.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
addrman_impl.h
test: Remove unused AddrManTest class
2021-12-28 21:54:51 +01:00
addrman.cpp
Merge bitcoin/bitcoin#23826: test: Make AddrMan unit tests use public interface, extend coverage
2022-01-04 23:08:11 +08:00
addrman.h
Merge bitcoin/bitcoin#23826: test: Make AddrMan unit tests use public interface, extend coverage
2022-01-04 23:08:11 +08:00
arith_uint256.cpp
…
arith_uint256.h
…
attributes.h
…
banman.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
banman.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
base58.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
base58.h
…
bech32.cpp
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bech32.h
Make Bech32 LocateErrors return error list rather than using out-arg
2021-12-06 14:17:41 +13:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
Merge bitcoin/bitcoin#23784: bitcoin-tx: Require that input amount is provided for witness transactions
2022-01-05 17:48:55 +01:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
bitcoind-res.rc
…
bitcoind.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
blockencodings.cpp
…
blockencodings.h
…
blockfilter.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
blockfilter.h
…
chain.cpp
doc: Tidy up nMinDiskSpace comment
2021-11-26 11:17:43 +01:00
chain.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparams.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparams.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
chainparamsbase.h
…
chainparamsseeds.h
…
checkqueue.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
clientversion.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
clientversion.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
coins.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
coins.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compat.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compressor.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
compressor.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_io.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_memusage.h
…
core_read.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
core_write.cpp
Merge bitcoin/bitcoin#23320: rpc: Add RPC help for getblock verbosity level 3
2022-01-04 15:35:42 +01:00
cuckoocache.h
refactor: Fix implicit-signed-integer-truncation in cuckoocache.h
2021-11-29 14:32:51 +01:00
dbwrapper.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
dbwrapper.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentinfo.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentinfo.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentstatus.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
deploymentstatus.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
dummywallet.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
external_signer.cpp
external_signer: improve fingerprint matching logic (stop on first match)
2021-08-24 11:30:09 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
flatfile.h
…
fs.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
fs.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
hash.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
hash.h
…
httprpc.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httprpc.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httpserver.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
httpserver.h
…
i2p.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
i2p.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
indirectmap.h
…
init.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
init.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key_io.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key_io.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
key.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
logging.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
logging.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
Makefile.am
Move AdditionOverflow to util, Add CheckedAdd with unit tests
2021-12-17 10:46:39 +01:00
Makefile.bench.include
…
Makefile.crc32c.include
build: remove support for weak linking getauxval()
2021-09-24 15:40:04 +08:00
Makefile.leveldb.include
build: remove build stubs for external leveldb
2021-10-15 01:02:45 +00:00
Makefile.minisketch.include
build: add minisketch build file and include it
2021-10-21 09:37:30 +08:00
Makefile.qt_locale.include
…
Makefile.qt.include
build, android: Fix Android GUI not loading on Qt 5.15
2021-12-13 19:27:46 +01:00
Makefile.qttest.include
build, qt: use static QAndroidPlatformIntegrationPlugin
2021-12-13 19:24:33 +01:00
Makefile.test_fuzz.include
…
Makefile.test_util.include
move-only: unittest: add test/util/chainstate.h
2021-09-15 15:46:48 -04:00
Makefile.test.include
Merge bitcoin/bitcoin#22704: fuzz: Differential fuzzing to compare Bitcoin Core's and D. J. Bernstein's implementation of ChaCha20
2021-12-17 16:56:05 +01:00
Makefile.univalue.include
Integrate univalue into our buildsystem
2021-10-11 20:46:25 +08:00
mapport.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
mapport.h
…
memusage.h
…
merkleblock.cpp
…
merkleblock.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_permissions.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_processing.cpp
refactor: Remove pointless and confusing shift in RelayAddress
2022-01-04 17:07:29 +01:00
net_processing.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net_types.cpp
net: Drop only invalid entries when reading banlist.json
2021-12-14 18:58:45 +01:00
net_types.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
net.cpp
Merge bitcoin/bitcoin#21879: refactor: wrap accept() and extend usage of Sock
2022-01-05 15:32:53 +01:00
net.h
Merge bitcoin/bitcoin#21879: refactor: wrap accept() and extend usage of Sock
2022-01-05 15:32:53 +01:00
netaddress.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netaddress.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netbase.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netbase.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
netmessagemaker.h
…
noui.cpp
…
noui.h
…
outputtype.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
outputtype.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
protocol.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
psbt.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
psbt.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pubkey.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
pubkey.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
random.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
random.h
…
randomenv.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
randomenv.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
rest.cpp
Merge bitcoin/bitcoin#23836: rest: Expose block filters follow-ups
2022-01-02 08:37:12 +08:00
reverse_iterator.h
…
scheduler.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
scheduler.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
serialize.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
shutdown.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
shutdown.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
signet.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
span.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
streams.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
sync.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
sync.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
threadinterrupt.cpp
…
threadinterrupt.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
threadsafety.h
…
timedata.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
timedata.h
…
tinyformat.h
…
torcontrol.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
torcontrol.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txdb.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txdb.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txmempool.cpp
Merge bitcoin/bitcoin#23683: bug fix: valid but different LockPoints after a reorg
2022-01-03 14:34:39 +01:00
txmempool.h
Merge bitcoin/bitcoin#23683: bug fix: valid but different LockPoints after a reorg
2022-01-03 14:34:39 +01:00
txorphanage.cpp
…
txorphanage.h
…
txrequest.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
txrequest.h
…
uint256.cpp
…
uint256.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#23581: Move BlockManager to node/blockstorage
2022-01-04 10:49:38 +08:00
validation.h
Move BlockManager to node/blockstorage
2022-01-02 17:05:14 +01:00
validationinterface.cpp
…
validationinterface.h
…
version.h
…
versionbits.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
versionbits.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
walletinitinterface.h
…
warnings.cpp
…
warnings.h
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00