mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-12 21:52:53 +02:00
fad753611b
Both are fine and this refactor shouldn't change any behavior.
However, inline constexpr will ensure each symbol has a single address
across all TU, making the release binary smaller.
Note, a follow-up commit will deal with string literals (const char*)
and other static const, which can not be constexpr (e.g. std::vector).
-BEGIN VERIFY SCRIPT-
# Limit to types that can be constexpr
type='bool|CAmount|size_t|((signed|unsigned) )?int|u?int[0-9]+_t|std::array|DatabaseFormat|CFeeRate|std::streamsize'
sed -i --regexp-extended "s/^(static )?const (${type})\>/inline constexpr \2/" $( \
git grep -l --extended-regexp "^(static )?const " -- \
'*.h' \
':(exclude)src/leveldb' \
':(exclude)src/secp256k1' \
)
-END VERIFY SCRIPT-
40 lines
1.4 KiB
C++
40 lines
1.4 KiB
C++
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#ifndef BITCOIN_CLIENTVERSION_H
|
|
#define BITCOIN_CLIENTVERSION_H
|
|
|
|
#include <util/macros.h>
|
|
|
|
#include <bitcoin-build-config.h> // IWYU pragma: keep
|
|
|
|
// Check that required client information is defined
|
|
#if !defined(CLIENT_VERSION_MAJOR) || !defined(CLIENT_VERSION_MINOR) || !defined(CLIENT_VERSION_BUILD) || !defined(CLIENT_VERSION_IS_RELEASE) || !defined(COPYRIGHT_YEAR)
|
|
#error Client version information missing: version is not defined by bitcoin-build-config.h or in any other way
|
|
#endif
|
|
|
|
//! Copyright string used in Windows .rc files
|
|
#define COPYRIGHT_STR "2009-" STRINGIZE(COPYRIGHT_YEAR) " " COPYRIGHT_HOLDERS_FINAL
|
|
|
|
// Windows .rc files include this header, but they cannot cope with real C++ code.
|
|
#if !defined(RC_INVOKED)
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
inline constexpr int CLIENT_VERSION =
|
|
10000 * CLIENT_VERSION_MAJOR
|
|
+ 100 * CLIENT_VERSION_MINOR
|
|
+ 1 * CLIENT_VERSION_BUILD;
|
|
|
|
extern const std::string UA_NAME;
|
|
|
|
|
|
std::string FormatFullVersion();
|
|
std::string FormatSubVersion(const std::string& name, int nClientVersion, const std::vector<std::string>& comments);
|
|
|
|
#endif // RC_INVOKED
|
|
|
|
#endif // BITCOIN_CLIENTVERSION_H
|