glozow 7e1007a3c6 Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods ...

b527b54950 net: convert standalone SetSocketNonBlocking() to Sock::SetNonBlocking() (Vasil Dimov)
29f66f7682 moveonly: move SetSocketNonBlocking() from netbase to util/sock (Vasil Dimov)
b4bac55679 net: convert standalone IsSelectableSocket() to Sock::IsSelectable() (Vasil Dimov)
5db7d2ca0a moveonly: move IsSelectableSocket() from compat.h to sock.{h,cpp} (Vasil Dimov)

Pull request description:

  _This is a piece of #21878, chopped off to ease review._

  * convert standalone `IsSelectableSocket()` to `Sock::IsSelectable()`
  * convert standalone `SetSocketNonBlocking()` to `Sock::SetNonBlocking()`

  This further encapsulates syscalls inside the `Sock` class and makes the callers mockable.

ACKs for top commit:
  jonatack:
    ACK b527b54950 review/debug build/unit tests at each commit, cross-referenced the changes with `man select` and `man errno`, ran a signet node on the last commit with ip4/ip6//tor/i2p/cjdns and network connections were nominal
  dergoegge:
    Code review ACK b527b54950

Tree-SHA512: af783ce558c7a89e173f7ab323fb3517103d765c19b5d14de29f64706b4e1fea3653492e8ea73ae972699986aaddf2ae72c7cfaa7dad7614254283083b7d2632

2022-10-12 15:49:02 -04:00

..

asmap.cpp

Merge bitcoin/bitcoin#25285: Add AutoFile without ser-type and ser-version and use it where possible

2022-07-20 09:32:11 +01:00

asmap.h

…

bip32.cpp

Fix iwyu

2022-08-20 09:33:01 +02:00

bip32.h

…

bitdeque.h

Add bitdeque, an std::deque<bool> analogue that does bit packing.

2022-08-23 11:34:10 -04:00

bytevectorhash.cpp

…

bytevectorhash.h

…

check.cpp

…

check.h

…

epochguard.h

…

error.cpp

Validate port options

2022-10-05 19:30:15 +02:00

error.h

Validate port options

2022-10-05 19:30:15 +02:00

fastrange.h

…

fees.cpp

…

fees.h

…

getuniquepath.cpp

…

getuniquepath.h

…

golombrice.h

…

hash_type.h

…

hasher.cpp

…

hasher.h

…

macros.h

…

message.cpp

Fix iwyu

2022-08-20 09:33:01 +02:00

message.h

…

moneystr.cpp

…

moneystr.h

…

overflow.h

…

overloaded.h

…

rbf.cpp

…

rbf.h

…

readwritefile.cpp

…

readwritefile.h

…

result.h

refactor: Replace BResult with util::Result

2022-08-03 07:33:01 -04:00

serfloat.cpp

…

serfloat.h

…

settings.cpp

…

settings.h

…

sock.cpp

net: convert standalone SetSocketNonBlocking() to Sock::SetNonBlocking()

2022-07-20 16:26:24 +02:00

sock.h

net: convert standalone SetSocketNonBlocking() to Sock::SetNonBlocking()

2022-07-20 16:26:24 +02:00

spanparsing.cpp

…

spanparsing.h

…

strencodings.cpp

Validate port value in SplitHostPort

2022-10-05 19:24:04 +02:00

strencodings.h

Validate port value in SplitHostPort

2022-10-05 19:24:04 +02:00

string.cpp

Fix issues when calling std::move(const&)

2022-08-20 09:32:53 +02:00

string.h

Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)

2022-08-31 08:38:24 +01:00

syscall_sandbox.cpp

…

syscall_sandbox.h

…

syserror.cpp

…

syserror.h

…

system.cpp

kernel: move RunCommandParseJSON to its own file

2022-10-04 13:51:40 +00:00

system.h

kernel: move RunCommandParseJSON to its own file

2022-10-04 13:51:40 +00:00

thread.cpp

refactor: use std::string for thread names

2022-09-13 19:07:39 +01:00

thread.h

refactor: use std::string for thread names

2022-09-13 19:07:39 +01:00

threadnames.cpp

…

threadnames.h

…

time.cpp

refactor: move Boost datetime usage to wallet

2022-10-01 11:41:53 +01:00

time.h

Merge bitcoin/bitcoin#26118: log: Use steady clock for bench logging

2022-10-10 12:00:34 +02:00

tokenpipe.cpp

…

tokenpipe.h

…

trace.h

…

translation.h

…

types.h

…

ui_change_type.h

…

url.cpp

…

url.h

…

vector.h

…