mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-09-11 21:20:39 +02:00
0c6f2af97b
9f0543d69awallet: remove unused DatabaseOptions members (jeanpablo)bbed824a64wallet: remove unused warnings parameter from CreateFromDump (jeanpablo)2f6aa41d3dwallet: remove unused WalletDatabase::m_refcount (jeanpablo)f64b3fa70fwallet: remove unused CHDChain keypool index members (jeanpablo)4afc7bc40dwallet: remove unused COutput::ToString (jeanpablo)a0e9aac428wallet: remove unused DescriptorScriptPubKeyMan::AddDescriptorKey (jeanpablo) Pull request description: Six unused items in src/wallet, one per commit. `DescriptorScriptPubKeyMan::AddDescriptorKey`, a private wrapper that lost its caller in #28333. `COutput::ToString`, no callers. It was used by `COutput::print()`, which went away with the other `print()` methods in wallet. The two `CHDChain` keypool index members, whose last uses went away with `LegacySPKM` in #28710. `WalletDatabase::m_refcount`. Only BDB ever maintained it, and BDB went away in #28710. The `warnings` parameter of `CreateFromDump`, never written, along with the loop that printed it in wallet-tool. The `push_back` went away with the `-format` option in #31250. The two BDB-only members of `DatabaseOptions`, `use_shared_memory` and `max_log_mb`. Their last readers went away with BDB in #28710, along with the `-privdb` and `-dblogsize` options that set them. ACKs for top commit: pablomartin4btc: ACK9f0543d69avicjuma: ACK9f0543d69aTree-SHA512: 0996043a116ee2c653b8c3e2987fbe6d5c4573db1477dfc1b06a433334af160c44382bb1ed0fe234dcaeda09f15b07c7e5d2c2f81fce63c780ef4cac1c30fb29