bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-03-01 02:29:36 +01:00

Files

MarcoFalke 9e3f7dcaa2 Merge bitcoin/bitcoin#22735 : [net] Don't return an optional from TransportDeserializer::GetMessage()

f3e451bebf [net] Replace GetID() with id in TransportDeserializer constructor (Troy Giorshev)
8c96008ab1 [net] Don't return an optional from TransportDeserializer::GetMessage() (Troy Giorshev)

Pull request description:

  Also, access mapRecvBytesPerMsgCmd with `at()` not `find()`. This
  throws an error if COMMAND_OTHER doesn't exist, which should never
  happen. `find()` instead just accessed the last element, which could make
  debugging more difficult.

  Resolves review comments from PR19107:

  - https://github.com/bitcoin/bitcoin/pull/19107#discussion_r478718436
  - https://github.com/bitcoin/bitcoin/pull/19107#discussion_r478714497

ACKs for top commit:
  theStack:
    Code-review ACK f3e451bebf
  ryanofsky:
    Code review ACK f3e451bebf. Changes since last review in https://github.com/bitcoin/bitcoin/pull/20364#pullrequestreview-534369904 were simplifying by dropping the third commit, rebasing, and cleaning up some style & comments in the first commit.

Tree-SHA512: 37de4b25646116e45eba50206e82ed215b0d9942d4847a172c104da4ed76ea4cee29a6fb119f3c34106a9b384263c576cb8671d452965a468f358d4a3fa3c003

2021-11-02 13:40:09 +01:00

addition_overflow.cpp

…

addrman.cpp

Make AddrMan support multiple ports per IP

2021-10-22 12:06:36 -04:00

asmap_direct.cpp

…

asmap.cpp

[asmap] Remove SanityCheckASMap() from netaddress

2021-09-07 13:31:10 +01:00

autofile.cpp

…

banman.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

base_encode_decode.cpp

…

bech32.cpp

…

block_header.cpp

…

block.cpp

…

blockfilter.cpp

…

bloom_filter.cpp

scripted-diff: Move bloom to src/common

2021-10-05 11:10:37 +02:00

buffered_file.cpp

…

chain.cpp

…

checkqueue.cpp

…

coins_view.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

connman.cpp

scripted-diff: Rename CAddrMan to AddrMan

2021-09-28 22:21:10 -04:00

crypto_aes256.cpp

…

crypto_aes256cbc.cpp

…

crypto_chacha20_poly1305_aead.cpp

…

crypto_chacha20.cpp

…

crypto_common.cpp

…

crypto_hkdf_hmac_sha256_l32.cpp

…

crypto_poly1305.cpp

…

crypto.cpp

…

cuckoocache.cpp

…

decode_tx.cpp

…

descriptor_parse.cpp

…

deserialize.cpp

scripted-diff: Rename CAddrInfo to AddrInfo

2021-09-28 22:21:10 -04:00

eval_script.cpp

…

fee_rate.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

fees.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

flatfile.cpp

…

float.cpp

…

fuzz.cpp

…

fuzz.h

…

FuzzedDataProvider.h

…

golomb_rice.cpp

…

hex.cpp

…

http_request.cpp

…

i2p.cpp

…

integer.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

key_io.cpp

…

key.cpp

…

kitchen_sink.cpp

…

load_external_block_file.cpp

…

locale.cpp

Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)

2021-09-30 14:21:17 +00:00

merkleblock.cpp

…

message.cpp

…

muhash.cpp

fuzz: Cleanup muhash fuzz target

2021-09-22 10:39:08 +02:00

multiplication_overflow.cpp

…

net_permissions.cpp

…

net.cpp

[net] Remove asmap argument from CNode::CopyStats()

2021-09-07 15:24:14 +01:00

netaddress.cpp

…

netbase_dns_lookup.cpp

…

node_eviction.cpp

…

p2p_transport_serialization.cpp

…

parse_hd_keypath.cpp

…

parse_iso8601.cpp

…

parse_numbers.cpp

Merge bitcoin/bitcoin#23156 : refactor: Remove unused ParsePrechecks and ParseDouble

2021-10-04 15:06:37 +02:00

parse_script.cpp

…

parse_univalue.cpp

…

policy_estimator_io.cpp

…

policy_estimator.cpp

…

pow.cpp

…

prevector.cpp

…

primitives_transaction.cpp

…

process_message.cpp

…

process_messages.cpp

…

protocol.cpp

…

psbt.cpp

…

random.cpp

…

rbf.cpp

…

rolling_bloom_filter.cpp

scripted-diff: Move bloom to src/common

2021-10-05 11:10:37 +02:00

rpc.cpp

…

script_assets_test_minimizer.cpp

…

script_bitcoin_consensus.cpp

…

script_descriptor_cache.cpp

…

script_flags.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

script_interpreter.cpp

…

script_ops.cpp

…

script_sigcache.cpp

…

script_sign.cpp

…

script.cpp

refactor: share logic between ScriptPubKeyToUniv and ScriptToUniv

2021-09-24 14:22:53 -05:00

scriptnum_ops.cpp

…

secp256k1_ec_seckey_import_export_der.cpp

…

secp256k1_ecdsa_signature_parse_der_lax.cpp

…

signature_checker.cpp

…

signet.cpp

…

socks5.cpp

…

span.cpp

…

spanparsing.cpp

…

string.cpp

Replace use of locale dependent atoi(…) with locale-independent std::from_chars(…) (C++17)

2021-09-30 14:21:17 +00:00

strprintf.cpp

…

system.cpp

fuzz: Fix memory leak in system fuzz target

2021-09-29 13:24:14 +02:00

timedata.cpp

…

torcontrol.cpp

…

transaction.cpp

rpc: remove deprecated addresses and reqSigs from rpc outputs

2021-09-24 14:22:49 -05:00

tx_in.cpp

…

tx_out.cpp

…

tx_pool.cpp

[refactor] pass coinsview and height to check()

2021-10-04 15:00:28 +01:00

txrequest.cpp

Make GenTxid boolean constructor private

2021-10-22 12:32:16 +02:00

util.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

util.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

utxo_snapshot.cpp

refactor: Remove unused validation includes

2021-09-20 12:16:20 +02:00

validation_load_mempool.cpp

…

versionbits.cpp

Move addrman includes from .h to .cpp

2021-09-07 10:44:43 +02:00